]> granicus.if.org Git - neomutt/log
neomutt
7 years agomerge: rename mutt to neomutt
Richard Russon [Tue, 26 Sep 2017 23:17:56 +0000 (00:17 +0100)]
merge: rename mutt to neomutt

 * rename man pages
 * move helper programs to lib dir
 * move mime.types to doc dir
 * contrib: change mutt references to neomutt
 * build: don't install .dist files

7 years agobuild: don't install .dist files 763/head
Richard Russon [Tue, 26 Sep 2017 22:36:05 +0000 (23:36 +0100)]
build: don't install .dist files

7 years agocontrib: change mutt references to neomutt
Richard Russon [Mon, 18 Sep 2017 10:40:31 +0000 (11:40 +0100)]
contrib: change mutt references to neomutt

7 years agomove mime.types to doc dir
Richard Russon [Mon, 18 Sep 2017 10:23:13 +0000 (11:23 +0100)]
move mime.types to doc dir

Many distros have a package providing /etc/mime.types

We put our copy in:
    doc/neomutt/mime.types

7 years agomove helper programs to lib dir
Richard Russon [Sun, 17 Sep 2017 14:44:02 +0000 (15:44 +0100)]
move helper programs to lib dir

Programs:
    lib/neomutt/pgpewrap
    lib/neomutt/pgpring
    lib/neomutt/smime_keys

7 years agorename man pages
Richard Russon [Sun, 17 Sep 2017 10:35:50 +0000 (11:35 +0100)]
rename man pages

Man:
    man1/neomutt.1
    man1/pgpewrap_neomutt.1
    man1/pgpring_neomutt.1
    man1/smime_keys_neomutt.1
    man5/mbox_neomutt.5
    man5/mmdf_neomutt.5
    man5/neomuttrc.5

7 years agodrop unused param in mutt_bcache_put 782/head
Richard Russon [Tue, 26 Sep 2017 16:51:01 +0000 (17:51 +0100)]
drop unused param in mutt_bcache_put

The 'tmp' param was always true.
Factor it out.

Thanks to @gahr for the idea/patch.

7 years agobool: convert function parameters in bcache.h
Anton Rieger [Mon, 25 Sep 2017 00:04:53 +0000 (02:04 +0200)]
bool: convert function parameters in bcache.h

* mutt_bcache_put()

7 years agobuild: expand buffers to avoid gcc7 warnings
Richard Russon [Mon, 25 Sep 2017 01:02:37 +0000 (02:02 +0100)]
build: expand buffers to avoid gcc7 warnings

7 years agobool: convert function parameters in history.h 785/head
Anton Rieger [Mon, 25 Sep 2017 19:05:41 +0000 (21:05 +0200)]
bool: convert function parameters in history.h

* mutt_history_add()
* mutt_history_at_scratch()

7 years agobool: convert function parameters in buffy.h 783/head
Anton Rieger [Mon, 25 Sep 2017 01:10:01 +0000 (03:10 +0200)]
bool: convert function parameters in buffy.h

* buffy_check()
* buffy_maildir_check()
* buffy_mbox_check()
* mh_buffy()

7 years agobool: convert function parameters in attach.h 776/head
Anton Rieger [Sat, 23 Sep 2017 17:54:55 +0000 (19:54 +0200)]
bool: convert function parameters in attach.h

* mutt_attach_display_loop()
* mutt_pipe_attachment_list()
* mutt_print_attachment_list()
* mutt_save_attachment_list()

7 years agofix: crash looking up mime body type 787/head
Richard Russon [Tue, 26 Sep 2017 11:00:10 +0000 (12:00 +0100)]
fix: crash looking up mime body type

This is a buffer overrun.
The mime type was being looked up in the BodyTypes table,
but there wasn't an entry for TYPEANY.

Fixes #784

7 years agofix: crash in mutt_substrdup 781/head
Richard Russon [Sun, 24 Sep 2017 22:35:48 +0000 (23:35 +0100)]
fix: crash in mutt_substrdup

Fixes #780

7 years agofix: crash in mbox_to_udomain 779/head
Richard Russon [Sun, 24 Sep 2017 11:18:25 +0000 (12:18 +0100)]
fix: crash in mbox_to_udomain

Fixes #778

7 years agoFix off-by-one buffer overflow in add_index_color 775/head
Jakub Wilk [Sat, 23 Sep 2017 15:35:29 +0000 (17:35 +0200)]
Fix off-by-one buffer overflow in add_index_color

7 years agomerge: upstream fixes (mutt/default)
Richard Russon [Tue, 26 Sep 2017 14:20:38 +0000 (15:20 +0100)]
merge: upstream fixes (mutt/default)

 * clang-format
 * Display an error message when delete mailbox fails. (see #3968)
 * Updated French translation.
 * Fix imap sync segfault due to inactive headers during an expunge. (closes #3971)
 * Close the imap socket for the selected mailbox on error.
 * Add missing IMAP_CMD_POLL flag in imap buffy check.
 * Change maildir and mh check_mailbox to use dynamic sized hash. (closes #3973)

7 years agoChange maildir and mh check_mailbox to use dynamic sized hash. (closes #3973)
Kevin McCarthy [Tue, 26 Sep 2017 01:40:32 +0000 (18:40 -0700)]
Change maildir and mh check_mailbox to use dynamic sized hash. (closes #3973)

The original patch is by Matt Fleming, originally posted at
http://www.codeblueprint.co.uk/2017/01/15/a-kernel-devs-approach-to-improving2

The comments there indicate Matt tried to submit to trac and mutt-dev,
but ran into registration problems.  Thank you for the patch, and
sorry for those problems, Matt.

I modified the patch by making the same change to the
mh_check_mailbox() code too.

7 years agoAdd missing IMAP_CMD_POLL flag in imap buffy check.
Kevin McCarthy [Fri, 22 Sep 2017 18:14:27 +0000 (11:14 -0700)]
Add missing IMAP_CMD_POLL flag in imap buffy check.

I missed adding the flag to one of the imap_exec() calls inside the
loop, when a different server is encountered in the mailboxes list.

7 years agoClose the imap socket for the selected mailbox on error.
Kevin McCarthy [Fri, 22 Sep 2017 18:12:25 +0000 (11:12 -0700)]
Close the imap socket for the selected mailbox on error.

The new $imap_poll_timeout calls the cmd_handle_fatal() error handler
on timeout, which is supposed to close and cleanup.

However, for the currently selected mailbox, the error handler was not
closing the socket after closing up the mailbox.  This left extra
SSL/GnuTLS data around and was causing errors on an attempt to
reconnect.

Thanks to Fabian Groffen for reporting the issue.

7 years agoFix imap sync segfault due to inactive headers during an expunge. (closes #3971)
Kevin McCarthy [Fri, 22 Sep 2017 18:07:27 +0000 (11:07 -0700)]
Fix imap sync segfault due to inactive headers during an expunge. (closes #3971)

Mutt has several places where it turns off h->active as a hack.  For
example to avoid FLAG updates, or to exclude from imap_exec_msgset.

Unfortunately, when a reopen is allowed and the IMAP_EXPUNGE_PENDING
flag becomes set (e.g. a flag update to a modified header),
imap_expunge_mailbox() will be called by imap_cmd_finish().

The mx_update_tables() would free and remove these "inactive" headers,
despite that an EXPUNGE was not received for them.  This would result
in memory leaks and segfaults due to dangling pointers in the
msn_index and uid_hash.

There should probably be a more elegant solution, removing the initial
hacks.  However, this is causing a segfault, and the best solution
right now is to turn active back on for non-expunged messages in
imap_expunge_mailbox().

Extra thanks to chdiza, who bravely runs tip and found this issue
quickly.

7 years agoUpdated French translation.
Vincent Lefevre [Tue, 5 Sep 2017 15:33:45 +0000 (17:33 +0200)]
Updated French translation.

7 years agoDisplay an error message when delete mailbox fails. (see #3968)
Kevin McCarthy [Wed, 20 Sep 2017 17:43:33 +0000 (10:43 -0700)]
Display an error message when delete mailbox fails. (see #3968)

7 years agoclang-format
Richard Russon [Tue, 26 Sep 2017 13:49:04 +0000 (14:49 +0100)]
clang-format

7 years agoUnsubscribe after deleting an imap folder (#730)
seishinryohosha [Fri, 22 Sep 2017 14:51:19 +0000 (16:51 +0200)]
Unsubscribe after deleting an imap folder (#730)

* Unsubscribe after deleting an imap folder

Only added two line to `browser.c` in `_mutt_select_file` case `OP_DELETE_MAILBOX`.

* Fixed typo: Unsubsribe -> Unsubscribe

* Revert previous change

* Added unsubscribe-from command

* Added `unsubscribe-from` command (init.h)
* Added `parse_unsubscribe_from` prototype (init.h)
* Implemented `parse_unsubscribe_from` uses imap/imap.h Header (init.c)

Tokenize buffer and expand each token (path) and finally unsubscribe from it.
No pattern matching is done.

* Unsubscribe after deleting an imap folder

Only added two line to `browser.c` in `_mutt_select_file` case `OP_DELETE_MAILBOX`.

* Fixed typo: Unsubsribe -> Unsubscribe

* Revert previous change

* Added unsubscribe-from command

* Added `unsubscribe-from` command (init.h)
* Added `parse_unsubscribe_from` prototype (init.h)
* Implemented `parse_unsubscribe_from` uses imap/imap.h Header (init.c)

Tokenize buffer and expand each token (path) and finally unsubscribe from it.
No pattern matching is done.

* Unsubscribe after deleting an imap folder

Only added two line to `browser.c` in `_mutt_select_file` case `OP_DELETE_MAILBOX`.

* Fixed typo: Unsubsribe -> Unsubscribe

* Revert previous change

* Unsubscribe after deleting an imap folder

Only added two line to `browser.c` in `_mutt_select_file` case `OP_DELETE_MAILBOX`.

* Fixed typo: Unsubsribe -> Unsubscribe

* Revert previous change

* Added unsubscribe-from command

* Added `unsubscribe-from` command (init.h)
* Added `parse_unsubscribe_from` prototype (init.h)
* Implemented `parse_unsubscribe_from` uses imap/imap.h Header (init.c)

Tokenize buffer and expand each token (path) and finally unsubscribe from it.
No pattern matching is done.

* Added subscribe-to command and updated example

    * Added `subscribe-to` command (init.h)
    * Added `parse_subscribe_to` prototype (init.h)
    * Implemented `parse_subscribe_to` uses imap/imap.h Header (init.c)
    * Example now shows folder and subfolders

    Tokenize buffer and expand each token (path) and finally subscribe from it.
    No pattern matching is done.

* Added return check
It should be noted, that imap_subscribe(FOO, 0) /* unsubcribe */
won't return -1, if mailbox doesn't exists.

* Added return -1, and do not silently ignore

* Added braces to satisfy styleguides

* Added better user output

* Typo Successfull -> Successful

* Reverted back to one parameter only and errors into err.

* Reverted back to one parameter only.
* Better error messages
* Error messages are now stored inside struct Buffer *err

* Changed from strfcpy -> mutt_buffer_*

* Copy&Paste Error correction

* Cleanup

* set expandtab
* set tabstop=2
* merged mutt_buffer_addstr -> mutt_buffer_printf
* corrected "Corrupted buffer" -> mutt_debug(5, ...)
* Compared with clang-format to get sure

* Reverted back bool -> int, to change this in a later PR

inside `parse_unsubscribe_from(...)` and `parse_subscribe_to(...)`
for the `imap_subscribe(...)`-call.

7 years agoRemove spurious error message (#773)
Pietro Cerutti [Fri, 22 Sep 2017 14:51:03 +0000 (15:51 +0100)]
Remove spurious error message (#773)

Issue #772

7 years agorestore ~/.config/mutt to config search path
Richard Russon [Fri, 15 Sep 2017 13:36:42 +0000 (14:36 +0100)]
restore ~/.config/mutt to config search path

Some people are still using this dir.
It will be deprecated in the future.

Also, drop the dated/versioned config files.
Nobody was using them.

    ~/.mutt/neomutt-20170912

7 years agoKill include line altogether
Pietro Cerutti [Fri, 15 Sep 2017 12:27:43 +0000 (12:27 +0000)]
Kill include line altogether

Issue #755

7 years agoDo not include sys/cdefs.h
Pietro Cerutti [Thu, 14 Sep 2017 05:52:48 +0000 (05:52 +0000)]
Do not include sys/cdefs.h

Issue #755

7 years agorestore quote_regexp and reply_regexp
Richard Russon [Fri, 15 Sep 2017 11:12:29 +0000 (12:12 +0100)]
restore quote_regexp and reply_regexp

I shouldn't have renamed these

7 years agofix: %{fmt} date format
Richard Russon [Thu, 14 Sep 2017 16:36:19 +0000 (17:36 +0100)]
fix: %{fmt} date format

A mistake was introduced when moving the date code to the library.
The dates being displayed were those of the base timezone, not the email.

Remove the `%<...>` documentation from `$index_format`

Fixes #757

7 years agorename regexp to regex
Richard Russon [Wed, 13 Sep 2017 17:44:19 +0000 (18:44 +0100)]
rename regexp to regex

'regex' is the more common abbreviation for a regular expression.

7 years agoImprove imap fetch handler to accept an initial UID. (closes #3969)
Kevin McCarthy [Thu, 14 Sep 2017 19:43:32 +0000 (12:43 -0700)]
Improve imap fetch handler to accept an initial UID. (closes #3969)

Gmail sends flag updates with a UID before the FLAGS.  The handler was
very simple, and so ignored the flag update in that case.

Pull the code from msg_parse_fetch(), paring down to just UID and
FLAGS.  This will handle arbitrary order data items.

7 years agoChange imap copy/save and trash to sync flags, excluding deleted. (closes #3966)...
Kevin McCarthy [Wed, 13 Sep 2017 22:48:16 +0000 (15:48 -0700)]
Change imap copy/save and trash to sync flags, excluding deleted. (closes #3966) (closes #3860)

imap_copy_messages() uses a helper to sync the flags before performing
a server-side copy.  However, it had a bug that the "deleted" flag on
a local message, if set, will be propagated to the copy too.

Change the copy sync helper to ignore the deleted flag.  Then, change
the imap trash function to use the same helper.

Thanks to Anton Lindqvist for his excellent bug report, suggested
fixes, and help testing.

7 years agoRemove \Seen flag setting for imap trash. (see #3966) (see #3860)
Kevin McCarthy [Wed, 13 Sep 2017 22:48:13 +0000 (15:48 -0700)]
Remove \Seen flag setting for imap trash. (see #3966) (see #3860)

Commit 323e3d6e5e4c has a side effect where spurious FETCH flag
updates after setting the \Seen flag can cause a sync to abort.

Remove manually setting \Seen for all trashed message before copying.

The next commit will change the imap trash function to use the same
code as the imap copy/save function for syncing the message before
server-side copying.

7 years agoDo not pop from MuttrcStack what wasn't pushed
Pietro Cerutti [Wed, 13 Sep 2017 13:05:34 +0000 (13:05 +0000)]
Do not pop from MuttrcStack what wasn't pushed

Issue #751

7 years agofix: set mbox_type
Richard Russon [Wed, 13 Sep 2017 20:59:45 +0000 (21:59 +0100)]
fix: set mbox_type

Thanks to Floyd Anderson (@floand)

Fixes: #754
7 years agoFix two too many s/Mutt/Neo&/
Pietro Cerutti [Wed, 13 Sep 2017 08:14:12 +0000 (08:14 +0000)]
Fix two too many s/Mutt/Neo&/

7 years agomerge: Rename Mutt to NeoMutt
Richard Russon [Tue, 12 Sep 2017 16:54:33 +0000 (17:54 +0100)]
merge: Rename Mutt to NeoMutt

 * drop upstream mutt references
 * rename binary from mutt to neomutt
 * rename contrib files
 * docs: replace mutt refs with neomutt
 * docs: change muttrc references to neomuttrc
 * docs: rename some files
 * code: change mutt references to neomutt
 * docs: remove old vim syntax file
 * update translations to match code changes

7 years agoupdate translations to match code changes
Richard Russon [Sat, 9 Sep 2017 22:47:04 +0000 (23:47 +0100)]
update translations to match code changes

7 years agodocs: remove old vim syntax file
Richard Russon [Sun, 10 Sep 2017 00:11:15 +0000 (01:11 +0100)]
docs: remove old vim syntax file

7 years agocode: change mutt references to neomutt
Richard Russon [Sat, 9 Sep 2017 18:15:28 +0000 (19:15 +0100)]
code: change mutt references to neomutt

7 years agodocs: rename some files
Richard Russon [Sun, 10 Sep 2017 00:24:02 +0000 (01:24 +0100)]
docs: rename some files

7 years agodocs: change muttrc references to neomuttrc
Richard Russon [Sat, 9 Sep 2017 16:44:24 +0000 (17:44 +0100)]
docs: change muttrc references to neomuttrc

7 years agodocs: replace mutt refs with neomutt
Richard Russon [Sat, 9 Sep 2017 16:08:56 +0000 (17:08 +0100)]
docs: replace mutt refs with neomutt

7 years agorename contrib files
Richard Russon [Sat, 9 Sep 2017 13:18:27 +0000 (14:18 +0100)]
rename contrib files

Change references from "mutt" to "neomutt"

7 years agorename binary from mutt to neomutt
Richard Russon [Sat, 9 Sep 2017 12:27:57 +0000 (13:27 +0100)]
rename binary from mutt to neomutt

7 years agodrop upstream mutt references
Richard Russon [Sat, 9 Sep 2017 12:07:20 +0000 (13:07 +0100)]
drop upstream mutt references

NeoMutt no longer refers to the upstream version of Mutt.

7 years agoNeoMutt 2017-09-12 (1.9.0) neomutt-20170912
Richard Russon [Tue, 12 Sep 2017 15:01:47 +0000 (16:01 +0100)]
NeoMutt 2017-09-12 (1.9.0)

7 years agoupdate translations
Richard Russon [Tue, 12 Sep 2017 14:43:12 +0000 (15:43 +0100)]
update translations

7 years agoNeoMutt 2017-09-12 (1.9.0)
Richard Russon [Tue, 12 Sep 2017 14:40:22 +0000 (15:40 +0100)]
NeoMutt 2017-09-12 (1.9.0)

7 years agofix: crash in vfolder-from-query
Florian Klink [Tue, 12 Sep 2017 11:53:09 +0000 (13:53 +0200)]
fix: crash in vfolder-from-query

see #746

7 years agonotmuch: add support for the v5 API
Richard Russon [Mon, 11 Sep 2017 14:08:16 +0000 (15:08 +0100)]
notmuch: add support for the v5 API

Issue: #746

7 years agobuild: fix warnings raised by gcc7
Richard Russon [Mon, 11 Sep 2017 23:18:13 +0000 (00:18 +0100)]
build: fix warnings raised by gcc7

Thanks to David Sterba (@kdave)

7 years agofix: broken check on resend message
Richard Russon [Sat, 9 Sep 2017 11:51:36 +0000 (12:51 +0100)]
fix: broken check on resend message

By boolifying check_all_msg(), it's return value was inverted without
fixing the callers.  This would prevent users resending messages, or
crash.

7 years agoBe more formal about quoting in m4 macros
Pietro Cerutti [Thu, 7 Sep 2017 15:34:32 +0000 (15:34 +0000)]
Be more formal about quoting in m4 macros

7 years agoUse tabs consistently to columnize .mailmap
Pietro Cerutti [Thu, 7 Sep 2017 07:11:43 +0000 (07:11 +0000)]
Use tabs consistently to columnize .mailmap

7 years agoNeoMutt 2017-09-07 (1.9.0) neomutt-20170907
Richard Russon [Thu, 7 Sep 2017 01:09:18 +0000 (02:09 +0100)]
NeoMutt 2017-09-07 (1.9.0)

7 years agoclang-format
Richard Russon [Wed, 6 Sep 2017 18:40:12 +0000 (19:40 +0100)]
clang-format

7 years agofix whitespace
Richard Russon [Wed, 6 Sep 2017 18:16:57 +0000 (19:16 +0100)]
fix whitespace

7 years agoupdate credits/mailmap
Richard Russon [Wed, 6 Sep 2017 14:07:12 +0000 (15:07 +0100)]
update credits/mailmap

7 years agoupdate translations
Richard Russon [Wed, 6 Sep 2017 13:34:49 +0000 (14:34 +0100)]
update translations

7 years agoversion: 2017-09-06
Richard Russon [Wed, 6 Sep 2017 13:29:41 +0000 (14:29 +0100)]
version: 2017-09-06

7 years agofix: version string
Richard Russon [Wed, 6 Sep 2017 17:37:22 +0000 (18:37 +0100)]
fix: version string

7 years agomutt_notmuch: fix setting custom query_type in notmuch query 740/head
Florian Klink [Thu, 31 Aug 2017 02:21:26 +0000 (04:21 +0200)]
mutt_notmuch: fix setting custom query_type in notmuch query

nm_normalize_uri re-builds notmuch queries, but nm_uri_from_query
doesn't set query_type back again, so fix that.
Also, use the NmQueryType enum where possible instead of int.

Fixes #484.

7 years agobuild: fix make dist
Richard Russon [Wed, 6 Sep 2017 12:23:13 +0000 (13:23 +0100)]
build: fix make dist

7 years agomerge: tidying in preparation for config changes
Richard Russon [Wed, 6 Sep 2017 01:41:47 +0000 (02:41 +0100)]
merge: tidying in preparation for config changes

 * lib: move more functions into the library
 * rename DT_ consts
 * rename: rx -> regex
 * rename: Unify the multi-byte char table naming
 * rename: OPT_* to match their config item
 * rename: Global variables to match their config item

7 years agorename: Global variables to match their config item
Richard Russon [Mon, 4 Sep 2017 18:16:37 +0000 (19:16 +0100)]
rename: Global variables to match their config item

Rename lots of constants to match the user-facing config names.
e.g.
    "certificate_file" SslCertFile        -> CertificateFile
    "nm_open_timeout"  NotmuchOpenTimeout -> NmOpenTimeout

7 years agorename: OPT_* to match their config item
Richard Russon [Mon, 4 Sep 2017 17:12:10 +0000 (18:12 +0100)]
rename: OPT_* to match their config item

Rename lots of constants to match the user-facing config names.
e.g.
    "forward_decode"   OPT_FORW_DECODE       -> OPT_FORWARD_DECODE
    "imap_servernoise" OPT_IMAP_SERVER_NOISE -> OPT_IMAP_SERVERNOISE

7 years agorename: Unify the multi-byte char table naming
Richard Russon [Fri, 1 Sep 2017 19:46:23 +0000 (20:46 +0100)]
rename: Unify the multi-byte char table naming

Through the code this was referred to by the names:
- mbchar_table
- mbyte_table
- mbchartbl

7 years agorename: rx -> regex
Richard Russon [Sat, 2 Sep 2017 15:09:12 +0000 (16:09 +0100)]
rename: rx -> regex

Rename all structs and functions to uniformly use the prefix 'regex'.

7 years agorename DT_ consts
Richard Russon [Fri, 1 Sep 2017 16:59:28 +0000 (17:59 +0100)]
rename DT_ consts

Tidy the naming of the DT_* constants that signify the types of config
items.

7 years agolib: move more functions into the library
Richard Russon [Fri, 1 Sep 2017 15:02:43 +0000 (16:02 +0100)]
lib: move more functions into the library

7 years agomerge: upstream fixes (mutt/default)
Richard Russon [Wed, 6 Sep 2017 00:04:22 +0000 (01:04 +0100)]
merge: upstream fixes (mutt/default)

 * Updated Ukrainian translation
 * Updated Russian translation
 * Updated German translation
 * Updated Danish translation
 * Updated Catalan translation
 * Updated Japanese translation
 * Fix the new certificate prompt translations.
 * Fix fp resource leak. (closes #3965)
 * Fix rv assignment in mutt_window_mvprintw(). (closes #3964)
 * Add warning about using inline pgp with format=flowed. (closes #3963)
 * Remove 'really' from the purge-message help description.
 * Updated French translation

7 years agoUpdated French translation
Vincent Lefevre [Tue, 5 Sep 2017 15:33:45 +0000 (17:33 +0200)]
Updated French translation

7 years agoRemove 'really' from the purge-message help description.
Kevin McCarthy [Mon, 4 Sep 2017 22:51:07 +0000 (15:51 -0700)]
Remove 'really' from the purge-message help description.

This made it sound to the translators like a question.

7 years agoAdd warning about using inline pgp with format=flowed. (closes #3963)
Kevin McCarthy [Mon, 4 Sep 2017 20:26:55 +0000 (13:26 -0700)]
Add warning about using inline pgp with format=flowed. (closes #3963)

The reporter noted that when trying to use inline signing with
format=flowed, the flowed was turned off.

After some research, this appears to be deliberate, probably because
of strange interactions between inline PGP and format=flowed.  In fact
the RFC strongly discourages their combined use:
https://tools.ietf.org/html/rfc3676#section-4.6

Add a warning and prompt to use PGP/MIME in mutt_protect().

7 years agoFix rv assignment in mutt_window_mvprintw(). (closes #3964)
Kevin McCarthy [Mon, 4 Sep 2017 16:40:44 +0000 (09:40 -0700)]
Fix rv assignment in mutt_window_mvprintw(). (closes #3964)

Mutt doesn't check the return value, so this wasn't causing a bug, but
was incorrect.

Thanks to dcb314 for reporting the issue.

7 years agoFix fp resource leak. (closes #3965)
Kevin McCarthy [Mon, 4 Sep 2017 16:20:53 +0000 (09:20 -0700)]
Fix fp resource leak. (closes #3965)

Thanks to dcb314 for reporting the issue.

7 years agoFix the new certificate prompt translations.
Kevin McCarthy [Sat, 2 Sep 2017 16:36:52 +0000 (09:36 -0700)]
Fix the new certificate prompt translations.

The Esperanto, Dutch, and Czech po files weren't updated in time for
1.9.  Fix the certificate prompt translations by adding a "(s)kip"
choice.  Otherwise the prompts would not be functional.

7 years agoUpdated Japanese translation
TAKAHASHI Tamotsu [Tue, 5 Sep 2017 15:59:10 +0000 (16:59 +0100)]
Updated Japanese translation

7 years agoUpdated Catalan translation
Ivan Vilata i Balaguer [Tue, 5 Sep 2017 15:57:50 +0000 (16:57 +0100)]
Updated Catalan translation

7 years agoUpdated Danish translation
Morten Bo Johansen [Tue, 5 Sep 2017 15:49:24 +0000 (16:49 +0100)]
Updated Danish translation

7 years agoUpdated German translation
Olaf Hering [Tue, 5 Sep 2017 15:47:17 +0000 (16:47 +0100)]
Updated German translation

7 years agoUpdated Russian translation
Vsevolod Volkov [Tue, 5 Sep 2017 15:42:30 +0000 (16:42 +0100)]
Updated Russian translation

7 years agoUpdated Ukrainian translation
Vsevolod Volkov [Tue, 5 Sep 2017 15:36:52 +0000 (16:36 +0100)]
Updated Ukrainian translation

7 years agobuild: substitute-in package version
Damien Riegel [Fri, 25 Aug 2017 15:46:25 +0000 (16:46 +0100)]
build: substitute-in package version

7 years agorefactor nntp setup
Richard Russon [Thu, 24 Aug 2017 19:52:11 +0000 (20:52 +0100)]
refactor nntp setup

Reorder the code so that NewsServer is only set once.

7 years agobuild: drop unused test/symbol ICONV_NONTRANS
Richard Russon [Thu, 31 Aug 2017 14:30:02 +0000 (15:30 +0100)]
build: drop unused test/symbol ICONV_NONTRANS

7 years agotidy: fix whitespace
Richard Russon [Wed, 23 Aug 2017 23:32:12 +0000 (00:32 +0100)]
tidy: fix whitespace

7 years agomerge: upstream fixes (mutt/default)
Richard Russon [Fri, 1 Sep 2017 12:45:23 +0000 (13:45 +0100)]
merge: upstream fixes (mutt/default)

 * Create ATTACH_CONTEXT to hold attachment index. (see #3728)
 * Change helpers functions to pass actx. (see #3728)
 * Add helpers to add and remove actx entries. (see #3728)
 * Change recvattach to allow nested encryption. (see #3728)
 * Add virtual index to actx. (see #3728)
 * Fix the expand/collapse code to use the virtual index. (see #3728)
 * Fix shared attachment functions. (see #3728)
 * Fix attachment check_traditional and extract_keys operations. (see #3728)
 * Add edit-content-type helper and warning for decrypted attachments. (closes #3728)
 * Fix parent_hdr usage in mutt_attach_reply(). (see #3728)
 * Add option to run command to query attachment mime type. (closes #2933) (closes #3959)

7 years agoAdd option to run command to query attachment mime type. (closes #2933) (closes ...
Kevin McCarthy [Sat, 19 Aug 2017 15:33:57 +0000 (08:33 -0700)]
Add option to run command to query attachment mime type. (closes #2933) (closes #3959)

Add $mime_type_query_command to specify a command to run if the
attachment extension is not in the mime.types file.

Add $mime_type_query_first to allow the query command to be run before
the mime.types lookup.

7 years agoFix parent_hdr usage in mutt_attach_reply(). (see #3728)
Kevin McCarthy [Fri, 11 Aug 2017 16:04:48 +0000 (09:04 -0700)]
Fix parent_hdr usage in mutt_attach_reply(). (see #3728)

If the selected attachments are not messages and no (common) parent is
found, parent_hdr is set to the passed in hdr.  In that case, parent
will still be NULL, but parent_hdr and parent_fp will be set.

Change the test to parent_hdr being NULL, not parent, to check for
this case.

7 years agoAdd edit-content-type helper and warning for decrypted attachments. (closes #3728)
Kevin McCarthy [Fri, 11 Aug 2017 01:18:28 +0000 (18:18 -0700)]
Add edit-content-type helper and warning for decrypted attachments. (closes #3728)

Regenerating the actx index will overwrite any changes made to a
decrypted attachment.  Change the mutt_edit_content_type() function to
return 1 when a structural change is made.  Add a warning message when
that is the case and a decrypted message was edited, so the user is
not surprised.

Note: mutt_edit_content_type() appeared to regenerate multipart
subparts every time, leading to a memory leak.  I believe this was an
oversite, and it should have regenerated only when there were no
subparts, so have "fixed" this.

7 years agoFix attachment check_traditional and extract_keys operations. (see #3728)
Kevin McCarthy [Fri, 11 Aug 2017 01:18:26 +0000 (18:18 -0700)]
Fix attachment check_traditional and extract_keys operations. (see #3728)

Add helpers and iterate over the actx->idx instead of the BODY structure.

7 years agoFix shared attachment functions. (see #3728)
Kevin McCarthy [Fri, 11 Aug 2017 01:18:25 +0000 (18:18 -0700)]
Fix shared attachment functions. (see #3728)

With nested decryption, the correct FP is associated with the
ATTACHPTR entry.  Also, the BODY entries are not continguous, so the
functions need to iterate over the actx index, not the BODY structure.

7 years agoFix the expand/collapse code to use the virtual index. (see #3728)
Kevin McCarthy [Fri, 11 Aug 2017 01:18:24 +0000 (18:18 -0700)]
Fix the expand/collapse code to use the virtual index. (see #3728)

Fix the init code to respect OPTDIGESTCOLLAPSE.

7 years agoAdd virtual index to actx. (see #3728)
Kevin McCarthy [Fri, 11 Aug 2017 01:18:22 +0000 (18:18 -0700)]
Add virtual index to actx. (see #3728)

The virtual index is modeled after the CONTEXT.  Add a CURATTACH
helper to reduce code verbosity.  Store the actx as menu->data.

Simplify and consolidate the recvattach and compose menu update code
inside a function.

Because compose and recvattach share so much code, change compose to
use the virtual index even though it has no collapse/expand
functionality.

7 years agoChange recvattach to allow nested encryption. (see #3728)
Kevin McCarthy [Fri, 11 Aug 2017 01:18:21 +0000 (18:18 -0700)]
Change recvattach to allow nested encryption. (see #3728)

* Add a FP and BODY array to the actx.  These are used to allow proper
  cleanup.

* Add HEADER and root_fp entries, to allow for index regeneration.

* Separate out the compose and recvattach index generation functions.

* Change the recvattach index generator to decrypt as encrypted parts
  are found.

7 years agoAdd helpers to add and remove actx entries. (see #3728)
Kevin McCarthy [Fri, 11 Aug 2017 01:18:20 +0000 (18:18 -0700)]
Add helpers to add and remove actx entries. (see #3728)

Use the helper in compose update_idx(), to consolidate the resize
logic and simplify the code.

Separate out the actx "free" routine from a routine to empty out the
idx.  The index regeneration routines should flush and rebuild the
index without having to renerate the actx structure.