]> granicus.if.org Git - php/log
php
4 years agoChanged the wording of the error message
Dharman [Tue, 15 Sep 2020 17:42:38 +0000 (18:42 +0100)]
Changed the wording of the error message

"cannot be used in MYSQLI_USE_RESULT mode" sounds more correct than "cannot be used with MYSQLI_USE_RESULT"

Closes GH-6137.

4 years agoRemove unused GMP_ABS() macro
Nikita Popov [Wed, 16 Sep 2020 08:42:10 +0000 (10:42 +0200)]
Remove unused GMP_ABS() macro

4 years agoExclude trait methods from call-graph
Dmitry Stogov [Wed, 16 Sep 2020 09:04:29 +0000 (12:04 +0300)]
Exclude trait methods from call-graph

4 years agoAvoid ubsan warning due to memcpy null
Nikita Popov [Wed, 16 Sep 2020 08:28:28 +0000 (10:28 +0200)]
Avoid ubsan warning due to memcpy null

This showed up in ext/mysqli/tests/mysqli_change_user.phpt on azure
today. Not seeing it locally though, and also not sure why it decided
to show up now...

4 years agoFix test
Matteo Beccati [Wed, 16 Sep 2020 08:04:14 +0000 (10:04 +0200)]
Fix test

follow-up to 7a95e94 for MySQL < 5.6

4 years agoFixed incorrect constant string access
Dmitry Stogov [Wed, 16 Sep 2020 07:49:54 +0000 (10:49 +0300)]
Fixed incorrect constant string access

4 years agoJIT for INIT_METHOD_CALL
Dmitry Stogov [Wed, 16 Sep 2020 07:25:36 +0000 (10:25 +0300)]
JIT for INIT_METHOD_CALL

4 years agomissing fix for test for new param. name
Remi Collet [Wed, 16 Sep 2020 05:58:53 +0000 (07:58 +0200)]
missing fix for test for new param. name

4 years agoAdd some ValueErrors to ext/date
George Peter Banyard [Fri, 22 May 2020 14:43:07 +0000 (16:43 +0200)]
Add some ValueErrors to ext/date

Closes GH-5613

4 years agoUpdate NEWS for 8.0.0RC1
Sara Golemon [Tue, 15 Sep 2020 18:38:15 +0000 (18:38 +0000)]
Update NEWS for 8.0.0RC1

4 years agoUpdate NEWS for PHP 8.0.0beta4
Sara Golemon [Tue, 15 Sep 2020 18:30:23 +0000 (18:30 +0000)]
Update NEWS for PHP 8.0.0beta4

4 years agoFix OSS Fuzz issue: yielding from an aborted generator
Bob Weinand [Tue, 15 Sep 2020 18:07:25 +0000 (20:07 +0200)]
Fix OSS Fuzz issue: yielding from an aborted generator

4 years agoPromote warnings to Error in MySQLi extension
George Peter Banyard [Fri, 3 Jul 2020 11:43:29 +0000 (13:43 +0200)]
Promote warnings to Error in MySQLi extension

Closes GH-5803

4 years agoFix uninitialized run-time cache when resolving named param defaults
Nikita Popov [Tue, 15 Sep 2020 14:08:14 +0000 (16:08 +0200)]
Fix uninitialized run-time cache when resolving named param defaults

Fixes oss-fuzz #25676.

4 years agoFix undef var exception handling in JMP_NULL
Nikita Popov [Tue, 15 Sep 2020 13:43:31 +0000 (15:43 +0200)]
Fix undef var exception handling in JMP_NULL

We need to initialize the result variable in the exceptional
case as well.

Fixes oss-fuzz #25526.

4 years agoMerge branch 'PHP-7.4'
Nikita Popov [Tue, 15 Sep 2020 13:26:56 +0000 (15:26 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix assumption about property guard hash value

4 years agoFix assumption about property guard hash value
Nikita Popov [Tue, 15 Sep 2020 13:25:22 +0000 (15:25 +0200)]
Fix assumption about property guard hash value

The "member" string here does not necessarily have a pre-calculated
hash value. In particular this is not the case if the class has no
properties.

Fixes oss-fuzz #25546.

4 years agofix mbfl function prototypes
Remi Collet [Tue, 15 Sep 2020 11:54:27 +0000 (13:54 +0200)]
fix mbfl function prototypes
re-add mbfl_convert_filter_feed API
re-add pointer cast

4 years agoFix compile-time/run-time discrepancies with unary operators
Nikita Popov [Tue, 15 Sep 2020 13:06:56 +0000 (15:06 +0200)]
Fix compile-time/run-time discrepancies with unary operators

This addresses two issues:
 * ~ throws for a number of types, and we should not compile-time
   evaluate in that case. Add a check similar to what we do for
   binary ops.
 * Unary +/- may produce a different error message due to
   canonicalization of the constant operand to the RHS. To avoid
   this, put the constant operand on the RHS right away.

Fixes oss-fuzz #25649.

4 years agoTracing JIT for INIT_DYNAMIC_CALL (closure only)
Dmitry Stogov [Tue, 15 Sep 2020 12:57:57 +0000 (15:57 +0300)]
Tracing JIT for INIT_DYNAMIC_CALL (closure only)

4 years agoRemove unintendedly committed test
Máté Kocsis [Tue, 15 Sep 2020 12:49:30 +0000 (14:49 +0200)]
Remove unintendedly committed test

4 years agoAdjust ext/openssl parameter names
Máté Kocsis [Sat, 12 Sep 2020 21:53:15 +0000 (23:53 +0200)]
Adjust ext/openssl parameter names

Closes GH-6121

4 years agoPromote a few remaining errors in ext/standard
Máté Kocsis [Thu, 10 Sep 2020 11:28:18 +0000 (13:28 +0200)]
Promote a few remaining errors in ext/standard

Closes GH-6110

4 years agoPromote warnings to Error in SNMP extension
George Peter Banyard [Tue, 8 Sep 2020 14:59:35 +0000 (16:59 +0200)]
Promote warnings to Error in SNMP extension

4 years agoCheck `ReflectionReference::fromArrayElement` with union types
Gabriel Caruso [Mon, 14 Sep 2020 14:06:18 +0000 (16:06 +0200)]
Check `ReflectionReference::fromArrayElement` with union types

ReflectionReference::fromArrayElement(array $array, int|string $key): ?ReflectionReference
is going to be its official signature for PHP 8.0.

Closes GH-5651

4 years agoPromote warning to Error in ODBC extension
George Peter Banyard [Sat, 12 Sep 2020 23:08:18 +0000 (01:08 +0200)]
Promote warning to Error in ODBC extension

Closes GH-6123

4 years agoUse ValueError instead of exceptions in SPL extension
George Peter Banyard [Sat, 12 Sep 2020 01:00:53 +0000 (03:00 +0200)]
Use ValueError instead of exceptions in SPL extension

4 years agoUse normal error in SPL for uninitialized objects
George Peter Banyard [Fri, 11 Sep 2020 16:58:32 +0000 (18:58 +0200)]
Use normal error in SPL for uninitialized objects

4 years agoUse normal error in SPL for 'An iterator cannot be used with foreach by reference'
George Peter Banyard [Fri, 11 Sep 2020 16:35:50 +0000 (18:35 +0200)]
Use normal error in SPL for 'An iterator cannot be used with foreach by reference'

4 years agoConvert warning to assetion in MySQL PDO driver
George Peter Banyard [Sat, 12 Sep 2020 21:53:52 +0000 (23:53 +0200)]
Convert warning to assetion in MySQL PDO driver

Closes GH-6120

4 years agoAdd missing param type to pcre reflection test
Máté Kocsis [Tue, 15 Sep 2020 10:46:40 +0000 (12:46 +0200)]
Add missing param type to pcre reflection test

4 years agoFix preg_replace_callback_array() with array subject
Nikita Popov [Tue, 15 Sep 2020 09:26:59 +0000 (11:26 +0200)]
Fix preg_replace_callback_array() with array subject

Apparently this "feature" was completely untested...

4 years agoAdd GC_TRY_ADDREF macro
Nikita Popov [Tue, 15 Sep 2020 09:38:40 +0000 (11:38 +0200)]
Add GC_TRY_ADDREF macro

That adds a ref if not immutable. Also audit uses of GC_IMMUTABLE
to either use GC_TRY_ADDREF or GC_TRY_PROTECT_RECURSION.

4 years agoMerge branch 'PHP-7.4' into master
Christoph M. Becker [Tue, 15 Sep 2020 08:59:24 +0000 (10:59 +0200)]
Merge branch 'PHP-7.4' into master

* PHP-7.4:
  7.3.24 is next

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Tue, 15 Sep 2020 08:57:39 +0000 (10:57 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  7.3.24 is next

4 years ago7.3.24 is next
Christoph M. Becker [Tue, 15 Sep 2020 08:51:41 +0000 (10:51 +0200)]
7.3.24 is next

4 years agoFix observer leak
Nikita Popov [Tue, 15 Sep 2020 08:40:46 +0000 (10:40 +0200)]
Fix observer leak

Make sure to startup observer infrastructure before we register
the first observer...

4 years agoMerge branch 'PHP-7.4' into master
Derick Rethans [Tue, 15 Sep 2020 08:37:16 +0000 (09:37 +0100)]
Merge branch 'PHP-7.4' into master

4 years agoThe next release here will be 7.4.12
Derick Rethans [Tue, 15 Sep 2020 08:36:57 +0000 (09:36 +0100)]
The next release here will be 7.4.12

4 years agomicro-optimization
Dmitry Stogov [Tue, 15 Sep 2020 06:39:41 +0000 (09:39 +0300)]
micro-optimization

4 years agoRenumber ZEND_ACC_... constants
Dmitry Stogov [Tue, 15 Sep 2020 06:39:27 +0000 (09:39 +0300)]
Renumber ZEND_ACC_... constants

4 years agoPromote some warnings to ValueError in OCI8
George Peter Banyard [Sat, 12 Sep 2020 15:38:02 +0000 (17:38 +0200)]
Promote some warnings to ValueError in OCI8

Closes GH-6116

Co-authored-by: Christopher Jones <sixd@php.net>
4 years agoFix use-after-free with yield from in yield_from_multi_tree_single_nodes.phpt
Bob Weinand [Mon, 14 Sep 2020 21:05:28 +0000 (23:05 +0200)]
Fix use-after-free with yield from in yield_from_multi_tree_single_nodes.phpt

Prevent release of generator children during destruction

4 years agoMerge branch 'PHP-7.4' into master
Christoph M. Becker [Mon, 14 Sep 2020 20:36:00 +0000 (22:36 +0200)]
Merge branch 'PHP-7.4' into master

* PHP-7.4:
  Avoid segfault if module/extension version is not defined

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Mon, 14 Sep 2020 20:34:58 +0000 (22:34 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Avoid segfault if module/extension version is not defined

4 years agoAvoid segfault if module/extension version is not defined
Christoph M. Becker [Mon, 14 Sep 2020 20:31:15 +0000 (22:31 +0200)]
Avoid segfault if module/extension version is not defined

4 years agoSupport for reference
Dmitry Stogov [Mon, 14 Sep 2020 20:30:49 +0000 (23:30 +0300)]
Support for reference

4 years agoSimplify zend_jit_pre/post_inc/dec_typed_ref() helpers
Dmitry Stogov [Mon, 14 Sep 2020 19:26:34 +0000 (22:26 +0300)]
Simplify zend_jit_pre/post_inc/dec_typed_ref() helpers

4 years agoFix crashes with unproper cleaning of repeated yield from
Bob Weinand [Sun, 13 Sep 2020 22:04:45 +0000 (00:04 +0200)]
Fix crashes with unproper cleaning of repeated yield from

Closes GH-6130

4 years agoRename zend_error_notify APIs to zend_observer_error*
Benjamin Eberlei [Mon, 14 Sep 2020 12:05:54 +0000 (14:05 +0200)]
Rename zend_error_notify APIs to zend_observer_error*

4 years agoJIT for PRE/POST_INC/DEC_OBJ
Dmitry Stogov [Mon, 14 Sep 2020 16:36:15 +0000 (19:36 +0300)]
JIT for PRE/POST_INC/DEC_OBJ

4 years agoPromote warnings to Errors in PostgreSQL extension
George Peter Banyard [Sun, 13 Sep 2020 03:31:01 +0000 (05:31 +0200)]
Promote warnings to Errors in PostgreSQL extension

Do some drive by indentation fixes
Also fix pg_select() in regards to the $result_type arg which was missing from ZPP

Closes GH-6129

4 years agoUpdate array parameter names for named parameters
Larry Garfield [Wed, 26 Aug 2020 22:20:22 +0000 (17:20 -0500)]
Update array parameter names for named parameters

* The array "subject" of a function gets called $array.

* Further parameters should be self-descriptive if used
  as a named parameter, and a full word, not an abbreviation.

* If there is a "bunch more arrays" variadic, it gets
  called $arrays (because that's what was already there).

* A few functions have a variadic "a bunch more arrays,
  and then a callable", and were already called $rest.
  I left those as is and died a little inside.

* Any callable provided to an array function that acts
  on the array is called $callback. (Nearly all were already,
  I just fixed the one or two outliers.)

* array_multisort() is beyond help so I ran screaming.

4 years agoFixed bug #80096
Nikita Popov [Mon, 14 Sep 2020 13:49:49 +0000 (15:49 +0200)]
Fixed bug #80096

We shouldn't assume that call->prev_execute_data is NULL here. The
value needs to be preserved for call chains.

4 years agoPromote Warnings to Error in PostgreSQL PDO driver
George Peter Banyard [Sat, 12 Sep 2020 21:24:30 +0000 (23:24 +0200)]
Promote Warnings to Error in PostgreSQL PDO driver

Closes GH-6119

4 years agoConvert Division by 0 warnings to Error per the Engine Warning RFC
George Peter Banyard [Sat, 12 Sep 2020 22:43:00 +0000 (00:43 +0200)]
Convert Division by 0 warnings to Error per the Engine Warning RFC

Closes GH-6125

4 years agoJIT for ASSIGN_OBJ_OP
Dmitry Stogov [Mon, 14 Sep 2020 10:31:41 +0000 (13:31 +0300)]
JIT for ASSIGN_OBJ_OP

4 years agoConvert E_ERROR to Error exception in mysqli_result iterator
Nikita Popov [Mon, 14 Sep 2020 10:15:24 +0000 (12:15 +0200)]
Convert E_ERROR to Error exception in mysqli_result iterator

The same condition uses Error exceptions in lots of other classes.

4 years agoDrop some dead code
Nikita Popov [Mon, 14 Sep 2020 10:02:56 +0000 (12:02 +0200)]
Drop some dead code

4 years agoSlightly improve error handling in DatePeriod::__construct()
Máté Kocsis [Mon, 14 Sep 2020 09:59:51 +0000 (11:59 +0200)]
Slightly improve error handling in DatePeriod::__construct()

4 years agoDeclare array|int and object-of-class|int types in stubs
Máté Kocsis [Mon, 14 Sep 2020 09:59:32 +0000 (11:59 +0200)]
Declare array|int and object-of-class|int types in stubs

Closes GH-6081

Co-Authored-By: Nikita Popov <nikic@php.net>
4 years agoMake mb_send_mail() consistent with mail()
Máté Kocsis [Mon, 14 Sep 2020 09:52:33 +0000 (11:52 +0200)]
Make mb_send_mail() consistent with mail()

The $additional_headers parameter shouldn't accept null.

4 years agoFix a few stub parameter types in ext/standard
Máté Kocsis [Mon, 14 Sep 2020 09:46:14 +0000 (11:46 +0200)]
Fix a few stub parameter types in ext/standard

4 years agoAdd Z_PARAM_OBJ_OF_CLASS ZPP macro
Máté Kocsis [Mon, 14 Sep 2020 09:40:27 +0000 (11:40 +0200)]
Add Z_PARAM_OBJ_OF_CLASS ZPP macro

4 years agoUnmark tests as XFAIL on Windows
Christoph M. Becker [Mon, 14 Sep 2020 08:13:07 +0000 (10:13 +0200)]
Unmark tests as XFAIL on Windows

This issue has been resolved[1], so the tests are expected to pass on
Windows again.

[1] <https://github.com/php/php-src/commit/0a03291b51e7cf199c06ba4ae914277ce0ac4202>

4 years agoAllocate Windows 64 shadow stack space
Dmitry Stogov [Mon, 14 Sep 2020 07:41:22 +0000 (10:41 +0300)]
Allocate Windows 64 shadow stack space

4 years agoRemove @jit Docblock support for now due to dev-time constraints
Benjamin Eberlei [Sat, 12 Sep 2020 15:25:16 +0000 (17:25 +0200)]
Remove @jit Docblock support for now due to dev-time constraints

4 years agoConvert warnings to assetions in OCI PDO driver
George Peter Banyard [Sat, 12 Sep 2020 21:41:25 +0000 (23:41 +0200)]
Convert warnings to assetions in OCI PDO driver

Closes GH-6118

4 years agoMark tests as XFAIL on Windows
Christoph M. Becker [Sun, 13 Sep 2020 13:37:46 +0000 (15:37 +0200)]
Mark tests as XFAIL on Windows

These tests segfault with tracing JIT on Windows as of a recent
commit[1].  A link to a backtrace is available in a comment[2].  For
now, we mark these tests as XFAIL, to keep AppVeyor CI helpful.

[1] <https://github.com/php/php-src/commit/7b0a05316957982f9e4cc021aec5c20cc80f7542>
[2] <https://github.com/php/php-src/commit/7b0a05316957982f9e4cc021aec5c20cc80f7542#commitcomment-42267637>

4 years agoMark tests as XFAIL on Windows
Christoph M. Becker [Sun, 13 Sep 2020 13:35:22 +0000 (15:35 +0200)]
Mark tests as XFAIL on Windows

These tests segfault with tracing JIT on Windows as of a recent
commit[1].  A link to a backtrace is available in a comment[2].  For
now, we mark these tests as XFAIL, to keep AppVeyor CI helpful.

[1] <https://github.com/php/php-src/commit/817ae414962480d133ed76618b88b3e7ba482718>
[2] <https://github.com/php/php-src/commit/817ae414962480d133ed76618b88b3e7ba482718#commitcomment-42227420>

4 years agoFix broken test
Matteo Beccati [Sun, 13 Sep 2020 08:02:13 +0000 (10:02 +0200)]
Fix broken test

Since e8e4ddce

4 years agoUse Error for uninitialized SQLite object
George Peter Banyard [Fri, 11 Sep 2020 16:10:38 +0000 (18:10 +0200)]
Use Error for uninitialized SQLite object

Closes GH-6113

4 years agoFix SKIPIF section for SQLite3 test
George Peter Banyard [Fri, 11 Sep 2020 16:12:59 +0000 (18:12 +0200)]
Fix SKIPIF section for SQLite3 test

Test is borked if the posix_geteui() function is unavailable.

4 years agoImprove parameter handling in ext/openssl
Máté Kocsis [Thu, 20 Aug 2020 14:03:34 +0000 (16:03 +0200)]
Improve parameter handling in ext/openssl

Closes GH-6025

4 years agoFix prototype of get_active_function_or_method_name()
Máté Kocsis [Sat, 12 Sep 2020 17:09:02 +0000 (19:09 +0200)]
Fix prototype of get_active_function_or_method_name()

4 years agoNormalize behaviour of DNS function on Windows
George Peter Banyard [Sat, 12 Sep 2020 16:41:25 +0000 (18:41 +0200)]
Normalize behaviour of DNS function on Windows

This is a follow-up on commit 4a438b44694d4caf86d8e57266ed2fc2f4ae6213

Add some tests to hopefully not forget it next time

4 years agoHandle missing result_var in binary_op_result_type
Nikita Popov [Fri, 11 Sep 2020 20:36:41 +0000 (22:36 +0200)]
Handle missing result_var in binary_op_result_type

For dim/obj compound ops we don't have a result_var. Not sure why
this never caused issues before, but this can crash with JIT.

4 years agoFix mbstring fuzzer
Nikita Popov [Fri, 11 Sep 2020 16:34:15 +0000 (18:34 +0200)]
Fix mbstring fuzzer

mb_ereg can throw now, so we need a dummy frame and need to
free the exception afterwards.

4 years agoPromote some warnings in BCMath to Errors
George Peter Banyard [Fri, 11 Sep 2020 15:40:06 +0000 (17:40 +0200)]
Promote some warnings in BCMath to Errors

Also do a bit of refactoring at the same time.

Closes GH-6105

4 years agoUse string|int union types in pgsql
Nikita Popov [Fri, 11 Sep 2020 15:28:20 +0000 (17:28 +0200)]
Use string|int union types in pgsql

For "field name or field offset" parameters.

Also make $ctor_params an ?array parameter.

4 years agoMake argument type error message consistent for variadics
Nikita Popov [Wed, 9 Sep 2020 09:42:32 +0000 (11:42 +0200)]
Make argument type error message consistent for variadics

If an argument error refers to a variadic argument, we normally
do not print the name of the variadic (as it is not referring to
an individual argument, but to the collection of all of them).
However, this was not the case for the userland argument type
error message, which did it's own formatting.

Closes GH-6101.

4 years agoAlso forbid null bytes in mail()
Nikita Popov [Fri, 11 Sep 2020 13:27:54 +0000 (15:27 +0200)]
Also forbid null bytes in mail()

I've adjusted mb_send_mail() already, but of course the handling
in mail() should be the same.

4 years agoMerge branch 'PHP-7.4' into master
Christoph M. Becker [Fri, 11 Sep 2020 12:49:07 +0000 (14:49 +0200)]
Merge branch 'PHP-7.4' into master

* PHP-7.4:
  Fix #80067: Omitting the port in bindto setting errors

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Fri, 11 Sep 2020 12:46:28 +0000 (14:46 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix #80067: Omitting the port in bindto setting errors

4 years agoFix #80067: Omitting the port in bindto setting errors
Christoph M. Becker [Wed, 9 Sep 2020 12:28:55 +0000 (14:28 +0200)]
Fix #80067: Omitting the port in bindto setting errors

A recent commit[1] which fixed a memory leak introduced a regression
regarding the formerly liberal handling of IP addresses to bind to.  We
fix this by reverting that commit, and fix the memory leak where it
actually occurs.  In other words, this fix is less intrusive than the
former fix.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=0b8c83f5936581942715d14883cdebddc18bad30>

Closes GH-6104.

4 years agoClean up ext/session errors
Máté Kocsis [Thu, 10 Sep 2020 17:50:41 +0000 (19:50 +0200)]
Clean up ext/session errors

Closes GH-6111

4 years agoConsolidate new union type ZPP macro names
Máté Kocsis [Thu, 10 Sep 2020 22:23:54 +0000 (00:23 +0200)]
Consolidate new union type ZPP macro names

They will now follow the canonical order of types. Older macros are
left intact due to maintaining BC.

Closes GH-6112

4 years agoRefactor ReflectionMethod::__construct()
Máté Kocsis [Wed, 9 Sep 2020 00:21:51 +0000 (02:21 +0200)]
Refactor ReflectionMethod::__construct()

Closes GH-6098

4 years agoThrow ValueError on null bytes in mb_send_mail()
Nikita Popov [Fri, 11 Sep 2020 08:46:59 +0000 (10:46 +0200)]
Throw ValueError on null bytes in mb_send_mail()

Instead of silently replacing with spaces.

4 years agoRemove the duplicate line in zend_ast.c
Hailong Zhao [Wed, 9 Sep 2020 22:34:14 +0000 (18:34 -0400)]
Remove the duplicate line in zend_ast.c

Closes GH-6107.

4 years agoAdd missing condition on azure community job
Nikita Popov [Fri, 11 Sep 2020 07:05:37 +0000 (09:05 +0200)]
Add missing condition on azure community job

4 years agoEliminate repeatable class guards and unnecessary IS_UNDEF property checks
Dmitry Stogov [Fri, 11 Sep 2020 07:30:43 +0000 (10:30 +0300)]
Eliminate repeatable class guards and unnecessary IS_UNDEF property checks

4 years agoFix leak in snmp
Nikita Popov [Thu, 10 Sep 2020 21:19:25 +0000 (23:19 +0200)]
Fix leak in snmp

4 years agoJIT for ASSIGN_OBJ
Dmitry Stogov [Thu, 10 Sep 2020 20:41:50 +0000 (23:41 +0300)]
JIT for ASSIGN_OBJ

4 years agoFixed 32-bit JIT
Dmitry Stogov [Thu, 10 Sep 2020 13:55:08 +0000 (16:55 +0300)]
Fixed 32-bit JIT

4 years agoAvoid gap in AST_CLASS child nodes for attributes
Tyson Andre [Sun, 6 Sep 2020 20:47:34 +0000 (16:47 -0400)]
Avoid gap in AST_CLASS child nodes for attributes

See https://github.com/nikic/php-ast/pull/181

> Hm, I'm thinking it would make more sense to change the structure in php-src.
> All the function types have consistent AST structure, but there's no reason at
> all why classes should be consistent with functions.

It's unusual to have an unused child node between other child nodes that are
used (for name, extends, implements, and attributes of AST_CLASS)

> That gap is a leftover from a previous refactoring. An earlier version of
> attributes extended `zend_ast_decl` with a new member called `attributes` and
> therefore did not need to handle functions and classes in different ways.

Closes GH-6088

4 years agofix zend_hash_get_current_key_type_ex proto
Remi Collet [Thu, 10 Sep 2020 10:40:47 +0000 (12:40 +0200)]
fix zend_hash_get_current_key_type_ex proto

4 years agofix zend_hash_get_current_key_ex proto
Remi Collet [Thu, 10 Sep 2020 09:19:09 +0000 (11:19 +0200)]
fix zend_hash_get_current_key_ex proto

4 years agoSimplify error type filter
twosee [Thu, 10 Sep 2020 09:36:04 +0000 (17:36 +0800)]
Simplify error type filter

Closes GH-6049.

4 years agoMerge branch 'PHP-7.4'
Nikita Popov [Thu, 10 Sep 2020 07:58:04 +0000 (09:58 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix azure i386 build, again