]> granicus.if.org Git - taglib/log
taglib
20 years agoTwo issues pointed out by Gary Peck:
Scott Wheeler [Sun, 6 Jun 2004 00:10:58 +0000 (00:10 +0000)]
Two issues pointed out by Gary Peck:
*) Note that adding and removing frames from the ID3v2::Tag will invalidate
   iterators on the frame list
*) Correct the number of genres -- it should be 148 instead of 147.  You
   can all have your Synthpop genre back now.  :-)

CCMAIL:Gary Peck <gbpeck@sbcglobal.net>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@318067 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

20 years agoDon't die on invalid input.
Scott Wheeler [Sat, 29 May 2004 20:12:36 +0000 (20:12 +0000)]
Don't die on invalid input.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@315934 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoOops. Pretty significant type in the frame name for recording date. This
Scott Wheeler [Mon, 24 May 2004 07:37:41 +0000 (07:37 +0000)]
Oops.  Pretty significant type in the frame name for recording date.  This
will automatically fix these files on the next write.  (At the moment other
taggers will not be able to read the date written by TagLib in the ID3v2 tag.
In most cases they'll fall back to the ID3v1 tag, which is fine, but still
kind of nasty.)  Thanks to Teemu Tervo for catching this.

CCMAIL:82038-done@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@314024 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd a short description
Scott Wheeler [Thu, 13 May 2004 00:09:41 +0000 (00:09 +0000)]
Add a short description

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@310851 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agodocumentation fixes
Scott Wheeler [Thu, 13 May 2004 00:08:00 +0000 (00:08 +0000)]
documentation fixes

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@310850 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd a frameList() overload that accepts a frame ID as a shortcut to the
Scott Wheeler [Thu, 13 May 2004 00:07:30 +0000 (00:07 +0000)]
Add a frameList() overload that accepts a frame ID as a shortcut to the
frameListMap().

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@310849 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdded an example on how to read additional frames.
Scott Wheeler [Mon, 10 May 2004 01:07:58 +0000 (01:07 +0000)]
Added an example on how to read additional frames.

CCMAIL:Volker Wegert <mail@volker-wegert.de>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309882 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agodoxygen fix
Scott Wheeler [Sun, 9 May 2004 20:44:52 +0000 (20:44 +0000)]
doxygen fix

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309855 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoCVS_SILENT docs fix
Scott Wheeler [Sun, 9 May 2004 17:54:40 +0000 (17:54 +0000)]
CVS_SILENT docs fix

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309805 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoJust a little hack to make the Vorbis classes appear in the Ogg namespace
Scott Wheeler [Thu, 6 May 2004 16:59:13 +0000 (16:59 +0000)]
Just a little hack to make the Vorbis classes appear in the Ogg namespace
in the API docs and a tyepdef to make this work (since this is how things
will be in the next BIC version).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309150 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoA small regression -- when assigning a ByteVector to a String make sure to
Scott Wheeler [Thu, 6 May 2004 12:36:31 +0000 (12:36 +0000)]
A small regression -- when assigning a ByteVector to a String make sure to
not include the trailing null characters.  (This was introduced after the
last release.)

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309070 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoDon't append a framing bit when writing Xiph comments to FLAC files since this
Scott Wheeler [Tue, 4 May 2004 01:47:01 +0000 (01:47 +0000)]
Don't append a framing bit when writing Xiph comments to FLAC files since this
renders them unplayable with some players.  Thanks to Jason Lee for tracking
this down!

CCMAIL:75880-done@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@308437 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd docs.
Scott Wheeler [Wed, 28 Apr 2004 00:58:46 +0000 (00:58 +0000)]
Add docs.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306915 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoOops, the implementation of this constructor was missing.
Scott Wheeler [Wed, 28 Apr 2004 00:23:52 +0000 (00:23 +0000)]
Oops, the implementation of this constructor was missing.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306914 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd native support for the RVA2 (relative volume adjustment) frame. The
Scott Wheeler [Tue, 27 Apr 2004 02:01:27 +0000 (02:01 +0000)]
Add native support for the RVA2 (relative volume adjustment) frame.  The
docs aren't there yet and this is completely untested, but that will follow
as soon as I find a file actually tagged with one of these.  :-)

CCMAIL:Jorn Baayen <jbaayen@gnome.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306706 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd new type and templatize the "fromNumber" conversion.
Scott Wheeler [Tue, 27 Apr 2004 01:29:22 +0000 (01:29 +0000)]
Add new type and templatize the "fromNumber" conversion.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoOops. Make the docs accurate.
Scott Wheeler [Tue, 27 Apr 2004 01:21:30 +0000 (01:21 +0000)]
Oops.  Make the docs accurate.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306703 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoMake this check current with the bytevector code.
Scott Wheeler [Tue, 27 Apr 2004 01:09:48 +0000 (01:09 +0000)]
Make this check current with the bytevector code.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306700 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoChanged my mind on the last one -- use explicit types rather than trying
Scott Wheeler [Tue, 27 Apr 2004 01:09:31 +0000 (01:09 +0000)]
Changed my mind on the last one -- use explicit types rather than trying
to figure things out.  This also allows the number conversion to be
templatized.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306699 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd a check for the toInt() stuff.
Scott Wheeler [Mon, 26 Apr 2004 23:05:36 +0000 (23:05 +0000)]
Add a check for the toInt() stuff.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306691 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd a toInt() method that correctly adjusts for the signedness bit even on
Scott Wheeler [Mon, 26 Apr 2004 23:00:21 +0000 (23:00 +0000)]
Add a toInt() method that correctly adjusts for the signedness bit even on
different variable sized byte vectors.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306690 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd direct support APIC (attached picture) frames. I'll probably add an
Scott Wheeler [Mon, 26 Apr 2004 08:49:02 +0000 (08:49 +0000)]
Add direct support APIC (attached picture) frames.  I'll probably add an
example to the examples dir later today showing how to use this.

CCMAIL:Matthias Welwarsky <matze@stud.fbi.fh-darmstadt.de>
CCMAIL:Jorn Baayen <jbaayen@gnome.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306452 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoMinor fix for getting the frame header size correct for unknown frames in
Scott Wheeler [Mon, 26 Apr 2004 01:18:37 +0000 (01:18 +0000)]
Minor fix for getting the frame header size correct for unknown frames in
ID3v2.2 tags.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306417 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoCVS_SILENT make some stuff as deprecated
Scott Wheeler [Sat, 10 Apr 2004 23:28:54 +0000 (23:28 +0000)]
CVS_SILENT make some stuff as deprecated

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@302723 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoSadly reserve() just changes the capacity, not the actual size of the vector
Scott Wheeler [Sat, 10 Apr 2004 18:39:17 +0000 (18:39 +0000)]
Sadly reserve() just changes the capacity, not the actual size of the vector
so this didn't update the internal size of the std::vector...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@302668 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdding accessors for the various tag type for FLAC tags (similar to those
Scott Wheeler [Sat, 10 Apr 2004 17:55:23 +0000 (17:55 +0000)]
Adding accessors for the various tag type for FLAC tags (similar to those
in MPEG::File).

CCMAIL:Jorn Baayen <jbaayen@gnome.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@302658 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoCVS_SILENT API docs corrections
Scott Wheeler [Sat, 10 Apr 2004 17:23:22 +0000 (17:23 +0000)]
CVS_SILENT API docs corrections

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@302647 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoCVS_SILENT nitpicks
Scott Wheeler [Sat, 10 Apr 2004 17:03:41 +0000 (17:03 +0000)]
CVS_SILENT nitpicks

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@302642 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoFix the same bug that I fixed in MPEG last week -- allow the lib user to
Scott Wheeler [Sat, 10 Apr 2004 15:50:17 +0000 (15:50 +0000)]
Fix the same bug that I fixed in MPEG last week -- allow the lib user to
specify the ID3v2FrameFactory in the FLAC::File construstor.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@302629 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoReturn a XiphComment here -- that still satisfies the overload of
Scott Wheeler [Sat, 10 Apr 2004 15:36:17 +0000 (15:36 +0000)]
Return a XiphComment here -- that still satisfies the overload of
TagLib::File::tag() since return types aren't mangled into the symbol
names.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@302627 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoRestore public API from last commit
Allan Sandfeld Jensen [Wed, 7 Apr 2004 14:07:53 +0000 (14:07 +0000)]
Restore public API from last commit

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301962 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoOops. Forgot to update this recently...
Scott Wheeler [Wed, 7 Apr 2004 10:53:12 +0000 (10:53 +0000)]
Oops.  Forgot to update this recently...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301927 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoCVS_SILENT nitpicks
Scott Wheeler [Wed, 7 Apr 2004 07:58:06 +0000 (07:58 +0000)]
CVS_SILENT nitpicks

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301909 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoSeveral optimizations that came from KCacheGrind / calltree fun.
Scott Wheeler [Wed, 7 Apr 2004 06:00:05 +0000 (06:00 +0000)]
Several optimizations that came from KCacheGrind / calltree fun.
Basically they fall into the categories:
- Don't convert things before you need to
- When you do, use more effecient copy constructors / assignment operators
  (i.e. when copying prefer memcpy to a for loop and when that's not possible
  use an iterator instead of operator[])

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301896 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdding Ogg/FLAC support to TagLib
Allan Sandfeld Jensen [Tue, 6 Apr 2004 20:35:29 +0000 (20:35 +0000)]
Adding Ogg/FLAC support to TagLib

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301825 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoChanging the API to something more flexible (And needed for Ogg/FLAC)
Allan Sandfeld Jensen [Tue, 6 Apr 2004 20:34:28 +0000 (20:34 +0000)]
Changing the API to something more flexible (And needed for Ogg/FLAC)

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301824 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoversion 1.1
Scott Wheeler [Sun, 4 Apr 2004 21:36:38 +0000 (21:36 +0000)]
version 1.1

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301333 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd the ability to override the default ID3v1 string handling in TagLib by
Scott Wheeler [Sun, 4 Apr 2004 14:42:13 +0000 (14:42 +0000)]
Add the ability to override the default ID3v1 string handling in TagLib by
adding a ID3v1::StringHandler class that has render and parse methods.

By default this still makes the (correct) assumption that ID3v1 tags contain
ISO-8859-1 data, but this makes it easy for applications to override this to
allow user specified codecs.

CCMAIL:78428@bugs.kde.org
CCMAIL:77710@bugs.kde.org
CCMAIL:amarok-devel@lists.sourceforge.net
CCMAIL:Shlomi Loubaton <loubaton.shlomi@012.net.il>
CCMAIL:Nir Misgav <misgav@ee.bgu.ac.il>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301244 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAfter making a simple enough test-case for Scott I was able to find the bug
Allan Sandfeld Jensen [Sat, 3 Apr 2004 16:20:11 +0000 (16:20 +0000)]
After making a simple enough test-case for Scott I was able to find the bug
myself.

Beware of the presedence of & !!

CCMAIL:wheeler@kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@301024 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd a constructor that takes an ID3v2::FrameFactory.
Scott Wheeler [Tue, 30 Mar 2004 13:50:26 +0000 (13:50 +0000)]
Add a constructor that takes an ID3v2::FrameFactory.

CCMAIL:Jonathan Giannuzzi <psyduck@altern.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@299846 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoCVS_SILENT another nitpick
Scott Wheeler [Tue, 30 Mar 2004 13:45:24 +0000 (13:45 +0000)]
CVS_SILENT another nitpick

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@299843 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoI like it more like this...
Scott Wheeler [Tue, 30 Mar 2004 13:12:18 +0000 (13:12 +0000)]
I like it more like this...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@299835 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoThe explicit is silly here since it takes two arguments (it's leftover from
Scott Wheeler [Tue, 16 Mar 2004 18:51:16 +0000 (18:51 +0000)]
The explicit is silly here since it takes two arguments (it's leftover from
when this used to have a default argument).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@296374 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years ago- ByteVector::operator> seemed flawed to me
Frerich Raabe [Wed, 10 Mar 2004 13:06:14 +0000 (13:06 +0000)]
- ByteVector::operator> seemed flawed to me

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@294934 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoUse memcmp() and memcpy() where appropriate rather than slower loop based
Scott Wheeler [Fri, 5 Mar 2004 15:59:00 +0000 (15:59 +0000)]
Use memcmp() and memcpy() where appropriate rather than slower loop based
methods.  Here this improves tag reading speed by about 50%.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@293774 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoHmm, not good -- missing "ref" here so that the reference count wasn't
Scott Wheeler [Sun, 29 Feb 2004 20:02:18 +0000 (20:02 +0000)]
Hmm, not good -- missing "ref" here so that the reference count wasn't
being incremented on copy.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@292618 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoFix String::data() for UTF16 -- there was a missing break in the case
Scott Wheeler [Sun, 22 Feb 2004 12:51:32 +0000 (12:51 +0000)]
Fix String::data() for UTF16 -- there was a missing break in the case
statement, so both the UTF16 and the UTF16BE versions were being executed.

CCMAIL:Ilya Konstantinov <future@shiny.co.il>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@290210 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoOops, forgot a break...
Scott Wheeler [Fri, 20 Feb 2004 11:42:14 +0000 (11:42 +0000)]
Oops, forgot a break...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289657 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdded a translation table between ID3v2.2 frame names and ID3v2.4. TagLib
Scott Wheeler [Fri, 20 Feb 2004 11:40:44 +0000 (11:40 +0000)]
Added a translation table between ID3v2.2 frame names and ID3v2.4.  TagLib
now supports ID3v2.2 through ID3v2.4.

CCMAIL:Keith Brady <keith@funnelboy.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289656 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoCVS_SILENT oops -- didn't mean to check this in
Scott Wheeler [Fri, 20 Feb 2004 01:42:10 +0000 (01:42 +0000)]
CVS_SILENT oops -- didn't mean to check this in

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289568 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoMostly get ID3v2.2 working. Sure, it's a standard from 1998 that was
Scott Wheeler [Fri, 20 Feb 2004 01:41:25 +0000 (01:41 +0000)]
Mostly get ID3v2.2 working.  Sure, it's a standard from 1998 that was
replaced in 1999, but apparently iTunes still uses it.

This gets the frame parsing code to support 2.2 and required deprecating
a couple of methods so that an ID3v2 version could be passed along.

There still needs to be a translation table added to handle converting
ID3v2.2 frame names to their ID3v2.4 equivalents, but that can come later.
For now the framelister program from the examples dir is able to read all
of the text frames.

CCMAIL:Keith Brady <keith@funnelboy.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@289567 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoAdd a couple of testcases that point out UTF16 bugs.
Scott Wheeler [Tue, 17 Feb 2004 02:56:10 +0000 (02:56 +0000)]
Add a couple of testcases that point out UTF16 bugs.

CCMAIL:Ilya Konstantinov <future@shiny.co.il>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288628 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoFixed problem with TagLib reading 1 byte fields in ID3v2 tags.
Scott Wheeler [Tue, 17 Feb 2004 02:11:05 +0000 (02:11 +0000)]
Fixed problem with TagLib reading 1 byte fields in ID3v2 tags.

CCMAIL:Stefan Gehn <sgehn@gmx.net>
CCMAIL:Keith Brady <keith@funnelboy.org>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288618 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

21 years agoThis commit was manufactured by cvs2svn to accommodate
Scott Wheeler [Tue, 17 Feb 2004 02:11:05 +0000 (02:11 +0000)]
This commit was manufactured by cvs2svn to accommodate
a server-side copy/move.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@288617 283d02a7-25f6-0310-bc7c-ecb5cbfe19da