Zeev Suraski [Wed, 9 Aug 2000 19:22:35 +0000 (19:22 +0000)]
The patch we promised - redesigned the compilation/execution API:
Advantages:
- Smaller memory footprint for the op arrays
- Slightly faster compilation times (due to saved erealloc() calls and faster zend_op
initialization)
- include_once() & require_once() share the same file list
- Consistency between include() and require() - this mostly means that return()
works inside require()'d files just as it does in include() files (it used to
be meaningless in require()'d files, most of the time (see below))
- Made require() consistent with itself. Before, if the argument was not a constant
string, require() took the include() behavior (with return()).
- Removed lots of duplicate code.
Bottom line - require() and include() are very similar now; require() is simply an include()
which isn't allowed to fail. Due to the erealloc() calls for large op arrays, require()
didn't end up being any faster than include() in the Zend engine.
Updated Supported CCVS Versions based on Conversation with Doug. All versions of CCVS 3.0 and greater should work without problems.
@ The CCVS module is now stable and compiling. It compiles as a CGI and into apache cleanly without warnings. (Brendan W. McAdams)
Looks like I found my problem.
I was predeclaring my functions in ccvs.h (stupid of me), so PHP was seeing the predec from internal_functions.h, the predec again, and then the actual functions and barfing. Compiles into apache now. Will test further.
Trying to resolve the build issue. This module is currently broken. PHP compiles it fine but I'm having linking issues when it gets to the apache level.
Any help would be greatly appreciated.
Looks like my editor barfed sometime today and saved the source files as
PC Format. Fixed that. Seeing some compiletime issues that I'm working on resolving.
Had some issues with apache build. PHP Was passing a -llibccvs inadvertantly. Seemed to be an issue with the autoconf file. Fixed. I'll get back to cleaning up that AutoConf later.
First commit of these files. We have had them working for about 3 weeks, very well, as a DL. The straight compile-into PHP support should work fine; I've got it compiling on my Slackware 7 i386 box with Apache 1.3.12 + mod_ssl. Documentation, module info and example code are forthcoming.
Rasmus Lerdorf [Mon, 7 Aug 2000 00:15:39 +0000 (00:15 +0000)]
Add 4th optional parameter to sybase_[p]connect to specify the charset
for the connection
@- Add 4th optional parameter to sybase_[p]connect to specify the charset
@ for the connection (alf@alpha.ulatina.ac.cr)
Rasmus Lerdorf [Sun, 6 Aug 2000 04:55:17 +0000 (04:55 +0000)]
decouple this check just in case we hit a weird system that has one
and not the other. And we specifically check for this, so we should
use the information.
foobar [Fri, 4 Aug 2000 17:18:54 +0000 (17:18 +0000)]
- This should fix bug #5964
# Could someone please check this out..it works as intented for me at least.
# But I don't have any Windoze machines available to test this there.
will now work again on 1-character urls, spaces before and after '='
and urls containing '#' scrolling info
# argh, this file's not even a week old and already needs
# a heavy cleanup rewrite, but at least it gets all my test cases right
Rasmus Lerdorf [Wed, 2 Aug 2000 22:48:45 +0000 (22:48 +0000)]
Heads up! I have moved the headers_only and response_code checks out of
SAPI and down into the individual SAPI modules. I have made the
appropriate changes in all the SAPI modules, but please verify these.
The reason for this change is that Apache sometimes will feed PHP
a request_method of GET but have r->header_only set to true. This happens
in an ErrorDocument redirect. In this same scenario we want to preserve
the status code as well instead of just overwriting it with a 200 and
losing this information. For now the other sapi modules act exactly as
before since they probably do not make this distinction, and they may
not even have a valid response code this early in the request.
@ Fix HEAD request bug on an Apache ErrorDocument redirect and preserve
@ the status code across the redirect as well. (Rasmus)