]> granicus.if.org Git - apache/log
apache
13 years agoXforms again post mod_proxy.xml update
Jim Jagielski [Tue, 13 Sep 2011 18:07:29 +0000 (18:07 +0000)]
Xforms again post mod_proxy.xml update

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1170275 13f79535-47bb-0310-9956-ffa450edef68

13 years agoList worker flags in a more useful manner and note Drain
Jim Jagielski [Tue, 13 Sep 2011 18:04:59 +0000 (18:04 +0000)]
List worker flags in a more useful manner and note Drain

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1170273 13f79535-47bb-0310-9956-ffa450edef68

13 years agoImplement draining capability for proxy workers... only accept
Jim Jagielski [Tue, 13 Sep 2011 17:26:57 +0000 (17:26 +0000)]
Implement draining capability for proxy workers... only accept
sticky on these puppies.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1170256 13f79535-47bb-0310-9956-ffa450edef68

13 years agoXforms changes... using SVN this time ;)
Jim Jagielski [Mon, 12 Sep 2011 14:24:27 +0000 (14:24 +0000)]
Xforms changes... using SVN this time ;)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1169762 13f79535-47bb-0310-9956-ffa450edef68

13 years agoUpdates one of the "advanced" recipes and rewrites description.
Rich Bowen [Mon, 12 Sep 2011 14:21:41 +0000 (14:21 +0000)]
Updates one of the "advanced" recipes and rewrites description.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1169760 13f79535-47bb-0310-9956-ffa450edef68

13 years agoAdd in MaxRangeOverlaps and MaxRangeReversals to accomodate
Jim Jagielski [Mon, 12 Sep 2011 14:15:53 +0000 (14:15 +0000)]
Add in MaxRangeOverlaps and MaxRangeReversals to accomodate
more control over acceptable Range headers:

        See: http://trac.tools.ietf.org/wg/httpbis/trac/ticket/311

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1169756 13f79535-47bb-0310-9956-ffa450edef68

13 years agoFixed MaxRanges config block.
Guenter Knauf [Mon, 12 Sep 2011 03:40:28 +0000 (03:40 +0000)]
Fixed MaxRanges config block.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1169599 13f79535-47bb-0310-9956-ffa450edef68

13 years agounixfy
William A. Rowe Jr [Mon, 12 Sep 2011 02:14:35 +0000 (02:14 +0000)]
unixfy

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1169594 13f79535-47bb-0310-9956-ffa450edef68

13 years agoRM warning text
William A. Rowe Jr [Mon, 12 Sep 2011 02:12:49 +0000 (02:12 +0000)]
RM warning text

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1169593 13f79535-47bb-0310-9956-ffa450edef68

13 years agoUpdates.
Lucien Gentis [Sun, 11 Sep 2011 18:43:59 +0000 (18:43 +0000)]
Updates.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1169496 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Update xforms
Ruediger Pluem [Sat, 10 Sep 2011 20:37:10 +0000 (20:37 +0000)]
* Update xforms

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167603 13f79535-47bb-0310-9956-ffa450edef68

13 years agoSave creation of merged until we know we will actually need and use it.
Jim Jagielski [Fri, 9 Sep 2011 17:44:37 +0000 (17:44 +0000)]
Save creation of merged until we know we will actually need and use it.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167310 13f79535-47bb-0310-9956-ffa450edef68

13 years agoreturn some range params admins may want to control (overlaps and reversals)
Jim Jagielski [Fri, 9 Sep 2011 17:44:31 +0000 (17:44 +0000)]
return some range params admins may want to control (overlaps and reversals)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167309 13f79535-47bb-0310-9956-ffa450edef68

13 years agoRemove function so we can grab over core_conf elements easily
Jim Jagielski [Fri, 9 Sep 2011 17:44:29 +0000 (17:44 +0000)]
Remove function so we can grab over core_conf elements easily

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167308 13f79535-47bb-0310-9956-ffa450edef68

13 years agoReorg so we don't need forward def...
Jim Jagielski [Fri, 9 Sep 2011 17:44:26 +0000 (17:44 +0000)]
Reorg so we don't need forward def...

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167307 13f79535-47bb-0310-9956-ffa450edef68

13 years agoUpdate docco xforms
Jim Jagielski [Fri, 9 Sep 2011 16:04:03 +0000 (16:04 +0000)]
Update docco xforms

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167266 13f79535-47bb-0310-9956-ffa450edef68

13 years agoReset
Jim Jagielski [Fri, 9 Sep 2011 16:02:21 +0000 (16:02 +0000)]
Reset

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167264 13f79535-47bb-0310-9956-ffa450edef68

13 years agoNo reason for the advanced def...
Jim Jagielski [Fri, 9 Sep 2011 16:02:18 +0000 (16:02 +0000)]
No reason for the advanced def...
Open hook for other conf factors (number of overlaps, etc)...
Return some range params...

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167263 13f79535-47bb-0310-9956-ffa450edef68

13 years agoReflect user-visible behavior change
William A. Rowe Jr [Fri, 9 Sep 2011 13:29:18 +0000 (13:29 +0000)]
Reflect user-visible behavior change

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167156 13f79535-47bb-0310-9956-ffa450edef68

13 years agoNon-releases don't have user-visible regressions; now a contributor to the fix
William A. Rowe Jr [Fri, 9 Sep 2011 13:23:50 +0000 (13:23 +0000)]
Non-releases don't have user-visible regressions; now a contributor to the fix

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167151 13f79535-47bb-0310-9956-ffa450edef68

13 years agoWhat getpid()? No backport of this edit is needed.
William A. Rowe Jr [Fri, 9 Sep 2011 13:09:25 +0000 (13:09 +0000)]
What getpid()?  No backport of this edit is needed.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1167147 13f79535-47bb-0310-9956-ffa450edef68

13 years agono termination of the loop in 1166823.
Eric Covener [Thu, 8 Sep 2011 18:26:54 +0000 (18:26 +0000)]
no termination of the loop in 1166823.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166839 13f79535-47bb-0310-9956-ffa450edef68

13 years agomod_ldap: Optional function uldap_ssl_supported(r) always returned false
Eric Covener [Thu, 8 Sep 2011 17:37:46 +0000 (17:37 +0000)]
mod_ldap: Optional function uldap_ssl_supported(r) always returned false
if called from a virtual host with mod_ldap directives in it.  Did not
affect mod_authnz_ldap's usage of mod_ldap.  [Eric Covener]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166823 13f79535-47bb-0310-9956-ffa450edef68

13 years agotypo in comment
Eric Covener [Thu, 8 Sep 2011 13:10:22 +0000 (13:10 +0000)]
typo in comment

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166672 13f79535-47bb-0310-9956-ffa450edef68

13 years agoSet Accept-Rangs: none instead of unsetting the Accept-Range header when we
Eric Covener [Thu, 8 Sep 2011 13:02:47 +0000 (13:02 +0000)]
Set Accept-Rangs: none instead of unsetting the Accept-Range header when we
have a filter that doesn't like byteranges.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166667 13f79535-47bb-0310-9956-ffa450edef68

13 years agorefactor to pull setting of Accept-Ranges header into http_protocol.c which
Eric Covener [Thu, 8 Sep 2011 12:56:08 +0000 (12:56 +0000)]
refactor to pull setting of Accept-Ranges header into http_protocol.c which
had been copied to other handlers.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166663 13f79535-47bb-0310-9956-ffa450edef68

13 years agoThe default timeout value of 10s lives in two places, the per-server config
Eric Covener [Thu, 8 Sep 2011 12:53:06 +0000 (12:53 +0000)]
The default timeout value of 10s lives in two places, the per-server config
and in this initialization. Drop the latter and check to see if a timeout
is requested in the per-server config.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166662 13f79535-47bb-0310-9956-ffa450edef68

13 years agoUse HTTP_NOT_IMPLEMENTED instead of HTTP_BAD_REQUEST.
Jean-Frederic Clere [Thu, 8 Sep 2011 12:41:30 +0000 (12:41 +0000)]
Use HTTP_NOT_IMPLEMENTED instead of HTTP_BAD_REQUEST.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166657 13f79535-47bb-0310-9956-ffa450edef68

13 years agoAJP_EBAD_METHOD is also a bad request so return HTTP_BAD_REQUEST
Jean-Frederic Clere [Thu, 8 Sep 2011 07:45:40 +0000 (07:45 +0000)]
AJP_EBAD_METHOD is also a bad request so return HTTP_BAD_REQUEST

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166551 13f79535-47bb-0310-9956-ffa450edef68

13 years agoadd AP_ prefix to recently added DEFAULT_MAX_RANGES
Eric Covener [Wed, 7 Sep 2011 19:51:01 +0000 (19:51 +0000)]
add AP_ prefix to recently added DEFAULT_MAX_RANGES

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166349 13f79535-47bb-0310-9956-ffa450edef68

13 years agotake care of some MaxRanges feedback:
Eric Covener [Wed, 7 Sep 2011 17:29:49 +0000 (17:29 +0000)]
take care of some MaxRanges feedback:
 * allow "none" to be expressed in config
 * send Accept-Ranges: none with MaxRanges none
 * stop accepting confusing/ambiguous "0", start accepting "unlimited".

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166282 13f79535-47bb-0310-9956-ffa450edef68

13 years agossl_var_lookup_ssl_cert_dn_oneline(): properly deal with empty DNs
Kaspar Brand [Wed, 7 Sep 2011 13:47:07 +0000 (13:47 +0000)]
ssl_var_lookup_ssl_cert_dn_oneline(): properly deal with empty DNs
(BIO_read might return -1 in such a case)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166181 13f79535-47bb-0310-9956-ffa450edef68

13 years agobump SECURITY issue to top of in-development 2.3.15 section.
Eric Covener [Tue, 6 Sep 2011 18:45:33 +0000 (18:45 +0000)]
bump SECURITY issue to top of in-development 2.3.15 section.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165779 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* modules/http/byterange_filter.c (ap_byterange_filter): Don't reveal
Joe Orton [Mon, 5 Sep 2011 12:59:07 +0000 (12:59 +0000)]
* modules/http/byterange_filter.c (ap_byterange_filter): Don't reveal
  the pid in the boundary delimiter (part of CVE-2003-1418).

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165268 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Silence compiler warning
Ruediger Pluem [Mon, 5 Sep 2011 08:23:01 +0000 (08:23 +0000)]
* Silence compiler warning

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165200 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Fix compiler warning by removing unused variable
Ruediger Pluem [Mon, 5 Sep 2011 08:13:47 +0000 (08:13 +0000)]
* Fix compiler warning by removing unused variable

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165198 13f79535-47bb-0310-9956-ffa450edef68

13 years agoupdate xforms
Stefan Fritsch [Mon, 5 Sep 2011 07:56:28 +0000 (07:56 +0000)]
update xforms

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165196 13f79535-47bb-0310-9956-ffa450edef68

13 years agobe explicit that REQUEST_URI is the path component only
Stefan Fritsch [Mon, 5 Sep 2011 07:44:23 +0000 (07:44 +0000)]
be explicit that REQUEST_URI is the path component only

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165192 13f79535-47bb-0310-9956-ffa450edef68

13 years agobe explicit that REQUEST_URI is the path component only
Eric Covener [Sun, 4 Sep 2011 21:22:36 +0000 (21:22 +0000)]
be explicit that REQUEST_URI is the path component only
(like r->uri)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165114 13f79535-47bb-0310-9956-ffa450edef68

13 years agoRevert r1163833:
Stefan Fritsch [Sun, 4 Sep 2011 16:04:38 +0000 (16:04 +0000)]
Revert r1163833:

    Send a 206 response for a "Range: bytes=0-" request, even if 200 would be
    more efficient.

As discussed on list: Clients that use the 206 response to detect range
support are considered broken and should be fixed to use the Accept-Ranges
header instead.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165062 13f79535-47bb-0310-9956-ffa450edef68

13 years agowe might also see GeneralizedTimes in certs nowadays
Kaspar Brand [Sun, 4 Sep 2011 16:03:38 +0000 (16:03 +0000)]
we might also see GeneralizedTimes in certs nowadays

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165060 13f79535-47bb-0310-9956-ffa450edef68

13 years agoRevamp CRL checking for client and remote servers:
Kaspar Brand [Sun, 4 Sep 2011 15:57:03 +0000 (15:57 +0000)]
Revamp CRL checking for client and remote servers:
- completely delegate CRL processing to OpenSSL
- introduce a new [Proxy]CARevocationCheck directive
- drop ssl_callback_SSLVerify_CRL from ssl_engine_kernel.c
- remove X509_STORE from modssl_ctx_t
- drop CRL store helper functions from ssl_util_ssl.c
- avoid sending "certificate_expired" SSL alerts to peers
  when the nextUpdate field of a CRL is in the past

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1165056 13f79535-47bb-0310-9956-ffa450edef68

13 years agoAdded MaxRanges to httpd.conf.
Guenter Knauf [Sat, 3 Sep 2011 13:18:09 +0000 (13:18 +0000)]
Added MaxRanges to httpd.conf.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1164861 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Buckets of known length should be always splitable. So we don't need to care
Ruediger Pluem [Sat, 3 Sep 2011 09:50:21 +0000 (09:50 +0000)]
* Buckets of known length should be always splitable. So we don't need to care
  about the APR_ENOTIMPL case.

Submitted by: jorton
Reviewed by: rpluem

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1164840 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Fix a regression in the CVE-2011-3192 byterange fix:
Ruediger Pluem [Thu, 1 Sep 2011 10:25:45 +0000 (10:25 +0000)]
* Fix a regression in the CVE-2011-3192 byterange fix:
  Range: bytes=-1

  Resulted in the first two bytes delivered, not in the last one.

PR: 51748
Submitted by: low_priority <lowprio20 gmail.com>
Reviewed by: rpluem

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1163985 13f79535-47bb-0310-9956-ffa450edef68

13 years agoRemove log message left over from debugging.
Stefan Fritsch [Thu, 1 Sep 2011 06:42:40 +0000 (06:42 +0000)]
Remove log message left over from debugging.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1163920 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Fix error message
Ruediger Pluem [Thu, 1 Sep 2011 06:30:02 +0000 (06:30 +0000)]
* Fix error message

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1163918 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Whitespace police. No functional change
Ruediger Pluem [Thu, 1 Sep 2011 06:25:57 +0000 (06:25 +0000)]
* Whitespace police. No functional change

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1163917 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Ranges like --2 or -0 are invalid
Ruediger Pluem [Thu, 1 Sep 2011 06:24:53 +0000 (06:24 +0000)]
* Ranges like --2 or -0 are invalid

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1163916 13f79535-47bb-0310-9956-ffa450edef68

13 years agoFix some RFC 2616 14.35.1 compliance issues:
Stefan Fritsch [Wed, 31 Aug 2011 22:37:32 +0000 (22:37 +0000)]
Fix some RFC 2616 14.35.1 compliance issues:
- If there is at least one syntactically invalid byte-range-spec,
  we must ignore the whole header.
- If all ranges are unsatisfiable, send 416.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1163851 13f79535-47bb-0310-9956-ffa450edef68

13 years agoSend a 206 response for a "Range: bytes=0-" request, even if 200 would be more
Stefan Fritsch [Wed, 31 Aug 2011 21:37:38 +0000 (21:37 +0000)]
Send a 206 response for a "Range: bytes=0-" request, even if 200 would be more
efficient.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1163833 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Silence compiler warning
Ruediger Pluem [Tue, 30 Aug 2011 13:14:14 +0000 (13:14 +0000)]
* Silence compiler warning

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1163197 13f79535-47bb-0310-9956-ffa450edef68

13 years agoTypo correction.
Rich Bowen [Mon, 29 Aug 2011 18:32:36 +0000 (18:32 +0000)]
Typo correction.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162935 13f79535-47bb-0310-9956-ffa450edef68

13 years agoRemove some unused code that was included in r1162131 by accident or merge
Stefan Fritsch [Mon, 29 Aug 2011 15:49:56 +0000 (15:49 +0000)]
Remove some unused code that was included in r1162131 by accident or merge
error.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162878 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* We don't need a copy of the original range as we don't change it. A pointer to...
Ruediger Pluem [Mon, 29 Aug 2011 09:04:56 +0000 (09:04 +0000)]
* We don't need a copy of the original range as we don't change it. A pointer to it is sufficient

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162687 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Bit operators should be more efficient then the modulo operator (provided the compi...
Ruediger Pluem [Mon, 29 Aug 2011 07:51:29 +0000 (07:51 +0000)]
* Bit operators should be more efficient then the modulo operator (provided the compiler does not optimize on its own)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162669 13f79535-47bb-0310-9956-ffa450edef68

13 years agoUnset Content-Length if we call ap_pass_brigade several times
Stefan Fritsch [Mon, 29 Aug 2011 07:28:56 +0000 (07:28 +0000)]
Unset Content-Length if we call ap_pass_brigade several times

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162665 13f79535-47bb-0310-9956-ffa450edef68

13 years agosimple doc for MaxRanges.
Eric Covener [Sun, 28 Aug 2011 20:43:14 +0000 (20:43 +0000)]
simple doc for MaxRanges.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162587 13f79535-47bb-0310-9956-ffa450edef68

13 years agoadd MaxRanges directive institute a default limit of 200 (post-merge where
Eric Covener [Sun, 28 Aug 2011 20:35:07 +0000 (20:35 +0000)]
add MaxRanges directive institute a default limit of 200 (post-merge where
applicable) Ranges before returning the complete resource.

(minor mmn bump for core_dir_config addition)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162584 13f79535-47bb-0310-9956-ffa450edef68

13 years agoFix iteration over string
Stefan Fritsch [Sun, 28 Aug 2011 20:02:38 +0000 (20:02 +0000)]
Fix iteration over string

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162581 13f79535-47bb-0310-9956-ffa450edef68

13 years agoEvery 32 ranges, pass the prepared ranges down the filter chain.
Stefan Fritsch [Sun, 28 Aug 2011 19:45:21 +0000 (19:45 +0000)]
Every 32 ranges, pass the prepared ranges down the filter chain.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162579 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Do a better estimation on how elements we should allocate:
Ruediger Pluem [Sun, 28 Aug 2011 17:52:44 +0000 (17:52 +0000)]
* Do a better estimation on how elements we should allocate:

  Preallocate the number of ranges as number of elements as this works good
  for well behaving clients which we assume to be the most cases, but do
  cut this at the arbitrary number of 100 to avoid too large preallocations.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162565 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Silence compiler warning
Ruediger Pluem [Sun, 28 Aug 2011 17:12:52 +0000 (17:12 +0000)]
* Silence compiler warning

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162560 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Damm it. Missed another superflous whitespace.
Ruediger Pluem [Sun, 28 Aug 2011 17:12:14 +0000 (17:12 +0000)]
* Damm it. Missed another superflous whitespace.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162559 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* More style police. No functional changes
Ruediger Pluem [Sun, 28 Aug 2011 17:09:38 +0000 (17:09 +0000)]
* More style police. No functional changes

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162558 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Style police. No functional changes
Ruediger Pluem [Sun, 28 Aug 2011 17:08:35 +0000 (17:08 +0000)]
* Style police. No functional changes

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162556 13f79535-47bb-0310-9956-ffa450edef68

13 years agoBetter safe than sorry: with OpenSSL 1.0, X509_STORE_CTX_get_current_cert()
Kaspar Brand [Sun, 28 Aug 2011 16:50:12 +0000 (16:50 +0000)]
Better safe than sorry: with OpenSSL 1.0, X509_STORE_CTX_get_current_cert()
may not always return a cert.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162553 13f79535-47bb-0310-9956-ffa450edef68

13 years agoFix the default OCSP responder timeout for client cert
Kaspar Brand [Sun, 28 Aug 2011 16:34:50 +0000 (16:34 +0000)]
Fix the default OCSP responder timeout for client cert
validation - 10 µsec is a tad too aggressive.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162552 13f79535-47bb-0310-9956-ffa450edef68

13 years agomerge some more adjacent ranges such as a-n,n+1-b, and
Eric Covener [Sat, 27 Aug 2011 20:37:58 +0000 (20:37 +0000)]
merge some more adjacent ranges such as a-n,n+1-b, and
refactor/reduce the tests on the start/end positions.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162440 13f79535-47bb-0310-9956-ffa450edef68

13 years agoreverting. got feedback that maybe we don't want to merge 4-5,1-2 into 1-5
Greg Ames [Sat, 27 Aug 2011 20:11:16 +0000 (20:11 +0000)]
reverting.  got feedback that maybe we don't want to merge 4-5,1-2 into 1-5

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162436 13f79535-47bb-0310-9956-ffa450edef68

13 years agomerge totally reversed ranges like 4-5,1-2 into 1-5
Greg Ames [Sat, 27 Aug 2011 19:57:41 +0000 (19:57 +0000)]
merge totally reversed ranges like 4-5,1-2 into 1-5

I interpret the former test
if (!(end <= ostart || start-1 >= oend)) {

as

if (not(end is bad || start is good)) { merge }

ORing the bad condition with the good doesn't produce the desired result.

it is not necessary to test "end" due to the conditions tested in the assert.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162434 13f79535-47bb-0310-9956-ffa450edef68

13 years agofix typo
Stefan Fritsch [Sat, 27 Aug 2011 18:58:43 +0000 (18:58 +0000)]
fix typo

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162419 13f79535-47bb-0310-9956-ffa450edef68

13 years agoremove obsolete macro
Stefan Fritsch [Sat, 27 Aug 2011 15:52:41 +0000 (15:52 +0000)]
remove obsolete macro

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162381 13f79535-47bb-0310-9956-ffa450edef68

13 years agoUpdates.
Lucien Gentis [Sat, 27 Aug 2011 15:16:47 +0000 (15:16 +0000)]
Updates.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162376 13f79535-47bb-0310-9956-ffa450edef68

13 years agoIf the sum of all ranges in a request is not smaller than the file, fall back
Stefan Fritsch [Sat, 27 Aug 2011 12:31:06 +0000 (12:31 +0000)]
If the sum of all ranges in a request is not smaller than the file, fall back
to 200.  This takes care of potential DoS issues from ranges like
0-100,1000-,0-100,1000-,...

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162331 13f79535-47bb-0310-9956-ffa450edef68

13 years agofix function name in log message
Stefan Fritsch [Sat, 27 Aug 2011 11:44:03 +0000 (11:44 +0000)]
fix function name in log message

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162325 13f79535-47bb-0310-9956-ffa450edef68

13 years agoRemove traces of byterange_ctx, it's not necessary anymore
Stefan Fritsch [Fri, 26 Aug 2011 19:05:05 +0000 (19:05 +0000)]
Remove traces of byterange_ctx, it's not necessary anymore
Initialize some variables to avoid (false positive) warnings with gcc 4.6.1

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162211 13f79535-47bb-0310-9956-ffa450edef68

13 years agonot ruby
Jim Jagielski [Fri, 26 Aug 2011 17:51:42 +0000 (17:51 +0000)]
not ruby

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162186 13f79535-47bb-0310-9956-ffa450edef68

13 years agoFinal tuneage
Jim Jagielski [Fri, 26 Aug 2011 17:39:19 +0000 (17:39 +0000)]
Final tuneage

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162180 13f79535-47bb-0310-9956-ffa450edef68

13 years agoone off
Jim Jagielski [Fri, 26 Aug 2011 17:25:35 +0000 (17:25 +0000)]
one off

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162179 13f79535-47bb-0310-9956-ffa450edef68

13 years agoremove merge hit r1161778
Jim Jagielski [Fri, 26 Aug 2011 17:06:19 +0000 (17:06 +0000)]
remove merge hit r1161778

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162168 13f79535-47bb-0310-9956-ffa450edef68

13 years agoMore merge fixes...
Jim Jagielski [Fri, 26 Aug 2011 16:58:34 +0000 (16:58 +0000)]
More merge fixes...

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162165 13f79535-47bb-0310-9956-ffa450edef68

13 years agoReset with latest
Jim Jagielski [Fri, 26 Aug 2011 14:49:29 +0000 (14:49 +0000)]
Reset with latest

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162131 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Don't SEGFAULT if SSLProxyMachineCertificateChainFile is not set. Just skip the...
Ruediger Pluem [Fri, 26 Aug 2011 13:07:49 +0000 (13:07 +0000)]
* Don't SEGFAULT if SSLProxyMachineCertificateChainFile is not set. Just skip the additional lookups in this case.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1162103 13f79535-47bb-0310-9956-ffa450edef68

13 years agoPut parsed ranges into an array and perform merges on that array.
Stefan Fritsch [Thu, 25 Aug 2011 23:02:43 +0000 (23:02 +0000)]
Put parsed ranges into an array and perform merges on that array.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161791 13f79535-47bb-0310-9956-ffa450edef68

13 years agocount ranges by simply counting commas
Stefan Fritsch [Thu, 25 Aug 2011 23:00:08 +0000 (23:00 +0000)]
count ranges by simply counting commas

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161790 13f79535-47bb-0310-9956-ffa450edef68

13 years agoRemove the merging code from ap_set_byterange() again,
Stefan Fritsch [Thu, 25 Aug 2011 22:58:55 +0000 (22:58 +0000)]
Remove the merging code from ap_set_byterange() again,
will move it to ap_byterange_filter

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161789 13f79535-47bb-0310-9956-ffa450edef68

13 years agofix new breakage introduced by r1161767
Stefan Fritsch [Thu, 25 Aug 2011 22:12:43 +0000 (22:12 +0000)]
fix new breakage introduced by r1161767

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161778 13f79535-47bb-0310-9956-ffa450edef68

13 years agoavoid inserting the same bucket into bbout twice, causing an endless loop
Stefan Fritsch [Thu, 25 Aug 2011 21:43:32 +0000 (21:43 +0000)]
avoid inserting the same bucket into bbout twice, causing an endless loop

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161767 13f79535-47bb-0310-9956-ffa450edef68

13 years ago0 is OK
Jim Jagielski [Thu, 25 Aug 2011 20:24:42 +0000 (20:24 +0000)]
0 is OK

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161732 13f79535-47bb-0310-9956-ffa450edef68

13 years agono longer used
Greg Ames [Thu, 25 Aug 2011 20:17:35 +0000 (20:17 +0000)]
no longer used

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161730 13f79535-47bb-0310-9956-ffa450edef68

13 years agoSave a few cycles... do reason to set in_merge if we already have
Jim Jagielski [Thu, 25 Aug 2011 18:35:55 +0000 (18:35 +0000)]
Save a few cycles... do reason to set in_merge if we already have

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161682 13f79535-47bb-0310-9956-ffa450edef68

13 years agoOptimize... and break if we get eg 200-100
Jim Jagielski [Thu, 25 Aug 2011 18:33:26 +0000 (18:33 +0000)]
Optimize...  and break if we get eg 200-100

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161681 13f79535-47bb-0310-9956-ffa450edef68

13 years agoMerge in byteranges
Jim Jagielski [Thu, 25 Aug 2011 17:38:19 +0000 (17:38 +0000)]
Merge in byteranges

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161661 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Once the comparsion is true we never return here since we break from the loop.
Ruediger Pluem [Thu, 25 Aug 2011 14:39:12 +0000 (14:39 +0000)]
* Once the comparsion is true we never return here since we break from the loop.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161582 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* We need to use > instead of >= as if end64 is the first byte of the next
Ruediger Pluem [Thu, 25 Aug 2011 14:37:52 +0000 (14:37 +0000)]
* We need to use > instead of >= as if end64 is the first byte of the next
  bucket we need to memorize this one and not the one before.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161581 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* The first condition is not needed as pos >=0. If the first one is true
Ruediger Pluem [Thu, 25 Aug 2011 14:35:16 +0000 (14:35 +0000)]
* The first condition is not needed as pos >=0. If the first one is true
  the second one is true either. If the second one is false the first one is
  false as well.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161578 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* Adjust comment and don't get fooled by a negative end
Ruediger Pluem [Thu, 25 Aug 2011 14:31:36 +0000 (14:31 +0000)]
* Adjust comment and don't get fooled by a negative end

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161576 13f79535-47bb-0310-9956-ffa450edef68

13 years ago* As reads might have morphed the bucket and its length read until we reached
Ruediger Pluem [Thu, 25 Aug 2011 14:27:09 +0000 (14:27 +0000)]
* As reads might have morphed the bucket and its length read until we reached
  the correct bucket for splitting.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161573 13f79535-47bb-0310-9956-ffa450edef68

13 years agoRemove some merging fun between Rüdiger and my patches ;)
Jim Jagielski [Thu, 25 Aug 2011 13:32:03 +0000 (13:32 +0000)]
Remove some merging fun between Rüdiger and my patches ;)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1161563 13f79535-47bb-0310-9956-ffa450edef68