Bruce Momjian [Fri, 8 Oct 2004 00:44:07 +0000 (00:44 +0000)]
Pull comment down into its own paragraph.
Bruce Momjian [Fri, 8 Oct 2004 00:36:23 +0000 (00:36 +0000)]
Add:
* Consider parallel processing a single query
This would involve using multiple threads or processes to do optimization,
sorting, or execution of single query. The major advantage of such a
feature would be to allow multiple CPUs to work together to process a
single query.
Bruce Momjian [Thu, 7 Oct 2004 22:51:13 +0000 (22:51 +0000)]
Remove benchmark comment.
Tom Lane [Thu, 7 Oct 2004 20:36:52 +0000 (20:36 +0000)]
Change get_rule_expr so that when the input is a List, it displays the
list elements comma-separated instead of barfing. This allows elimination
of half a dozen redundant copies of that behavior, and also makes the
world safe again for pg_get_expr() applied to pg_index.indexprs, per gripe
from Alexander Zhiltsov.
Bruce Momjian [Thu, 7 Oct 2004 19:37:16 +0000 (19:37 +0000)]
Remove mention of -Q option for bench.
Bruce Momjian [Thu, 7 Oct 2004 19:01:09 +0000 (19:01 +0000)]
Move -DPLPERL_HAVE_UID_GID to the plperl Makefile, for Win32 only.
Tom Lane [Thu, 7 Oct 2004 18:57:26 +0000 (18:57 +0000)]
Add missing null terminator to escaped string; clean up unnecessarily
obscurantist coding conventions.
Bruce Momjian [Thu, 7 Oct 2004 18:57:18 +0000 (18:57 +0000)]
Add PLperl workaround for Win32 to the *.xs file.
Tom Lane [Thu, 7 Oct 2004 18:38:51 +0000 (18:38 +0000)]
Fix problems with SQL functions returning rowtypes that have dropped
columns. The returned tuple needs to have appropriate NULL columns
inserted so that it actually matches the declared rowtype. It seemed
convenient to use a JunkFilter for this, so I made some cleanups and
simplifications in the JunkFilter code to allow it to support this
additional functionality. (That in turn exposed a latent bug in
nodeAppend.c, which is that it was returning a tuple slot whose
descriptor didn't match its data.) Also, move check_sql_fn_retval
out of pg_proc.c and into functions.c, where it seems to more naturally
belong.
Bruce Momjian [Thu, 7 Oct 2004 17:29:12 +0000 (17:29 +0000)]
Add one more byte to malloc for null storage.
Bruce Momjian [Thu, 7 Oct 2004 17:04:54 +0000 (17:04 +0000)]
Remove unneeded dash.
Bruce Momjian [Thu, 7 Oct 2004 17:03:50 +0000 (17:03 +0000)]
Update comment to fix nibble mention:
* We are not sure how much precision is in tv_usec, so we
* swap the high and low 16 bits of 'later' and XOR them with
* 'earlier'. On the off chance that the result is 0, we
* loop until it isn't.
Greg Stark
Bruce Momjian [Thu, 7 Oct 2004 16:53:25 +0000 (16:53 +0000)]
Escape single quotes and backslashes used in locales placed in
postgresql.conf.
Zhong Xubin
Bruce Momjian [Thu, 7 Oct 2004 16:23:28 +0000 (16:23 +0000)]
Prevent install error message when doing cmp on empty tree.
Bruce Momjian [Thu, 7 Oct 2004 15:21:58 +0000 (15:21 +0000)]
Adjust comments previously moved to column 1 by pgident.
Bruce Momjian [Thu, 7 Oct 2004 14:19:58 +0000 (14:19 +0000)]
Back out unindented modification to file.
Bruce Momjian [Thu, 7 Oct 2004 14:15:50 +0000 (14:15 +0000)]
Indent comment pushed to new line by else so it is indented by BSD
indent.
Bruce Momjian [Thu, 7 Oct 2004 13:59:45 +0000 (13:59 +0000)]
Add as binary mode
Bruce Momjian [Thu, 7 Oct 2004 13:59:20 +0000 (13:59 +0000)]
re-add as binary
Bruce Momjian [Thu, 7 Oct 2004 13:45:51 +0000 (13:45 +0000)]
Improve pgindent processing of comment after 'else'.
Improve comment of pg_dump Win32 link workaround.
Bruce Momjian [Thu, 7 Oct 2004 02:32:06 +0000 (02:32 +0000)]
Improve comment after 'else' handling of pgindent.
Neil Conway [Thu, 7 Oct 2004 00:08:04 +0000 (00:08 +0000)]
Allow the spinlock test to be compiled successfully in a vpath build.
Tom Lane [Thu, 7 Oct 2004 00:03:15 +0000 (00:03 +0000)]
XOR process PID into a backend's initial random seed, to ensure that
different backends get a reasonably wide set of initial seeds even if
gettimeofday returns tv_usec values with only a few bits of precision.
Per recent discussion.
Neil Conway [Wed, 6 Oct 2004 23:41:59 +0000 (23:41 +0000)]
Document what the "rep; nop" x86 assembler sequence is actually equivalent
to, and what it is intended to do.
Neil Conway [Wed, 6 Oct 2004 23:31:45 +0000 (23:31 +0000)]
Capitalize some SQL keywords the previous commit missed, for consistency.
Bruce Momjian [Wed, 6 Oct 2004 19:04:10 +0000 (19:04 +0000)]
Say "history is not supported" and remove "on this platform" for lack of
readline.
Bruce Momjian [Wed, 6 Oct 2004 18:39:16 +0000 (18:39 +0000)]
Suppress psql \s help display for platforms like Win32 that don't
typically install witn readline, and throw an error if they try to
access it.
Bruce Momjian [Wed, 6 Oct 2004 18:15:24 +0000 (18:15 +0000)]
Add mention of win32ver.rc for update for minor release.
Bruce Momjian [Wed, 6 Oct 2004 17:47:53 +0000 (17:47 +0000)]
Fix improper defines for uid_t and gid_t. Had them backwards.
Bruce Momjian [Wed, 6 Oct 2004 17:43:07 +0000 (17:43 +0000)]
Uppercase SQL keywords in query for clarity.
Bruce Momjian [Wed, 6 Oct 2004 17:21:45 +0000 (17:21 +0000)]
This simple patch fixes a typo, ensure pg_config is removed in win32
and correct some splitted message mistake.
Euler Taveira de Oliveira
Bruce Momjian [Wed, 6 Oct 2004 17:02:02 +0000 (17:02 +0000)]
Fix pg_dumpall to use double-quote for Win32 arguments.
Luiz K. Matsumura
Bruce Momjian [Wed, 6 Oct 2004 16:42:01 +0000 (16:42 +0000)]
The Win32 (mingw) build of libpq seems to have lost it's SSL libs from
the link step resulting in a build failure. The attached patch fixes
that.
Dave Page
Bruce Momjian [Wed, 6 Oct 2004 16:36:02 +0000 (16:36 +0000)]
Use #define instead of typedef for plperl because perl defines
uid_t/gid_t too.
Bruce Momjian [Wed, 6 Oct 2004 15:23:27 +0000 (15:23 +0000)]
Update win32ver.rc to 8,0,000,000. Mention it needs updating in
RELEASE_CHANGES.
Bruce Momjian [Wed, 6 Oct 2004 15:14:13 +0000 (15:14 +0000)]
Improve consistency of win32 version sed script.
Bruce Momjian [Wed, 6 Oct 2004 15:12:32 +0000 (15:12 +0000)]
Fix for Win32 file version sed macro, per report from Dave Page.
Bruce Momjian [Wed, 6 Oct 2004 09:35:23 +0000 (09:35 +0000)]
Here is a patch to fix win32 ssl builds. Summary of changes:
* Links with -leay32 and -lssleay32 instead of crypto and ssl. On win32,
"crypto and ssl" is only used for static linking.
* Initializes SSL in the backend and not just in the postmaster. We
cannot pass the SSL context from the postmaster through the parameter
file, because it contains function pointers.
* Split one error check in be-secure.c. Previously we could not tell
which of three calls actually failed. The previous code also returned
incorrect error messages if SSL_accept() failed - that function needs to
use SSL_get_error() on the return value, can't just use the error queue.
* Since the win32 implementation uses non-blocking sockets "behind the
scenes" in order to deliver signals correctly, implements a version of
SSL_accept() that can handle this. Also, add a wait function in case
SSL_read or SSL_write() needs more data.
Magnus Hagander
Bruce Momjian [Wed, 6 Oct 2004 09:20:41 +0000 (09:20 +0000)]
Allow plpython to build on Win32.
Magnus Hagander
Bruce Momjian [Wed, 6 Oct 2004 09:13:10 +0000 (09:13 +0000)]
Adjustment to test on unix domain socket variable for pg_hba.conf
default settings, rather than just Win32.
Bruce Momjian [Wed, 6 Oct 2004 09:01:18 +0000 (09:01 +0000)]
Remove pg_hba.conf 'local' line for Win32 because it doesn't support unix domain
connections.
Andrew Dunstan
Bruce Momjian [Wed, 6 Oct 2004 08:50:02 +0000 (08:50 +0000)]
please find attached an alternate submission which addresses open item
"make pgxs install by default". It is up to the committers to chose.
(1) there is only one "install" target. no more "install-all-headers".
it simplifies/changes several makefiles.
(2) the documentation reflects the change.
(3) a minor fix on pgxs to use a nicer patch without a double slash.
Fabien Coelho
Neil Conway [Wed, 6 Oct 2004 08:20:58 +0000 (08:20 +0000)]
Slightly rearrange psql startup code so that we read psqlrc before printing
the startup banner. This allows "\set QUIET on" in psqlrc to do what the
user probably intended. Patch from Sean Chittenden, editorializing from
Neil Conway.
Bruce Momjian [Tue, 5 Oct 2004 19:30:25 +0000 (19:30 +0000)]
Add Win32 version info to client binaries.
Magnus Hagander
Bruce Momjian [Tue, 5 Oct 2004 17:26:39 +0000 (17:26 +0000)]
Add distclean target to pgevent.
Bruce Momjian [Tue, 5 Oct 2004 15:09:41 +0000 (15:09 +0000)]
Another tightening of Win32 typedefs.
Bruce Momjian [Tue, 5 Oct 2004 14:27:07 +0000 (14:27 +0000)]
Fix typo in recent Win32 typedef change.
Bruce Momjian [Tue, 5 Oct 2004 13:48:35 +0000 (13:48 +0000)]
Remove unused Win32 defines, convert them to typdefs, per suggestion
from Peter.
Michael Meskes [Tue, 5 Oct 2004 10:48:37 +0000 (10:48 +0000)]
'::' is no longer interpreted as a variable in a prepare statement.
Neil Conway [Tue, 5 Oct 2004 00:14:45 +0000 (00:14 +0000)]
Pickup fix from upstream OpenBSD sources: mark a read-only local array as
"static" to reduce size of generated code slightly.
Neil Conway [Tue, 5 Oct 2004 00:12:49 +0000 (00:12 +0000)]
License cleanup: crypt.c and qsort.c to latest NetBSD CVS sources, to
pickup license clarification (3-clause BSD is now used). Add license
terms to memcmp.c (also from NetBSD), which previously had none.
Finally, pickup an upstream fix to crypt.c (const-ify some arrays).
Tom Lane [Mon, 4 Oct 2004 22:52:47 +0000 (22:52 +0000)]
Refer to ll_to_earth() function by its actual name.
Tom Lane [Mon, 4 Oct 2004 22:49:59 +0000 (22:49 +0000)]
Remove arithmetic operators on the 1-byte-char datatype, as per proposals
made several times in the past. Add coercion functions between "char"
and integer so that a workaround is possible if needed.
Initdb forced.
Tom Lane [Mon, 4 Oct 2004 22:13:14 +0000 (22:13 +0000)]
Correct the volatility labeling of ten timestamp-related functions,
per discussion from Friday. initdb not forced in this commit but I intend
to do that later.
Tom Lane [Mon, 4 Oct 2004 21:52:15 +0000 (21:52 +0000)]
PortalRun must guard against the possibility that the portal it's
running contains VACUUM or a similar command that will internally start
and commit transactions. In such a case, the original caller values of
CurrentMemoryContext and CurrentResourceOwner will point to objects that
will be destroyed by the internal commit. We must restore these pointers
to point to the newly-manufactured transaction context and resource owner,
rather than possibly pointing to deleted memory.
Also tweak xact.c so that AbortTransaction and AbortSubTransaction
forcibly restore a sane value for CurrentResourceOwner, much as they
have always done for CurrentMemoryContext. I'm not certain this is
necessary but I'm feeling paranoid today.
Responds to Sean Chittenden's bug report of 4-Oct.
Bruce Momjian [Mon, 4 Oct 2004 20:36:12 +0000 (20:36 +0000)]
Make sure no libs use libpgport by removing it from the link line.
Bruce Momjian [Mon, 4 Oct 2004 20:32:58 +0000 (20:32 +0000)]
Fix MinGW link failure with new libpgport processing.
Bruce Momjian [Mon, 4 Oct 2004 18:14:18 +0000 (18:14 +0000)]
Update comment on int64 printf speciifications for MinGW:
# MinGW uses '%I64d', though gcc throws an warning with -Wall,
# while '%lld' doesn't generate a warning, but doesn't work.
Bruce Momjian [Mon, 4 Oct 2004 18:05:55 +0000 (18:05 +0000)]
Readd -DFRONTEND to client makefiles because it still affects win32.h
defines.
Bruce Momjian [Mon, 4 Oct 2004 15:29:41 +0000 (15:29 +0000)]
Add CVS URL for docs.
Bruce Momjian [Mon, 4 Oct 2004 15:17:17 +0000 (15:17 +0000)]
Fix warnings from crypt.c compile.
Bruce Momjian [Mon, 4 Oct 2004 15:09:27 +0000 (15:09 +0000)]
Comment out unused variable.
Tom Lane [Mon, 4 Oct 2004 14:55:17 +0000 (14:55 +0000)]
Suppress getppid test on WIN32, per Dave Page.
Tom Lane [Mon, 4 Oct 2004 14:42:48 +0000 (14:42 +0000)]
Detect overflow in integer arithmetic operators (integer, smallint, and
bigint variants). Clean up some inconsistencies in error message wording.
Fix scanint8 to allow trailing whitespace in INT64_MIN case. Update
int8-exp-three-digits.out, which seems to have been ignored by the last
couple of people to modify the int8 regression test, and remove
int8-exp-three-digits-win32.out which is thereby exposed as redundant.
Bruce Momjian [Mon, 4 Oct 2004 13:43:59 +0000 (13:43 +0000)]
Make libpgport be front-end only and make libpgport_srv be a backend
library that uses palloc, ereport, etc. This simplifies the makefiles
for client applications.
Neil Conway [Mon, 4 Oct 2004 08:15:41 +0000 (08:15 +0000)]
Fix error in setseed() docs: "int32" is not a (SQL) type, but "integer" is.
Neil Conway [Mon, 4 Oct 2004 05:42:18 +0000 (05:42 +0000)]
Document that the semicolon following the final "END" in a function body
is optional.
Peter Eisentraut [Sun, 3 Oct 2004 20:29:24 +0000 (20:29 +0000)]
Translation update
Peter Eisentraut [Sun, 3 Oct 2004 20:24:26 +0000 (20:24 +0000)]
Translation updates
Tom Lane [Sun, 3 Oct 2004 00:13:29 +0000 (00:13 +0000)]
Add regression test inspired by Sebastian Böck.
Tom Lane [Sat, 2 Oct 2004 22:39:49 +0000 (22:39 +0000)]
Clean up handling of inherited-table update queries, per bug report
from Sebastian Böck. The fix involves being more consistent about
when rangetable entries are copied or modified. Someday we really
need to fix this stuff to not scribble on its input data structures
in the first place...
Bruce Momjian [Sat, 2 Oct 2004 08:19:43 +0000 (08:19 +0000)]
Update Farsi FAQ in ASCII.
Bruce Momjian [Sat, 2 Oct 2004 01:10:58 +0000 (01:10 +0000)]
Update length from 75 to 79.
Tom Lane [Fri, 1 Oct 2004 21:03:42 +0000 (21:03 +0000)]
Convert pg_stat_get_backend_idset to use the existing SRF support.
This seems the cleanest way of fixing its lack of a shutdown callback,
which was preventing it from working correctly in a query that didn't
run it to completion. Per bug report from Szima GÄbor.
Tom Lane [Fri, 1 Oct 2004 20:39:54 +0000 (20:39 +0000)]
fmgr_security_definer had better do a PG_TRY to ensure the outer userid
is restored on error exit.
Tom Lane [Fri, 1 Oct 2004 18:30:25 +0000 (18:30 +0000)]
Adjust postmaster to recognize that a lockfile containing its parent's PID
must be stale. Tweak example startup scripts to not use pg_ctl but launch
the postmaster directly, thereby ensuring that only the postmaster's direct
parent shell will be a postgres-owned process. In combination these should
fix the longstanding problem of the postmaster sometimes refusing to start
during reboot because it thinks the old lockfile is not stale.
Tom Lane [Fri, 1 Oct 2004 17:34:19 +0000 (17:34 +0000)]
Don't assume PQdb() will return a valid result from a failed connection.
Tom Lane [Fri, 1 Oct 2004 17:25:55 +0000 (17:25 +0000)]
Don't assume PQdb() will return a valid result from a failed connection.
Tom Lane [Fri, 1 Oct 2004 17:11:50 +0000 (17:11 +0000)]
Fallout from changing index locking rules: we can reduce the strength
of locking used by REINDEX. REINDEX needs only ShareLock on the parent
table, same as CREATE INDEX, plus an exclusive lock on the specific index
being processed.
Tom Lane [Fri, 1 Oct 2004 16:40:05 +0000 (16:40 +0000)]
Code review for NOWAIT patch: downgrade NOWAIT from fully reserved keyword
to unreserved keyword, use ereport not elog, assign a separate error code
for 'could not obtain lock' so that applications will be able to detect
that case cleanly.
Tom Lane [Fri, 1 Oct 2004 15:43:40 +0000 (15:43 +0000)]
Remove DROPs from contrib object creation scripts, per Dave Page.
Neil Conway [Fri, 1 Oct 2004 02:06:52 +0000 (02:06 +0000)]
Use 'override' when appending text to LDFLAGS, so the build doesn't break
if the user has defined LDFLAGS themselves.
Neil Conway [Fri, 1 Oct 2004 02:00:44 +0000 (02:00 +0000)]
Remove more traces of libpgtcl from the source tree. Also, make some
semi-related SGML cleanup. Original patch from ljb220@mindspring.com,
additional cleanup by Neil Conway.
Tom Lane [Thu, 30 Sep 2004 23:21:26 +0000 (23:21 +0000)]
Adjust index locking rules as per my proposal of earlier today. You
now are supposed to take some kind of lock on an index whenever you
are going to access the index contents, rather than relying only on a
lock on the parent table.
Tom Lane [Thu, 30 Sep 2004 21:12:45 +0000 (21:12 +0000)]
Add variant regression file to handle machines that convert -1e-700
to minus zero rather than zero; this includes at least Mac OS X 10.3
and Solaris 2.8.
Tom Lane [Thu, 30 Sep 2004 17:42:42 +0000 (17:42 +0000)]
Remove unnecessary use of index_open just to get the index name.
Tom Lane [Thu, 30 Sep 2004 16:38:39 +0000 (16:38 +0000)]
isinf.c needs <float.h> on some platforms, per Darcy Buskermolen.
Neil Conway [Thu, 30 Sep 2004 10:30:10 +0000 (10:30 +0000)]
Add a note suggesting that users should use the newer version of pg_dump
to perform upgrades, and cleanup some nearby text. Patch from Robert
Treat, editorializing by Neil Conway.
Neil Conway [Thu, 30 Sep 2004 04:23:27 +0000 (04:23 +0000)]
Add more index entries for reference pages related to prepare queries.
From Alvaro Herrera, editorializing by Neil Conway.
Bruce Momjian [Thu, 30 Sep 2004 03:50:34 +0000 (03:50 +0000)]
Update Brazilian FAQ.
Euler Taveira de Oliveira
Neil Conway [Thu, 30 Sep 2004 02:40:23 +0000 (02:40 +0000)]
Add an index entry for tablespaces. From Kris Jurka.
Tom Lane [Thu, 30 Sep 2004 00:24:27 +0000 (00:24 +0000)]
Come to think of it, functions in FROM have the same syntactic restriction
as CREATE INDEX did, and can be fixed the same way, for another small
improvement in usability and reduction in grammar size.
Tom Lane [Wed, 29 Sep 2004 23:39:20 +0000 (23:39 +0000)]
Split out everything that looks like a function call from c_expr into
a separate production func_expr. This allows us to accept all these
variants in the backwards-compatible syntax for creating a functional
index; which beats documenting exactly which things work and which don't.
Interestingly, it also seems to make the generated state machine a little
bit smaller.
Bruce Momjian [Wed, 29 Sep 2004 16:23:16 +0000 (16:23 +0000)]
Add Farsi version of FAQ.
Mahmoud Taghizadeh
Tom Lane [Wed, 29 Sep 2004 15:15:56 +0000 (15:15 +0000)]
Minor adjustments to improve the accuracy of our computation of required
shared memory size.
Neil Conway [Wed, 29 Sep 2004 06:27:11 +0000 (06:27 +0000)]
Minor documentation improvement.
Tom Lane [Tue, 28 Sep 2004 21:19:30 +0000 (21:19 +0000)]
Adjust obsolete comment about memory needs for lock table.
Tom Lane [Tue, 28 Sep 2004 20:46:37 +0000 (20:46 +0000)]
Arrange to preallocate all required space for the buffer and FSM hash
tables in shared memory. This ensures that overflow of the lock table
creates no long-lasting problems. Per discussion with Merlin Moncure.
Tom Lane [Tue, 28 Sep 2004 19:35:43 +0000 (19:35 +0000)]
Code review for recent dbsize changes. Fix some thinkos, enforce coding
style and message style standards, improve documentation.
Bruce Momjian [Tue, 28 Sep 2004 16:17:26 +0000 (16:17 +0000)]
An include path got missed out of the patch - see the attached fix.
This also adds debug build support to src/bin/psql/win32.mak.
Dave Page