]> granicus.if.org Git - sysstat/log
sysstat
8 years agofix tapestat man page typos
Steve Kay [Fri, 4 Mar 2016 19:48:21 +0000 (11:48 -0800)]
fix tapestat man page typos

8 years agoSVG: Draw txkB/s and rxkB/s network metrics to scale
Sebastien GODARD [Fri, 4 Mar 2016 14:43:02 +0000 (15:43 +0100)]
SVG: Draw txkB/s and rxkB/s network metrics to scale

The metrics are expressed in kB/s whereas the corresponding counters are
saved in B/s. So recalculate min and max values in kB/s before drawing
graphs.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoMerge branch 'stevekay-master'
Sebastien GODARD [Fri, 4 Mar 2016 14:04:39 +0000 (15:04 +0100)]
Merge branch 'stevekay-master'

Disable NLS if one of xgettext, msgmerge or msgfmt commands is
unavailable.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoFixes #97 - disable NLS if any gettext components are unavailable
Steve Kay [Sat, 27 Feb 2016 20:06:51 +0000 (15:06 -0500)]
Fixes #97 - disable NLS if any gettext components are unavailable

8 years agoMerge branch 'iso-time-fmt' of https://github.com/ynamiki/sysstat
Sebastien GODARD [Wed, 24 Feb 2016 15:11:50 +0000 (16:11 +0100)]
Merge branch 'iso-time-fmt' of https://github.com/ynamiki/sysstat

8 years agoSVG: Add SVG output for network statistics
Sebastien GODARD [Wed, 24 Feb 2016 11:47:36 +0000 (12:47 +0100)]
SVG: Add SVG output for network statistics

Add 3 new sets of graphs.
They will be displayed for each network interfaces installed.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Free graphs structures only when all graphs have been drawn
Sebastien GODARD [Wed, 24 Feb 2016 11:40:45 +0000 (12:40 +0100)]
SVG: Free graphs structures only when all graphs have been drawn

Create a separate function to free structures.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Add item name in graph title
Sebastien GODARD [Wed, 24 Feb 2016 11:14:08 +0000 (12:14 +0100)]
SVG: Add item name in graph title

Each item (network interface, etc.) will have its distinct set of
graphs. So add item name in the title of their graphs.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Explicitly pass structures to be compared
Sebastien GODARD [Wed, 24 Feb 2016 10:47:07 +0000 (11:47 +0100)]
SVG: Explicitly pass structures to be compared

The structures which will be scanned to check for min/max values need to
be explicitly passed to save_extrema() function. Indeed, for activities
with several items (eg. network statistics), we will need to scan each
item structure independently.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoPrint time in the ISO format if S_TIME_FORMAT=ISO in sar
ynamiki [Tue, 23 Feb 2016 05:55:56 +0000 (14:55 +0900)]
Print time in the ISO format if S_TIME_FORMAT=ISO in sar

8 years agoSVG: Check index in svg_colors[] array
Sebastien GODARD [Mon, 22 Feb 2016 17:49:47 +0000 (18:49 +0100)]
SVG: Check index in svg_colors[] array

Make sure that index used to get colors from svg_colors[] array
doesn't exceed array size.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Init newly allocated strings
Sebastien GODARD [Mon, 22 Feb 2016 17:26:34 +0000 (18:26 +0100)]
SVG: Init newly allocated strings

Graph definition is made of successive SVG "path" commands concatenated
together. Make sure that the strings allocated to receive these definitions
are initialized before being used.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Add SVG output for paging statistics
Sebastien GODARD [Sun, 21 Feb 2016 16:38:19 +0000 (17:38 +0100)]
SVG: Add SVG output for paging statistics

Add 3 new sets of SVG graphs:
1) pgpgin/S, pgpgout/s
2) fault/s, majflt/s
3) pgfree/s, pgscank/s, pgscand/s, pgsteal/s

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoFix comment
Sebastien GODARD [Sun, 21 Feb 2016 16:36:14 +0000 (17:36 +0100)]
Fix comment

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Create common functions
Sebastien GODARD [Sun, 21 Feb 2016 16:33:10 +0000 (17:33 +0100)]
SVG: Create common functions

These functions will be used to draw graphs for other acitivities.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Change colors order
Sebastien GODARD [Sun, 21 Feb 2016 16:26:14 +0000 (17:26 +0100)]
SVG: Change colors order

This is purely cosmetic...

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoStarting sysstat 11.3.2
Sebastien GODARD [Sat, 20 Feb 2016 15:32:43 +0000 (16:32 +0100)]
Starting sysstat 11.3.2

Update sysstat version number in configure script.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosysstat-11.3.1 v11.3.1
Sebastien GODARD [Sat, 20 Feb 2016 15:27:35 +0000 (16:27 +0100)]
sysstat-11.3.1

sysstat version 11.3.1 final packaging.
lsm and spec files updated.
Changelog added.

NOTE: A stable version (11.2.1.1) also exists and will be available for
download from my web site:

http://pagesperso-orange.fr/sebastien.godard/

The stable version includes only the bug fixes added in sysstat 11.3.1
but not the new features.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoMakefile: Update README file name
Sebastien GODARD [Sat, 20 Feb 2016 15:25:22 +0000 (16:25 +0100)]
Makefile: Update README file name

README file name is now README.md.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoNLS: Sync with Translation Project
Sebastien GODARD [Sat, 20 Feb 2016 15:06:17 +0000 (16:06 +0100)]
NLS: Sync with Translation Project

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoFAQ updated
Sebastien GODARD [Sat, 20 Feb 2016 14:28:11 +0000 (15:28 +0100)]
FAQ updated

Update the FAQ and tell about the new SVG output format.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate sadf manual page
Sebastien GODARD [Sat, 20 Feb 2016 14:26:58 +0000 (15:26 +0100)]
Update sadf manual page

Describe sadf's option -g in manual page.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Handle files with orphan samples properly
Sebastien GODARD [Fri, 19 Feb 2016 13:38:36 +0000 (14:38 +0100)]
SVG: Handle files with orphan samples properly

If a file has only orphan samples then display "No data" indicating that
the graph cannot be drawn.
An orphan sample is something like:

sadc data        <-- LINUX RESTART
sadc data 1 1    <-- Create an orphan sample
sadc data        <-- LINUX RESTART

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Fix background H lines when all values are zero
Sebastien GODARD [Fri, 19 Feb 2016 12:48:22 +0000 (13:48 +0100)]
SVG: Fix background H lines when all values are zero

The default Y scale max value is 1 when all the values are zero.
Yet in this case we still want 3 horizontal lines for the background
grid.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Fix Y axis scale graduations for small values
Sebastien GODARD [Fri, 19 Feb 2016 12:13:41 +0000 (13:13 +0100)]
SVG: Fix Y axis scale graduations for small values

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Add SVG output for task creation and system switching activity.
Sebastien GODARD [Fri, 19 Feb 2016 09:37:05 +0000 (10:37 +0100)]
SVG: Add SVG output for task creation and system switching activity.

Update sadf's SVG ouptput to create graphs for task creation and system
switching activity (this corresponds to the output of sar -w).
This is just a proof of concept.
Try it with "sadf -g /your/sa/datafile -- -w > out.html" and open
the resulting HTML file in your web browser.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate README and copyright messages
Sebastien GODARD [Fri, 19 Feb 2016 08:11:49 +0000 (09:11 +0100)]
Update README and copyright messages

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Calculate total number of graphs to display
Sebastien GODARD [Fri, 19 Feb 2016 07:28:41 +0000 (08:28 +0100)]
SVG: Calculate total number of graphs to display

Add get_svg_graph_nr() function, which calculate the total number of
graphs to display.
The result is used to set the output size in the SVG header.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosa_common.c: Update comment in code
Sebastien GODARD [Mon, 15 Feb 2016 17:02:05 +0000 (18:02 +0100)]
sa_common.c: Update comment in code

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoDefine alignment constants
Sebastien GODARD [Mon, 15 Feb 2016 16:58:38 +0000 (17:58 +0100)]
Define alignment constants

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoAdd new FO_NO_TRUE_TIME flag
Sebastien GODARD [Mon, 15 Feb 2016 16:36:48 +0000 (17:36 +0100)]
Add new FO_NO_TRUE_TIME flag

Define a new flag indicating that the timestamp cannot be displayed in
the original local time of the data file creator.
This flag will be used by the SVG output format, which also means that
the user won't be able to use sadf's option -t with this format.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUse anonymous pointer to pass specific parameters
Sebastien GODARD [Mon, 15 Feb 2016 16:21:31 +0000 (17:21 +0100)]
Use anonymous pointer to pass specific parameters

f_header() functions and f_timestamp() functions now use an anonymous
pointer to get parameters whose type depends on the output format.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Update SVG report header
Sebastien GODARD [Sun, 14 Feb 2016 15:04:36 +0000 (16:04 +0100)]
SVG: Update SVG report header

Update header that will be displayed once at the beginning of the
report, before all the graphs that will follow.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Define new constants
Sebastien GODARD [Sun, 14 Feb 2016 14:58:17 +0000 (15:58 +0100)]
SVG: Define new constants

Define new constants that will be used to draw SVG graphs.
Move previous existing definitions from sadf.h to sa.h

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoMerge branch 'svg'
Sebastien GODARD [Sun, 14 Feb 2016 14:40:04 +0000 (15:40 +0100)]
Merge branch 'svg'

8 years agoFixed typo in .spec
Peter Schiffer [Tue, 9 Feb 2016 14:24:52 +0000 (15:24 +0100)]
Fixed typo in .spec

8 years agoCREDITS file - removed trailing whitespaces
Peter Schiffer [Tue, 9 Feb 2016 14:07:34 +0000 (15:07 +0100)]
CREDITS file - removed trailing whitespaces

8 years agoCREDITS file - convert to utf-8
Peter Schiffer [Tue, 9 Feb 2016 14:05:56 +0000 (15:05 +0100)]
CREDITS file - convert to utf-8

8 years agoUpdate license text
Peter Schiffer [Tue, 9 Feb 2016 12:56:34 +0000 (13:56 +0100)]
Update license text

Update license text to the latest version, with correct FSF address.

8 years agoSVG: Update xml header in SVG output
Sebastien GODARD [Fri, 5 Feb 2016 08:09:03 +0000 (09:09 +0100)]
SVG: Update xml header in SVG output

Specify some attributes taking into account the number of graphs to be
displayed.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoAdd new flag to read_next_sample() function
Sebastien GODARD [Fri, 5 Feb 2016 08:02:09 +0000 (09:02 +0100)]
Add new flag to read_next_sample() function

read_next_sample() function didn't fill the timestamp for special
records (COMMENT or RESTART ones) that had to be ignored.
So add a new flag (SET_TIMESTAMPS) to tell read_next_sample() function
to set the timestamps for special records when this is needed.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoSVG: Add new g_nr field in activity structure
Sebastien GODARD [Fri, 29 Jan 2016 15:09:34 +0000 (16:09 +0100)]
SVG: Add new g_nr field in activity structure

The g_nr field indicates the number of graphs to draw for this activity,
and for one item.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosadf: Add initial support for SVG output format
Sebastien GODARD [Fri, 29 Jan 2016 09:12:16 +0000 (10:12 +0100)]
sadf: Add initial support for SVG output format

Add new SVG output format. This format can be selected with "sadf -g".
Add function used to display SVG header.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoJSON: Don't display fchosts tag when no stats exist
Sebastien GODARD [Tue, 26 Jan 2016 21:43:23 +0000 (22:43 +0100)]
JSON: Don't display fchosts tag when no stats exist

The JSON print function can be called for A_NET_FC (Fibre Channel)
activity even if no statistics exist. This is because this activity has
the AO_CLOSE_MARKUP flag used to close the "network" section of the
output. Anyway, in this case (when no stats exist), it should only do
that (close the network section) et not display the "fchost" tag.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoMove JSON specific code to its corresponding function
Sebastien GODARD [Mon, 25 Jan 2016 07:24:17 +0000 (08:24 +0100)]
Move JSON specific code to its corresponding function

A bit of code was specific to JSON output. So move this code to the
f_timestamp function used by JSON output format, so that the main code
remains generic.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoDon't define seps variable twice
Sebastien GODARD [Mon, 25 Jan 2016 07:20:33 +0000 (08:20 +0100)]
Don't define seps variable twice

Don't define the seps variable as static so that it can be reused in
other files.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoRemove extern keyword from functions declarations
Sebastien GODARD [Sun, 24 Jan 2016 20:53:28 +0000 (21:53 +0100)]
Remove extern keyword from functions declarations

"extern" keyword is not needed when declaring a function (its use is
implicit).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoFix comment in sadf.c
Sebastien GODARD [Sun, 24 Jan 2016 20:21:41 +0000 (21:21 +0100)]
Fix comment in sadf.c

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosadf: Merge functions and make code (almost) generic
Sebastien GODARD [Fri, 22 Jan 2016 15:03:26 +0000 (16:03 +0100)]
sadf: Merge functions and make code (almost) generic

sadf code refactoring: Merge write_mech_stats(), logic1_write_stats()
and logic2_write_stats() functions.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoFix comment in format.c
Sebastien GODARD [Fri, 22 Jan 2016 13:01:36 +0000 (14:01 +0100)]
Fix comment in format.c

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoMove format specific code to its corresponding function
Sebastien GODARD [Fri, 22 Jan 2016 12:57:42 +0000 (13:57 +0100)]
Move format specific code to its corresponding function

Incrementing tab variable was specific to XML output. So move this code
to the f_timestamp function used by XML output format, so that thee main
code remains generic.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosar/sadf: Merge functions used to print special records
Sebastien GODARD [Fri, 22 Jan 2016 11:43:53 +0000 (12:43 +0100)]
sar/sadf: Merge functions used to print special records

Merge functions used to display special (RESTART or COMMENT) records.

Before:
sadf: print_special_record()
sar: sar_print_special()

After:
print_special_record()

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosar/sadf: Merge functions set_record_timestamp_string()
Sebastien GODARD [Fri, 22 Jan 2016 08:11:17 +0000 (09:11 +0100)]
sar/sadf: Merge functions set_record_timestamp_string()

sar and sadf had the same functions with almost the same features.
Merge them.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosar/sadf: Merge functions used to get timestamps
Sebastien GODARD [Mon, 18 Jan 2016 17:36:18 +0000 (18:36 +0100)]
sar/sadf: Merge functions used to get timestamps

sadf code refactoring: Merge functions used to get and save timestamps.

Before:
sar: sar_get_record_timestamp_struct()
sadf: sadf_get_record_timestamp_struct()

After:
sa_get_record_timestamp_struct()

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosadf: Rename functions
Sebastien GODARD [Mon, 18 Jan 2016 17:31:29 +0000 (18:31 +0100)]
sadf: Rename functions

Didn't like the previous ones, but still not enthusiastic by the new
ones... :-/

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosadf: Don't set timestamps twice
Sebastien GODARD [Sat, 16 Jan 2016 13:29:37 +0000 (14:29 +0100)]
sadf: Don't set timestamps twice

Remove call to sadf_get_record_timestamp_struct() function as it has
already been called in read_next_sample() function.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosadf: Create read_next_sample() function
Sebastien GODARD [Sat, 16 Jan 2016 13:12:58 +0000 (14:12 +0100)]
sadf: Create read_next_sample() function

sadf code refactoring: Simplify code. Create a common function to read
next sample statistics (read_next_sample()).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosadf: Merge functions used to display special records
Sebastien GODARD [Sat, 16 Jan 2016 07:59:37 +0000 (08:59 +0100)]
sadf: Merge functions used to display special records

sadf code refactoring: Merge functions used to display special (RESTART
or COMMENT) records.

Before:
write_textual_restarts()
write_textual_comments()
sadf_print_special()

After:
print_special_record()

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoRemove redundant variable
Sebastien GODARD [Fri, 15 Jan 2016 16:33:24 +0000 (17:33 +0100)]
Remove redundant variable

The name of the file being read was passed twice to
textual_display_loop() function. So remove one of them.

Make also a few cosmetic changes in code.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoConvert README file to Markdown format
Sebastien GODARD [Mon, 28 Dec 2015 16:21:08 +0000 (17:21 +0100)]
Convert README file to Markdown format

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoStarting sysstat 11.3.1
Sebastien GODARD [Sat, 26 Dec 2015 09:03:26 +0000 (10:03 +0100)]
Starting sysstat 11.3.1

Update sysstat number in configure script.

This version is the first one of the new 11.3 development series,
including all the new features in addition to the bugfixes included
in the 11.2 stable series.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosysstat-11.2.0 v11.2.0
Sebastien GODARD [Sat, 26 Dec 2015 08:51:01 +0000 (09:51 +0100)]
sysstat-11.2.0

sysstat version 11.2.0 final packaging.
lsm and spec files updated.
Changelog added.

Version 11.2.0 is the first one of the new 11.2 stable series.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoNLS: Sync with Translation Project
Sebastien GODARD [Sat, 26 Dec 2015 08:49:34 +0000 (09:49 +0100)]
NLS: Sync with Translation Project

Some translations updated.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosadf: Fix bug preventing sadf from converting an old format datafile
Sebastien GODARD [Fri, 18 Dec 2015 08:23:22 +0000 (09:23 +0100)]
sadf: Fix bug preventing sadf from converting an old format datafile

Version 11.1.5 added a check on file_magic.header_size present in the
header of a data file.
An error message should not be displayed if this check is not successful
when sadf is used to convert the data file (sadf -c) or used to display
its header contents (sadf -H).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoFix typos in sa.h
Sebastien GODARD [Sat, 12 Dec 2015 10:42:09 +0000 (11:42 +0100)]
Fix typos in sa.h

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosar: Check for items upper limit before reading a datafile
Sebastien GODARD [Sat, 12 Dec 2015 10:36:54 +0000 (11:36 +0100)]
sar: Check for items upper limit before reading a datafile

Commit 7ebfd7e added a check for items upper limit used by sadc before
appending data to a file.
This commit adds the same kind of check used by sar before reading a
data file.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoIncrease NR_CPUS to match kernel upstream
Peter Schiffer [Tue, 8 Dec 2015 18:27:38 +0000 (19:27 +0100)]
Increase NR_CPUS to match kernel upstream

We hit current limit of 2048 CPUs defined in common.h. Kernel upstream has
currently set 8192 as maximum number of CPUs[1], so sync with them.

[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=b53b5eda8194214928c8243d711a75dbf51809fc

8 years agotapestat: Remove unused variable
Sebastien GODARD [Sat, 5 Dec 2015 15:13:54 +0000 (16:13 +0100)]
tapestat: Remove unused variable

"curr" variable is unused in write_stats() function. So remove it.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoadd missing closing paren to GET_POLICY
imarko [Tue, 1 Dec 2015 17:01:50 +0000 (09:01 -0800)]
add missing closing paren to GET_POLICY

8 years agopidstat: Define new SCHED_DEADLINE policy
Sebastien GODARD [Fri, 20 Nov 2015 14:08:22 +0000 (15:08 +0100)]
pidstat: Define new SCHED_DEADLINE policy

Define new scheduling policy for pidstat.
This policy (SCHED_DEADLINE) will be displayed as DEADLN by pidstat -R.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoAlso check for negative values for nr/nr2 fields
Sebastien GODARD [Wed, 11 Nov 2015 17:43:59 +0000 (18:43 +0100)]
Also check for negative values for nr/nr2 fields

nr and nr2 fields in activity structures should never be zero or
negative when they are read from sadc.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoFix default value for number of subitems for A_PWR_WGHFREQ activity
Sebastien GODARD [Wed, 11 Nov 2015 17:38:46 +0000 (18:38 +0100)]
Fix default value for number of subitems for A_PWR_WGHFREQ activity

Default value should be -1 for nr2 field (number of different
frequencies for A_PWR_WGHFREQ activity).
A values of -1 means that the corresponding number has still not been
calculated by the f_count2() function.
This is consistent with default values used for nr field.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate mpstat manual page
Sebastien GODARD [Sat, 7 Nov 2015 10:16:29 +0000 (11:16 +0100)]
Update mpstat manual page

Describe new possible syntax for mpstat's option -I.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agompstat: New syntax allowed for option -I
Sebastien GODARD [Sat, 7 Nov 2015 10:06:41 +0000 (11:06 +0100)]
mpstat: New syntax allowed for option -I

mpstat's option -I now accepts a list of comma-separated arguments (SUM,
CPU, SCPU, ALL).
Eg. "mpstat -I SUM,SCPU".
Previous syntax can still be used ("mpstat -I SUM -I SCPU").

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agompstat: Code refactoring
Sebastien GODARD [Fri, 6 Nov 2015 09:35:12 +0000 (10:35 +0100)]
mpstat: Code refactoring

Rework mpstat's code (especially code that handles per-CPU interrupts
statistics: mpstat -I { CPU | SCPU }).
This new code better deals with special cases than can occur for per
processor interrupts statistics:
1) If the last interrupt in list (ie. in file /proc/interrupts or
/proc/softirqs) was unregistered then the header line was not updated.
This is now fixed.
2) If at least two consecutive interrupts were unregistered in the same
time interval then the statistics for all the following interrupts
couldn't be calculated for one period (values were displayed as "N/A").
This is now fixed.
3) If at least two consecutive interrupts were newly registered in the
same time interval then the statistics for all the following interrupts
couldn't be calculated for one period (values were displayed as "N/A").
This is now fixed.
4) When a new interrupt was registered (ie. appeared in file
/proc/interrupts or /proc/softirqs) then its value was displayed as not
available (N/A) for the first period. Now assume that its counter has
started from zero so that a value can be displayed.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosar: Fix color output for %temp and %in fields
Sebastien GODARD [Wed, 28 Oct 2015 21:01:09 +0000 (22:01 +0100)]
sar: Fix color output for %temp and %in fields

The color used to display %temp (sar -m TEMP) and %in (sar -m IN) values
should depend on the range they belong to.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosar: Check min size of sa data file header
Sebastien GODARD [Sun, 25 Oct 2015 15:00:20 +0000 (16:00 +0100)]
sar: Check min size of sa data file header

The size of an sa data file header may be greater than expected (should
we read a data file from eg. a future sysstat version), but it cannot be
smaller than current version's header size (else we wouldn't be able to
interpret the header contents).

In relation with CID #29719.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosadc: Fix insecure data handling, really
Sebastien GODARD [Sun, 25 Oct 2015 14:13:59 +0000 (15:13 +0100)]
sadc: Fix insecure data handling, really

Commit 7ebfd7e checked upper bounds of values read from a possibly
tainted data file.
Add a lower bounds check to really fix the insecure data handling.
CID #29720.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoRemove obsolete nfsiostat-sysstat command
Sebastien GODARD [Sun, 25 Oct 2015 13:49:26 +0000 (14:49 +0100)]
Remove obsolete nfsiostat-sysstat command

Remove obsolete nfsiostat-sysstat command (an nfsiostat command already
exists in the nfs-utils package).

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoStarting sysstat 11.2.0
Sebastien GODARD [Fri, 23 Oct 2015 13:02:44 +0000 (15:02 +0200)]
Starting sysstat 11.2.0

Update sysstat version number in configure script.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosysstat-11.1.8 v11.1.8
Sebastien GODARD [Fri, 23 Oct 2015 12:55:05 +0000 (14:55 +0200)]
sysstat-11.1.8

sysstat version 11.1.8 final packaging.
lsm and spec files updated.
Changelog added.
Cosmetic changes in source code.

NOTE: A stable version (11.0.8) also exists and will be available for
download from my web site:

http://pagesperso-orange.fr/sebastien.godard/

The stable version includes only the bug fixes added in sysstat 11.1.8
but not the new features.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoNLS: Sync with Translation Project
Sebastien GODARD [Fri, 23 Oct 2015 12:38:53 +0000 (14:38 +0200)]
NLS: Sync with Translation Project

Various translations updated.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate Shane's mail address
Sebastien GODARD [Wed, 21 Oct 2015 19:34:33 +0000 (21:34 +0200)]
Update Shane's mail address

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosar: Rework SIGINT signal handling
Sebastien GODARD [Fri, 16 Oct 2015 14:37:07 +0000 (16:37 +0200)]
sar: Rework SIGINT signal handling

Remove extra line of statistics displayed by sar when SIGINT (ie.
ctrl/c) was received.

Before:
-------
16:42:12       proc/s   cswch/s
16:42:13         0.00    508.00
16:42:14         0.00    491.00
^C

16:42:15         0.00    646.00  <<<<<<<<
Average:         0.00    548.33

Now:
----
16:40:42       proc/s   cswch/s
16:40:43         0.00    671.00
16:40:44         0.00    474.00
^C

Average:         0.00    572.50

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosar/sadc: Check for items upper limits
Sebastien GODARD [Fri, 16 Oct 2015 09:22:23 +0000 (11:22 +0200)]
sar/sadc: Check for items upper limits

Check for items upper limits before displaying stats or creating an sa
data file.
This is made necessary because we check for these same limits when we
read data from a possibly tainted sa data file.
Also rename constant names to indicate that their values are actually
the maximum number of items that sar/sadc can handle.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate manual pages
Sebastien GODARD [Mon, 12 Oct 2015 15:37:30 +0000 (17:37 +0200)]
Update manual pages

Warn the user about the use of colors so that they aren't misunderstood.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate tapestat manual page
Sebastien GODARD [Mon, 12 Oct 2015 15:36:18 +0000 (17:36 +0200)]
Update tapestat manual page

Add documentation on color support for tapestat command.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoAdd color support for tapestat command
Sebastien GODARD [Mon, 12 Oct 2015 15:35:15 +0000 (17:35 +0200)]
Add color support for tapestat command

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agosadc: Fix insecure data handling
Sebastien GODARD [Sun, 11 Oct 2015 14:14:05 +0000 (16:14 +0200)]
sadc: Fix insecure data handling

In open_ofile() function in sadc.c: Some values were read from a
(possibly tainted) sa datafile then used to allocate memory without
being checked before.
So set some limits for each possible items, and check that their number
(as read from an sa datafile) doesn't exceed their corresponding limit.

Fix CID #29720.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate librdsensors.a target in Makefile
Sebastien GODARD [Fri, 9 Oct 2015 12:40:54 +0000 (14:40 +0200)]
Update librdsensors.a target in Makefile

Prevent librdsensors.a target from being systematically executed.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUse ISO C99 extensions to display 64 bit values in color
Sebastien GODARD [Fri, 9 Oct 2015 11:55:44 +0000 (13:55 +0200)]
Use ISO C99 extensions to display 64 bit values in color

Rename cprintf_ull() function to cprintf_u64() and use ISO C99
extensions (uint64_t type definition, PRIu64 macro) to display 64 bit
values in color.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoFix untrusted value used as argument
Sebastien GODARD [Tue, 6 Oct 2015 14:58:01 +0000 (16:58 +0200)]
Fix untrusted value used as argument

sa_vol_act_nr is read from an untrusted source and used as a loop
boundary. Check it before using it.
CID #29720.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate cifsiostat manual page
Sebastien GODARD [Tue, 6 Oct 2015 14:08:49 +0000 (16:08 +0200)]
Update cifsiostat manual page

Add documentation on color support for cifsiostat.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoAdd color support for cifsiostat command
Sebastien GODARD [Tue, 6 Oct 2015 14:07:51 +0000 (16:07 +0200)]
Add color support for cifsiostat command

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate pidstat manual page
Sebastien GODARD [Mon, 5 Oct 2015 06:04:51 +0000 (08:04 +0200)]
Update pidstat manual page

Add documentation on color support for pidstat.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoAdd color support for pidstat command
Sebastien GODARD [Sun, 4 Oct 2015 12:14:13 +0000 (14:14 +0200)]
Add color support for pidstat command

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate iostat, mpstat and sar manual pages
Sebastien GODARD [Fri, 2 Oct 2015 09:51:47 +0000 (11:51 +0200)]
Update iostat, mpstat and sar manual pages

Update manual pages to explain new S_COLORS_SGR environment variable.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoAdd support for color customization
Sebastien GODARD [Fri, 2 Oct 2015 09:49:27 +0000 (11:49 +0200)]
Add support for color customization

Add new S_COLORS_SGR environment variable to give the user the
possibility to customize the colors used to display statistics for
iostat, mpstat and sar commands.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoUpdate manual pages
Sebastien GODARD [Mon, 28 Sep 2015 19:41:27 +0000 (21:41 +0200)]
Update manual pages

Indicate the possible values for S_COLORS environment variable in
iostat, mpstat and sar manual pages.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
8 years agoDefine S_COLORS possible values
Sebastien GODARD [Sun, 27 Sep 2015 13:54:10 +0000 (15:54 +0200)]
Define S_COLORS possible values

Sysstat now takes into account the following values for S_COLOR
environment variable:
"never": Don't use colorization
"always": Always use colorization
"auto" (or any other value different from "never" and "always"): Use
colorization only if stdout is a terminal.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>