]> granicus.if.org Git - graphviz/log
graphviz
3 years agobcomps: remove unnecessary parens
Matthew Fernandez [Sat, 13 Nov 2021 03:30:47 +0000 (19:30 -0800)]
bcomps: remove unnecessary parens

3 years agobcomps getName: use size_t for buffer lengths
Matthew Fernandez [Sat, 13 Nov 2021 03:26:31 +0000 (19:26 -0800)]
bcomps getName: use size_t for buffer lengths

Squashes some -Wconversion warnings.

3 years agobcomps blockName: use size_t for buffer lengths
Matthew Fernandez [Sat, 13 Nov 2021 03:24:58 +0000 (19:24 -0800)]
bcomps blockName: use size_t for buffer lengths

Squashes some -Wconversion warnings.

3 years agogvpack redoBBk: use size_t for buffer lengths
Matthew Fernandez [Sat, 13 Nov 2021 03:17:28 +0000 (19:17 -0800)]
gvpack redoBBk: use size_t for buffer lengths

Squashes some -Wconverion warnings.

3 years agogvpack freef: squash -Wunused-parameter warnings
Matthew Fernandez [Sat, 13 Nov 2021 03:11:16 +0000 (19:11 -0800)]
gvpack freef: squash -Wunused-parameter warnings

3 years agogvpack init: use a size_t to squash some -Wconversion warnings
Matthew Fernandez [Sat, 13 Nov 2021 03:09:24 +0000 (19:09 -0800)]
gvpack init: use a size_t to squash some -Wconversion warnings

3 years agosccmap.c: use libc support to define 'INF'
Matthew Fernandez [Sat, 13 Nov 2021 03:00:46 +0000 (19:00 -0800)]
sccmap.c: use libc support to define 'INF'

Squashes a -Wconversion warning.

3 years agosccmap.c: return an unsigned type from 'visit'
Matthew Fernandez [Sat, 13 Nov 2021 02:59:48 +0000 (18:59 -0800)]
sccmap.c: return an unsigned type from 'visit'

Squashes a -Wsign-conversion warning.

The `val` member of `Agnodeinfo_t` is unsigned and all uses of this function
store the return value in an unsigned. So it seems this function always should
have been declared as returning an unsigned.

3 years agosccmap.c: use unsigned types consistently in sccstate
Matthew Fernandez [Sat, 13 Nov 2021 02:58:45 +0000 (18:58 -0800)]
sccmap.c: use unsigned types consistently in sccstate

Squashes a -Wconversion warning.

3 years agosccmap.c: remove 'INLINE' alternatives
Matthew Fernandez [Sat, 13 Nov 2021 02:53:58 +0000 (18:53 -0800)]
sccmap.c: remove 'INLINE' alternatives

Modern compilers are easily capable of inlining these functions by themselves.

3 years agosccmap.c: use another unsigned type to squash -Wconversion warnings
Matthew Fernandez [Sat, 13 Nov 2021 02:53:14 +0000 (18:53 -0800)]
sccmap.c: use another unsigned type to squash -Wconversion warnings

The `val` member of `Agnodeinfo_t` is unsigned and all uses of this function
store the return value in an unsigned. So it seems this function always should
have been declared as returning an unsigned.

3 years agosccmap.c: use an unsigned type to squash some -Wconversion warnings
Matthew Fernandez [Sat, 13 Nov 2021 02:49:26 +0000 (18:49 -0800)]
sccmap.c: use an unsigned type to squash some -Wconversion warnings

The `val` member of `Agnodeinfo_t` is unsigned and all uses of this function
store the return value in an unsigned. So it seems this function always should
have been declared as returning an unsigned.

3 years agogvcolor.c: remove an unnecessary cast
Matthew Fernandez [Sat, 13 Nov 2021 02:35:12 +0000 (18:35 -0800)]
gvcolor.c: remove an unnecessary cast

3 years agogvcolor.c: remove duplicated #include
Matthew Fernandez [Sat, 13 Nov 2021 02:33:03 +0000 (18:33 -0800)]
gvcolor.c: remove duplicated #include

3 years agogvcolor.c: use a size_t to squash a -Wsign-conversion warning
Matthew Fernandez [Sat, 13 Nov 2021 02:32:29 +0000 (18:32 -0800)]
gvcolor.c: use a size_t to squash a -Wsign-conversion warning

3 years agoMerge branch 'cross' into 'main'
Matthew Fernandez [Fri, 19 Nov 2021 01:49:13 +0000 (01:49 +0000)]
Merge branch 'cross' into 'main'

cmd/dot: don't run dot -c when cross-compiling

See merge request graphviz/graphviz!2281

3 years agoCHANGELOG.md entry for the prior commit
Matthew Fernandez [Fri, 19 Nov 2021 01:01:11 +0000 (17:01 -0800)]
CHANGELOG.md entry for the prior commit

3 years agocmd/dot: don't run dot -c when cross-compiling
Alyssa Ross [Fri, 12 Nov 2021 16:35:05 +0000 (16:35 +0000)]
cmd/dot: don't run dot -c when cross-compiling

We probably can't execute the binary we've cross compiled.

3 years agoMerge branch 'smattr/5E1B768C-337D-4ED1-9693-E6A6B1DFE934' into 'main'
Matthew Fernandez [Wed, 17 Nov 2021 16:26:34 +0000 (16:26 +0000)]
Merge branch 'smattr/5E1B768C-337D-4ED1-9693-E6A6B1DFE934' into 'main'

cgraph man page formatting fix

See merge request graphviz/graphviz!2280

3 years agoadd a CHANGELOG entry for the prior commit
Matthew Fernandez [Fri, 12 Nov 2021 05:13:17 +0000 (21:13 -0800)]
add a CHANGELOG entry for the prior commit

3 years agoCorrect boldness of agnxtsubg in cgraph.3
Magnus Jacobsson [Sat, 5 Sep 2020 08:14:45 +0000 (10:14 +0200)]
Correct boldness of agnxtsubg in cgraph.3

3 years agoMerge branch 'smattr/6c18e731-115d-4167-92e7-bf96cbbe151e' into 'main'
Matthew Fernandez [Wed, 17 Nov 2021 03:36:35 +0000 (03:36 +0000)]
Merge branch 'smattr/6c18e731-115d-4167-92e7-bf96cbbe151e' into 'main'

gmlparse.y: fix all compiler warnings

See merge request graphviz/graphviz!2278

3 years agogmlparse.y: remove unnecessary parens
Matthew Fernandez [Thu, 11 Nov 2021 04:30:15 +0000 (20:30 -0800)]
gmlparse.y: remove unnecessary parens

3 years agomkGraph: remove shadowing of 'G' parameter
Matthew Fernandez [Thu, 11 Nov 2021 04:25:42 +0000 (20:25 -0800)]
mkGraph: remove shadowing of 'G' parameter

3 years agoaddNodeLabelGraphics: remove unused 'xb' parameter
Matthew Fernandez [Thu, 11 Nov 2021 04:19:57 +0000 (20:19 -0800)]
addNodeLabelGraphics: remove unused 'xb' parameter

3 years agogmlparse.y: remove commented out code
Matthew Fernandez [Thu, 11 Nov 2021 04:18:36 +0000 (20:18 -0800)]
gmlparse.y: remove commented out code

3 years agofree_attr: squash -Wunused-parameter warnings
Matthew Fernandez [Thu, 11 Nov 2021 04:18:16 +0000 (20:18 -0800)]
free_attr: squash -Wunused-parameter warnings

3 years agogmlparse.y: consistently use unsigned short types for 'kind'
Matthew Fernandez [Thu, 11 Nov 2021 04:17:07 +0000 (20:17 -0800)]
gmlparse.y: consistently use unsigned short types for 'kind'

Squashes a -Wconversion warning.

3 years agogmlparse.y: consistently use unsigned short types for 'sort'
Matthew Fernandez [Thu, 11 Nov 2021 04:15:20 +0000 (20:15 -0800)]
gmlparse.y: consistently use unsigned short types for 'sort'

Squashes a -Wconversion warning.

3 years agogmlparse.y: remove unused 'ushort' typedef
Matthew Fernandez [Thu, 11 Nov 2021 04:08:22 +0000 (20:08 -0800)]
gmlparse.y: remove unused 'ushort' typedef

3 years agogmlparse.y: use more appropriate stack entry count type
Matthew Fernandez [Thu, 11 Nov 2021 04:05:46 +0000 (20:05 -0800)]
gmlparse.y: use more appropriate stack entry count type

Squashes some -Wsign-conversion warnings.

3 years agofree_graph: squash -Wunused-parameter warnings
Matthew Fernandez [Thu, 11 Nov 2021 03:57:52 +0000 (19:57 -0800)]
free_graph: squash -Wunused-parameter warnings

3 years agofree_edge: squash -Wunused-parameter warnings
Matthew Fernandez [Thu, 11 Nov 2021 03:57:24 +0000 (19:57 -0800)]
free_edge: squash -Wunused-parameter warnings

3 years agofree_node: squash -Wunused-parameter warnings
Matthew Fernandez [Thu, 11 Nov 2021 03:56:57 +0000 (19:56 -0800)]
free_node: squash -Wunused-parameter warnings

3 years agoMerge branch 'smattr/0111593e-6ce0-4cf7-9b22-f4a39a08236d' into 'main'
Matthew Fernandez [Wed, 17 Nov 2021 02:00:31 +0000 (02:00 +0000)]
Merge branch 'smattr/0111593e-6ce0-4cf7-9b22-f4a39a08236d' into 'main'

lib/gvc warning squashing and minor bug fix

See merge request graphviz/graphviz!2277

3 years agoget_int_msb_first: use a C99 bool return type
Matthew Fernandez [Thu, 11 Nov 2021 01:27:29 +0000 (17:27 -0800)]
get_int_msb_first: use a C99 bool return type

3 years agoget_int_lsb_first: use a C99 bool return type
Matthew Fernandez [Thu, 11 Nov 2021 01:27:28 +0000 (17:27 -0800)]
get_int_lsb_first: use a C99 bool return type

3 years agogvusershape.c: remove unnecessary #include
Matthew Fernandez [Thu, 11 Nov 2021 01:27:27 +0000 (17:27 -0800)]
gvusershape.c: remove unnecessary #include

stddef.h is unnecessary if stdlib.h is #included.

3 years agoremove commented out 'tiff_size'
Matthew Fernandez [Thu, 11 Nov 2021 01:27:26 +0000 (17:27 -0800)]
remove commented out 'tiff_size'

3 years agoget_int_msb_first: use a more appropriate type to squash -Wsign-compare warning
Matthew Fernandez [Thu, 11 Nov 2021 01:27:25 +0000 (17:27 -0800)]
get_int_msb_first: use a more appropriate type to squash -Wsign-compare warning

3 years agoget_int_lsb_first: fix undefined behavior in little endian decoding
Matthew Fernandez [Thu, 11 Nov 2021 01:27:25 +0000 (17:27 -0800)]
get_int_lsb_first: fix undefined behavior in little endian decoding

When this function was called with a byte length of 4 (something that happens
often in this file), the last iteration of this loop would shift an int left by
24. On a platform with 32-bit ints (most platforms Graphviz runs on) this shifts
_into_ the sign bit, something that is undefined behavior with respect to the C
standard.

The changes in this commit make the shift well defined and remove a
-Wsign-conversion warning.

3 years agoget_int_lsb_first: use a more appropriate type to squash -Wsign-compare warning
Matthew Fernandez [Thu, 11 Nov 2021 01:27:24 +0000 (17:27 -0800)]
get_int_lsb_first: use a more appropriate type to squash -Wsign-compare warning

3 years agoimagetype: squash -Wsign-compare warning
Matthew Fernandez [Thu, 11 Nov 2021 01:27:23 +0000 (17:27 -0800)]
imagetype: squash -Wsign-compare warning

3 years agogvevent_select_current_obj: remove commented out code
Matthew Fernandez [Thu, 11 Nov 2021 01:27:22 +0000 (17:27 -0800)]
gvevent_select_current_obj: remove commented out code

3 years agogvevent_select_current_obj: squash -Wconversion warnings
Matthew Fernandez [Thu, 11 Nov 2021 01:27:22 +0000 (17:27 -0800)]
gvevent_select_current_obj: squash -Wconversion warnings

3 years agogvevent_leave_obj: squash -Wconversion warnings
Matthew Fernandez [Thu, 11 Nov 2021 01:27:21 +0000 (17:27 -0800)]
gvevent_leave_obj: squash -Wconversion warnings

3 years agogvprintf: squash some -Wsign-conversion warnings
Matthew Fernandez [Thu, 11 Nov 2021 01:27:20 +0000 (17:27 -0800)]
gvprintf: squash some -Wsign-conversion warnings

`len` is known to be non-zero in this code path, so these casts are safe.

3 years agogvwrite: use more conforming type when calling 'deflate'
Matthew Fernandez [Thu, 11 Nov 2021 01:27:19 +0000 (17:27 -0800)]
gvwrite: use more conforming type when calling 'deflate'

This is what the zlib API documents `deflate` as returning. Squashes a
-Wsign-conversion warning.

3 years agoz_file_header: use an unsigned element type and mark 'const'
Matthew Fernandez [Thu, 11 Nov 2021 01:27:18 +0000 (17:27 -0800)]
z_file_header: use an unsigned element type and mark 'const'

Squashes a -Wconversion compiler warnings and this data is never modified.

3 years agogvwrite_no_z: avoid assumptions on input data type
Matthew Fernandez [Thu, 11 Nov 2021 01:27:16 +0000 (17:27 -0800)]
gvwrite_no_z: avoid assumptions on input data type

This is consistent with how `s` is used agnostic to its type within this
function. This helps us remove some casts and do some upcoming simplification.

3 years agoMerge branch 'smattr/2E26CA6A-60DD-401E-AF6A-A5821A9115F7' into 'main'
Matthew Fernandez [Tue, 16 Nov 2021 15:51:51 +0000 (15:51 +0000)]
Merge branch 'smattr/2E26CA6A-60DD-401E-AF6A-A5821A9115F7' into 'main'

smyrna: more clean up

See merge request graphviz/graphviz!2276

3 years agosmyrna: consistent use of 'static' on 'get_temp_coords'
Matthew Fernandez [Wed, 10 Nov 2021 15:22:29 +0000 (07:22 -0800)]
smyrna: consistent use of 'static' on 'get_temp_coords'

This function was already declared static earlier in its containing file, but it
is clearer if all mentions of it are marked `static`.

3 years agodrawTessPolygon: remove unused return value
Matthew Fernandez [Wed, 10 Nov 2021 15:22:08 +0000 (07:22 -0800)]
drawTessPolygon: remove unused return value

3 years agosmyrnaPath: remove use of int-as-size_t
Matthew Fernandez [Wed, 10 Nov 2021 15:21:50 +0000 (07:21 -0800)]
smyrnaPath: remove use of int-as-size_t

3 years agosmyrna: make 'smyrnaGlade' static
Matthew Fernandez [Wed, 10 Nov 2021 15:21:25 +0000 (07:21 -0800)]
smyrna: make 'smyrnaGlade' static

This variable is not used outside of its containing file.

3 years agosmyrna: remove unused 'on_attrApplyAllBtn_clicked'
Matthew Fernandez [Wed, 10 Nov 2021 15:20:59 +0000 (07:20 -0800)]
smyrna: remove unused 'on_attrApplyAllBtn_clicked'

3 years agosmyrna: remove unused 'print_attr_list'
Matthew Fernandez [Wed, 10 Nov 2021 15:20:41 +0000 (07:20 -0800)]
smyrna: remove unused 'print_attr_list'

3 years agosmyrna: make 'free_attr_list' static
Matthew Fernandez [Wed, 10 Nov 2021 15:19:44 +0000 (07:19 -0800)]
smyrna: make 'free_attr_list' static

This function is not used outside of its containing file.

3 years agosmyrna: make 'attr_list_add' static
Matthew Fernandez [Wed, 10 Nov 2021 15:20:20 +0000 (07:20 -0800)]
smyrna: make 'attr_list_add' static

This function is not used outside of its containing file.

3 years agosmyrna: make 'new_attr' static
Matthew Fernandez [Wed, 10 Nov 2021 15:19:23 +0000 (07:19 -0800)]
smyrna: make 'new_attr' static

This function is not used outside of its containing file.

3 years agosmyrna: make 'free_attr' static
Matthew Fernandez [Wed, 10 Nov 2021 15:18:59 +0000 (07:18 -0800)]
smyrna: make 'free_attr' static

This function is not used outside of its containing file.

3 years agosmyrna: fix comment typos
Matthew Fernandez [Wed, 10 Nov 2021 15:18:47 +0000 (07:18 -0800)]
smyrna: fix comment typos

3 years agosmyrna: remove C++ 'extern "C"' guards
Matthew Fernandez [Wed, 10 Nov 2021 15:18:02 +0000 (07:18 -0800)]
smyrna: remove C++ 'extern "C"' guards

Smyrna is written entirely in C, so these guards are unused.

3 years agoMerge branch 'smattr/c9c2aa68-dc61-4ae6-877e-e332899e1938' into 'main'
Matthew Fernandez [Mon, 15 Nov 2021 16:53:59 +0000 (16:53 +0000)]
Merge branch 'smattr/c9c2aa68-dc61-4ae6-877e-e332899e1938' into 'main'

plugin/core related warning squashing

See merge request graphviz/graphviz!2282

3 years agomp_end_edge: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:51:50 +0000 (17:51 -0800)]
mp_end_edge: squash -Wunused-parameter warning

3 years agomp_begin_edge: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:51:37 +0000 (17:51 -0800)]
mp_begin_edge: squash -Wunused-parameter warning

3 years agomp_end_node: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:51:22 +0000 (17:51 -0800)]
mp_end_node: squash -Wunused-parameter warning

3 years agomp_begin_node: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:51:06 +0000 (17:51 -0800)]
mp_begin_node: squash -Wunused-parameter warning

3 years agomp_begin_page: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:50:51 +0000 (17:50 -0800)]
mp_begin_page: squash -Wunused-parameter warning

3 years agofig_end_edge: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:46:16 +0000 (17:46 -0800)]
fig_end_edge: squash -Wunused-parameter warning

3 years agofig_begin_edge: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:46:05 +0000 (17:46 -0800)]
fig_begin_edge: squash -Wunused-parameter warning

3 years agofig_end_node: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:45:49 +0000 (17:45 -0800)]
fig_end_node: squash -Wunused-parameter warning

3 years agofig_begin_node: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:45:33 +0000 (17:45 -0800)]
fig_begin_node: squash -Wunused-parameter warning

3 years agofig_begin_page: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:45:18 +0000 (17:45 -0800)]
fig_begin_page: squash -Wunused-parameter warning

3 years agocore_loadimage_xdot: squash -Wunused-parameter warning
Matthew Fernandez [Sat, 13 Nov 2021 01:43:52 +0000 (17:43 -0800)]
core_loadimage_xdot: squash -Wunused-parameter warning

3 years agoxdot_gradient_fillcolor: use double instead of float for 'r1', 'r2'
Matthew Fernandez [Sat, 13 Nov 2021 01:35:31 +0000 (17:35 -0800)]
xdot_gradient_fillcolor: use double instead of float for 'r1', 'r2'

Squashes a number of -Wfloat-conversion warnings.

3 years agoxdot_gradient_fillcolor: remove dead store to 'r1'
Matthew Fernandez [Sat, 13 Nov 2021 01:32:47 +0000 (17:32 -0800)]
xdot_gradient_fillcolor: remove dead store to 'r1'

This variable is overwritten on line 648 without having been read in between.
This code appears copy-pasted from `cairo_gradient_fill` without noticing that
this line is unused here.

3 years agoget_gradient_points: take 'angle' as a double instead of a float
Matthew Fernandez [Sat, 13 Nov 2021 01:29:12 +0000 (17:29 -0800)]
get_gradient_points: take 'angle' as a double instead of a float

The originating values used to compute an angle were generally doubles and
computation was done in `get_gradient_points` as if this value was a double
(e.g. calling `sin` and `cos`). Treating it consistently as a double squashes a
number of -Wfloat-conversion compiler warnings and improves precision.

3 years agodot_end_graph: squash -Wswitch-default warning
Matthew Fernandez [Sat, 13 Nov 2021 01:21:33 +0000 (17:21 -0800)]
dot_end_graph: squash -Wswitch-default warning

3 years agodot_begin_graph: squash -Wswitch-default warning
Matthew Fernandez [Sat, 13 Nov 2021 01:20:19 +0000 (17:20 -0800)]
dot_begin_graph: squash -Wswitch-default warning

3 years agowrite_plain: take a C99 bool for 'extend' parameter
Matthew Fernandez [Sat, 13 Nov 2021 01:18:06 +0000 (17:18 -0800)]
write_plain: take a C99 bool for 'extend' parameter

3 years agoMerge branch 'smattr/72003c76-27a7-431f-95d7-c69e57514be2' into 'main'
Matthew Fernandez [Sun, 14 Nov 2021 22:58:18 +0000 (22:58 +0000)]
Merge branch 'smattr/72003c76-27a7-431f-95d7-c69e57514be2' into 'main'

lib/common: more warning squashing

See merge request graphviz/graphviz!2273

3 years agofreeMPair: squash -Wunused-parameter warning
Matthew Fernandez [Tue, 9 Nov 2021 02:53:31 +0000 (18:53 -0800)]
freeMPair: squash -Wunused-parameter warning

3 years agomkMPair: squash -Wunused-parameter warning
Matthew Fernandez [Tue, 9 Nov 2021 02:53:15 +0000 (18:53 -0800)]
mkMPair: squash -Wunused-parameter warning

3 years agocmppair: squash -Wunused-parameter warnings
Matthew Fernandez [Tue, 9 Nov 2021 02:51:18 +0000 (18:51 -0800)]
cmppair: squash -Wunused-parameter warnings

3 years agofreePair: squash -Wunused-parameter warnings
Matthew Fernandez [Tue, 9 Nov 2021 02:51:05 +0000 (18:51 -0800)]
freePair: squash -Wunused-parameter warnings

3 years agoestimate_character_width_canonical: squash a -Wsign-conversion warning
Matthew Fernandez [Tue, 9 Nov 2021 02:46:54 +0000 (18:46 -0800)]
estimate_character_width_canonical: squash a -Wsign-conversion warning

3 years agofont_in_list_permissive: squash -Wsign-conversion warning
Matthew Fernandez [Tue, 9 Nov 2021 02:45:41 +0000 (18:45 -0800)]
font_in_list_permissive: squash -Wsign-conversion warning

The preceding logic guarantees this value will be non-negative.

3 years agoall_font_metrics_len: squash -Wold-style-declaration warning
Matthew Fernandez [Tue, 9 Nov 2021 02:44:09 +0000 (18:44 -0800)]
all_font_metrics_len: squash -Wold-style-declaration warning

3 years agotextfont_comparf: squash -Wunused-parameter warnings
Matthew Fernandez [Tue, 9 Nov 2021 02:43:07 +0000 (18:43 -0800)]
textfont_comparf: squash -Wunused-parameter warnings

3 years agotextfont_freef: squash -Wunused-parameter warnings
Matthew Fernandez [Tue, 9 Nov 2021 02:42:54 +0000 (18:42 -0800)]
textfont_freef: squash -Wunused-parameter warnings

3 years agotextfont_makef: squash -Wunused-parameter warnings
Matthew Fernandez [Tue, 9 Nov 2021 02:42:39 +0000 (18:42 -0800)]
textfont_makef: squash -Wunused-parameter warnings

3 years agohsv2rgb: squash a -Wswitch-default warning
Matthew Fernandez [Tue, 9 Nov 2021 02:39:09 +0000 (18:39 -0800)]
hsv2rgb: squash a -Wswitch-default warning

The preceding logic makes the rest of the switch exhaustive.

3 years agogvrender_beziercurve: realign 'filled' parameter type
Matthew Fernandez [Tue, 9 Nov 2021 02:33:49 +0000 (18:33 -0800)]
gvrender_beziercurve: realign 'filled' parameter type

This appears to have been a mistake, in that all the other `gvrender_*`
functions take an `int` for the `filled` parameter. This does not appear to have
caused any visible effects, as the values passed to this function always fit in
a `boolean`. But the compiler complained that it thought unintended value
truncation was occurring.

Squashes 3 -Wconversion compiler warnings.

3 years agoMerge branch 'smattr/4AE39E22-FD66-458A-81E4-F54395DA6F4D' into 'main'
Matthew Fernandez [Sun, 14 Nov 2021 21:08:00 +0000 (21:08 +0000)]
Merge branch 'smattr/4AE39E22-FD66-458A-81E4-F54395DA6F4D' into 'main'

remove 'real' and 'REAL' abstractions

See merge request graphviz/graphviz!2274

3 years agogvmap: remove unused 'REAL' definitions
Matthew Fernandez [Wed, 10 Nov 2021 02:31:44 +0000 (18:31 -0800)]
gvmap: remove unused 'REAL' definitions

3 years agoremove 'real' abstraction
Matthew Fernandez [Wed, 10 Nov 2021 02:28:51 +0000 (18:28 -0800)]
remove 'real' abstraction

This was not configurable and always mapped to the type `double`. There were
also implicit assumptions that `real` and `double` were interchangeable. This
alias is removed to avoid future confusion.

The diff appears large, but it is just removing two #defines of `real` and
propagating their definition (`double`) to all usage sites.

3 years agoMerge branch 'smattr/D885CA52-BAA6-4360-A822-28B64F491590' into 'main'
Matthew Fernandez [Sun, 14 Nov 2021 20:01:00 +0000 (20:01 +0000)]
Merge branch 'smattr/D885CA52-BAA6-4360-A822-28B64F491590' into 'main'

fix assertion typo that overwrote matrix value type and stop disabling assertions

See merge request graphviz/graphviz!2275

3 years agogeneral.h: stop disabling assertions when 'DEBUG' is undefined
Matthew Fernandez [Wed, 10 Nov 2021 01:49:41 +0000 (17:49 -0800)]
general.h: stop disabling assertions when 'DEBUG' is undefined

The effect of this code was that #including general.h prior to assert.h would
disable assertions in your code. Not #including general.h or #including it after
assert.h would allow assertions to be controlled through the standard `NDEBUG`
mechanism. It is not clear why suppressing assertions like this was ever
desirable.

This is basically another variant of commit
68bcbbd4ddef4960c7ea6884dda10854b0e012e0.

3 years agojacobi: fix assertion typo that overwrote matrix value type
Matthew Fernandez [Wed, 10 Nov 2021 02:37:55 +0000 (18:37 -0800)]
jacobi: fix assertion typo that overwrote matrix value type

Comparing to the surrounding functions in this file, this was clearly meant to
be checking the type of the matrix not setting it. This was benign as, due to a
separate problem, assertions are disabled in this file, making this a no-op. The
next commit will re-enable assertions, which caused this issue to be discovered
through a compiler error.