Tom Lane [Wed, 4 Oct 2006 22:31:14 +0000 (22:31 +0000)]
Adjust configure's handling of libedit to not look for a history.h file.
Per Bob Friesenhahn's report, this file is not supplied by some versions
of libedit, and even when it is supplied it seems to be just a link to
readline.h, so we don't need to include it anyway.
Also, ensure that we won't try to use a too-old version of Bison.
The previous coding would bleat but then use it anyway; better to invoke
the 'missing' script if any grammar files need to be rebuilt.
Tom Lane [Wed, 4 Oct 2006 18:58:08 +0000 (18:58 +0000)]
Fix initdb's logic for picking shared_buffers/max_fsm_pages, which had
gotten rather thoroughly whacked out by careless recent changes: the
intended ratio between the two was off by a lot, and the minimum number
of shared buffers tried had increased by a lot. Problem exposed by
failures on buildfarm members with smaller SHMMAX values.
Tom Lane [Wed, 4 Oct 2006 17:52:52 +0000 (17:52 +0000)]
Improve error messages from to_tsquery per yesterday's discussion:
provide the bad input, and be sure to mention that we are talking about
a tsearch query.
Tom Lane [Tue, 3 Oct 2006 22:18:23 +0000 (22:18 +0000)]
Switch over to using our own qsort() all the time, as has been proposed
repeatedly. Now that we don't have to worry about memory leaks from
glibc's qsort, we can safely put CHECK_FOR_INTERRUPTS into the tuplesort
comparators, as was requested a couple months ago. Also, get rid of
non-reentrancy and an extra level of function call in tuplesort.c by
providing a variant qsort_arg() API that passes an extra void * argument
through to the comparison routine. (We might want to use that in other
places too, I didn't look yet.)
Bruce Momjian [Tue, 3 Oct 2006 22:12:14 +0000 (22:12 +0000)]
pgevent fixes:
1) Make vcbuild actually build the pgevent dll.
2) Change the pgevent DLL file so it doens't specify ordinal for the
functions. You're not supposed to do that. You're actually supposed to
declare them as PRIVATE as well, but mingw doesn't support that. VC++
will throw a warning and not an error though, so we can live with it.
Tom Lane [Sun, 1 Oct 2006 22:25:48 +0000 (22:25 +0000)]
Make some marginal performance improvements in reportErrorPosition(),
which turns out to be a dominant part of the runtime in scenarios
involving lots of parse-time warnings (such as Stephen Frost's example
of an INSERT with a lot of backslash-containing strings). There's not
a whole lot we can do about the character-at-a-time scanning, but we
can at least avoid traversing the query twice.
Tom Lane [Sun, 1 Oct 2006 22:08:18 +0000 (22:08 +0000)]
Do a CHECK_FOR_INTERRUPTS after emitting a message of less than ERROR
severity. This is to ensure the user can cancel a query that's spitting
out lots of notice/warning messages, even if they're coming from a loop
that doesn't otherwise contain a CHECK_FOR_INTERRUPTS. Per gripe from
Stephen Frost.
Tom Lane [Sun, 1 Oct 2006 18:37:53 +0000 (18:37 +0000)]
Remove accented characters in comments, to avoid failures when this
file is read with an incompatible client_encoding setting. Per report
from Tim N. van der Leeuw.
Tom Lane [Sun, 1 Oct 2006 17:23:38 +0000 (17:23 +0000)]
Fix overly enthusiastic Assert introduced in 8.1: it's expecting a
CaseTestExpr, but forgot that the optimizer is sometimes able to replace
CaseTestExpr by Const.
Bruce Momjian [Sat, 30 Sep 2006 03:55:32 +0000 (03:55 +0000)]
Add:
> * Allow more complex user/database default GUC settings
> Currently, ALTER USER and ALTER DATABASE support per-user and
> per-database defaults. Consider adding per-user-and-database
> defaults so things like search_path can be defaulted for a
> specific user connecting to a specific database.
>
>
Tom Lane [Fri, 29 Sep 2006 21:22:21 +0000 (21:22 +0000)]
Allow assignment to array elements not contiguous with those already
present; intervening positions are filled with nulls. This behavior
is required by SQL99 but was not implementable before 8.2 due to lack
of support for nulls in arrays. I have only made it work for the
one-dimensional case, which is all that SQL99 requires. It seems quite
complex to get it right in higher dimensions, and since we never allowed
extension at all in higher dimensions, I think that must count as a
future feature addition not a bug fix.
Tom Lane [Thu, 28 Sep 2006 20:51:43 +0000 (20:51 +0000)]
Fix IS NULL and IS NOT NULL tests on row-valued expressions to conform to
the SQL spec, viz IS NULL is true if all the row's fields are null, IS NOT
NULL is true if all the row's fields are not null. The former coding got
this right for a limited number of cases with IS NULL (ie, those where it
could disassemble a ROW constructor at parse time), but was entirely wrong
for IS NOT NULL. Per report from Teodor.
I desisted from changing the behavior for arrays, since on closer inspection
it's not clear that there's any support for that in the SQL spec. This
probably needs more consideration.
Tom Lane [Wed, 27 Sep 2006 18:40:10 +0000 (18:40 +0000)]
Replace strncpy with strlcpy in selected places that seem possibly relevant
to performance. (A wholesale effort to get rid of strncpy should be
undertaken sometime, but not during beta.) This commit also fixes dynahash.c
to correctly truncate overlength string keys for hashtables, so that its
callers don't have to anymore.
Tom Lane [Wed, 27 Sep 2006 16:29:46 +0000 (16:29 +0000)]
Add strlcpy() to the set of functions supported by src/port/ when not
available directly on the platform. Per discussion, this function is
sufficiently widely recognized to be treated as standard.
Bruce Momjian [Tue, 26 Sep 2006 11:18:29 +0000 (11:18 +0000)]
Done:
< o Add command to archive partially filled write-ahead logs? [pitr]
<
< Currently only full WAL files are archived. This means that the
< most recent transactions aren't available for recovery in case
< of a disk failure.
<
Reorder:
< o %Create dump tool for write-ahead logs for use in determining
< transaction id for point-in-time recovery
> o %Create dump tool for write-ahead logs for use in determining
> transaction id for point-in-time recovery
Tom Lane [Mon, 25 Sep 2006 22:01:10 +0000 (22:01 +0000)]
Add a check to prevent overwriting valid data if smgrnblocks() gives a
wrong answer, as has been seen to occur with a buggy Linux kernel. Not
really our bug, but it's a simple test in a seldom-used control path,
so might as well have a defense.
Tom Lane [Sun, 24 Sep 2006 17:10:18 +0000 (17:10 +0000)]
Cause pg_regress to invoke the temporary postmaster as 'postgres' not
'postmaster', so as not to depend on the existence of the postmaster
symlink. Also, implement postmaster-still-alive and postmaster-kill
operations for Windows, per Magnus.
Tom Lane [Fri, 22 Sep 2006 23:20:14 +0000 (23:20 +0000)]
Fix pg_locks view to call advisory locks advisory locks, while preserving
backward compatibility for anyone using the old userlock code that's now
on pgfoundry --- locks from that code still show as 'userlock'.
Tom Lane [Fri, 22 Sep 2006 21:39:58 +0000 (21:39 +0000)]
Fix bugs in plpgsql and ecpg caused by assuming that isspace() would only
return true for exactly the characters treated as whitespace by their flex
scanners. Per report from Victor Snezhko and subsequent investigation.
Also fix a passel of unsafe usages of <ctype.h> functions, that is, ye olde
char-vs-unsigned-char issue. I won't miss <ctype.h> when we are finally
able to stop using it.
Peter Eisentraut [Fri, 22 Sep 2006 18:50:41 +0000 (18:50 +0000)]
Rearrange yes/no prompting code so that the prompts always show the
(possibly (un)translated) letters that are actually expected as input.
Also reject invalid responses instead of silenty taken them as "no".
Peter Eisentraut [Fri, 22 Sep 2006 17:41:21 +0000 (17:41 +0000)]
Add units to the default postgresql.conf. For the most part, this should
match what SHOW displays as default value, to make the user experience
uniform.
Tom Lane [Fri, 22 Sep 2006 16:20:00 +0000 (16:20 +0000)]
Update timezone documentation to reflect current reality: instead of
giving tables of known timezone names, refer the user to the system views.
Joachim Wieland
Tom Lane [Fri, 22 Sep 2006 15:29:04 +0000 (15:29 +0000)]
We're going to have to spell dotless i as plain i, because dotless i is
not in the character set supported by DocBook nor standard HTML. (Sorry
Volkan.) Also replace random character-set references by a pointer to
the actual standard.
Tom Lane [Thu, 21 Sep 2006 20:31:22 +0000 (20:31 +0000)]
Fix free space map to correctly track the total amount of FSM space needed
even when a single relation requires more than max_fsm_pages pages. Also,
make VACUUM emit a warning in this case, since it likely means that VACUUM
FULL or other drastic corrective measure is needed. Per reports from Jeff
Frost and others of unexpected changes in the claimed max_fsm_pages need.