]> granicus.if.org Git - postgresql/log
postgresql
21 years agoAdd positive defense against dropped columns, per suggestion from
Tom Lane [Wed, 24 Sep 2003 05:38:38 +0000 (05:38 +0000)]
Add positive defense against dropped columns, per suggestion from
Christopher Kings-Lynne.  Also fix a couple more schema-awareness issues.

21 years agoIssue CREATE SCHEMA as the originally connecting user, with an
Tom Lane [Tue, 23 Sep 2003 23:31:52 +0000 (23:31 +0000)]
Issue CREATE SCHEMA as the originally connecting user, with an
AUTHORIZATION clause to specify the desired owner.  This allows a
superuser to restore schemas owned by users without CREATE-SCHEMA
permissions (ie, schemas originally created by a superuser using
AUTHORIZATION).  --no-owner can be specified to suppress the
AUTHORIZATION clause if need be.

21 years agopg_dump/pg_restore now always use SET SESSION AUTHORIZATION, not \connect,
Tom Lane [Tue, 23 Sep 2003 22:48:53 +0000 (22:48 +0000)]
pg_dump/pg_restore now always use SET SESSION AUTHORIZATION, not \connect,
to control object ownership.  The use-set-session-authorization and
no-reconnect switches are obsolete (still accepted on the command line,
but they don't do anything).  This is a precursor to fixing handling
of CREATE SCHEMA, which will be a separate commit.

21 years agoAdd:
Bruce Momjian [Tue, 23 Sep 2003 21:00:18 +0000 (21:00 +0000)]
Add:

> * Allow LISTEN/NOTIFY to store info in memory rather than tables

21 years agoAdd:
Bruce Momjian [Tue, 23 Sep 2003 20:45:58 +0000 (20:45 +0000)]
Add:

* Allow major upgrades without dump/reload, perhaps using pg_upgrade

21 years agoMinor copy-editing for plpgsql chapter.
Tom Lane [Tue, 23 Sep 2003 19:58:50 +0000 (19:58 +0000)]
Minor copy-editing for plpgsql chapter.

21 years agoTweak generic_type_consistency routines to avoid loss of functionality
Tom Lane [Tue, 23 Sep 2003 17:12:53 +0000 (17:12 +0000)]
Tweak generic_type_consistency routines to avoid loss of functionality
since 7.3: 'select array_dims(histogram_bounds) from pg_stats' used to
work and still should.  Problem was that code wouldn't take input of
declared type anyarray as matching an anyarray argument.  Allow this
case as long as we don't need to determine an element type (which in
practice means as long as anyelement isn't used in the function signature).

21 years ago_SPI_cursor_operation forgot to check for failure return from
Tom Lane [Tue, 23 Sep 2003 15:11:33 +0000 (15:11 +0000)]
_SPI_cursor_operation forgot to check for failure return from
_SPI_begin_call.  Per gripe from Tomasz Myrta.

21 years ago- Changed struct definition handling so "struct foo {}" always gets defined.
Michael Meskes [Tue, 23 Sep 2003 12:56:35 +0000 (12:56 +0000)]
- Changed struct definition handling so "struct foo {}" always gets defined.

21 years agoFix to properly handle timezone offsets that are partial hours. If the offset
Barry Lind [Tue, 23 Sep 2003 06:13:52 +0000 (06:13 +0000)]
Fix to properly handle timezone offsets that are partial hours.  If the offset
was a partial hour and less than gmt (i.e. -02:30) the code would corrupt the
minutes part.

 Modified Files:
  jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java

21 years agoA fix for jdbc regression test submitted yesterday by Kim Ho at Redhat
Barry Lind [Tue, 23 Sep 2003 06:11:06 +0000 (06:11 +0000)]
A fix for jdbc regression test submitted yesterday by Kim Ho at Redhat

 Modified Files:
  ResultSetTest.java

21 years agoPutting back the previous change must be the first thing.
Hiroshi Inoue [Tue, 23 Sep 2003 01:51:09 +0000 (01:51 +0000)]
Putting back the previous change must be the first thing.
ALso put back a #ifndef ENABLE_REINDEX_NAILED_RELATIONS
which was removed about a year ago.

21 years agofix hlfinditem function. Thanks to "Stphane Bidoul" <stephane.bidoul@softwareag.com>.
Teodor Sigaev [Mon, 22 Sep 2003 13:32:33 +0000 (13:32 +0000)]
fix hlfinditem function. Thanks to "Stphane Bidoul" <stephane.bidoul@softwareag.com>.

The 'word' variable there is initialised from
the prs->words array, but immediately after,
that array may be reallocated, thus leaving
word pointing to unallocated memory.

21 years ago- Fixed order mismatch in processing "using" arguments.
Michael Meskes [Mon, 22 Sep 2003 13:19:39 +0000 (13:19 +0000)]
- Fixed order mismatch in processing "using" arguments.
- Fixed some minor things in test cases.
- Use defines for Informix error codes.

21 years agoAdditional jdbc regression tests submitted by Oliver Jowett. Some tests are
Barry Lind [Mon, 22 Sep 2003 05:38:01 +0000 (05:38 +0000)]
Additional jdbc regression tests submitted by Oliver Jowett.  Some tests are
currently commented out, pending fixes for the bugs these tests uncovered.

 Modified Files:
  jdbc/org/postgresql/test/jdbc2/Jdbc2TestSuite.java
  jdbc/org/postgresql/test/jdbc2/ServerPreparedStmtTest.java
 Added Files:
  jdbc/org/postgresql/test/jdbc2/CursorFetchTest.java

21 years agoApplied jdbc patch from Kim Ho at RedHat to improve boolean support, as well
Barry Lind [Mon, 22 Sep 2003 04:55:00 +0000 (04:55 +0000)]
Applied jdbc patch from Kim Ho at RedHat to improve boolean support, as well
as some additional regression tests for this an other recent changes.

 Modified Files:
  jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
  jdbc/org/postgresql/test/jdbc2/DateTest.java
  jdbc/org/postgresql/test/jdbc2/ResultSetTest.java
  jdbc/org/postgresql/test/jdbc2/TimeTest.java
  jdbc/org/postgresql/test/jdbc2/TimestampTest.java

21 years agoHeapTupleSatisfiesVacuum() needs to be more careful about the
Tom Lane [Mon, 22 Sep 2003 00:47:23 +0000 (00:47 +0000)]
HeapTupleSatisfiesVacuum() needs to be more careful about the
difference between INSERT_IN_PROGRESS and DELETE_IN_PROGRESS for
tuples inserted and then deleted by a concurrent transaction.
Example of bug:
regression=# create table foo (f1 int);
CREATE TABLE
regression=# begin;
BEGIN
regression=# insert into foo values(1);
INSERT 195531 1
regression=# delete from foo;
DELETE 1
regression=# insert into foo values(1);
INSERT 195532 1
regression=# create unique index fooi on foo(f1);
ERROR:  could not create unique index
DETAIL:  Table contains duplicated values.

21 years agoTranslation updates
Peter Eisentraut [Mon, 22 Sep 2003 00:27:01 +0000 (00:27 +0000)]
Translation updates

21 years agoMessage wording improvements
Peter Eisentraut [Mon, 22 Sep 2003 00:23:35 +0000 (00:23 +0000)]
Message wording improvements

21 years agoMake the SQL command synopses appear less random.
Peter Eisentraut [Mon, 22 Sep 2003 00:16:58 +0000 (00:16 +0000)]
Make the SQL command synopses appear less random.

21 years agoArrange to align shared disk buffers on at least 32-byte boundaries,
Tom Lane [Sun, 21 Sep 2003 17:57:21 +0000 (17:57 +0000)]
Arrange to align shared disk buffers on at least 32-byte boundaries,
not just MAXALIGN boundaries.  This makes a noticeable difference in
the speed of transfers to and from kernel space, at least on recent
Pentiums, and might help other CPUs too.  We should look at making
this happen for local buffers and buffile.c too.  Patch from Manfred Spraul.

21 years agoFix some ill-considered ifdefs, per report from Hans-JÏrgen SchÎnig.
Tom Lane [Sun, 21 Sep 2003 17:42:22 +0000 (17:42 +0000)]
Fix some ill-considered ifdefs, per report from Hans-JÏrgen SchÎnig.

21 years agoApply ranlib(1) after installing a static (.a) library on Darwin.
Tom Lane [Sat, 20 Sep 2003 21:26:20 +0000 (21:26 +0000)]
Apply ranlib(1) after installing a static (.a) library on Darwin.
Per past complaints --- verified to still be a problem on OS X 10.2.6.

21 years agoAttaching -lpq to LDFLAGS doesn't work, because the generated command
Tom Lane [Sat, 20 Sep 2003 21:14:57 +0000 (21:14 +0000)]
Attaching -lpq to LDFLAGS doesn't work, because the generated command
puts that before the .c file name.

21 years agoFix a batch of speling misteaks identified by Peter's spell-checker tool.
Tom Lane [Sat, 20 Sep 2003 20:12:05 +0000 (20:12 +0000)]
Fix a batch of speling misteaks identified by Peter's spell-checker tool.

21 years ago- Renamed my own strndup() function because of a name clash.
Michael Meskes [Sat, 20 Sep 2003 09:10:50 +0000 (09:10 +0000)]
- Renamed my own strndup() function because of a name clash.

21 years ago- Applied some bug fixing patches by Dave Cramer <dave@fastcrypt.com>.
Michael Meskes [Sat, 20 Sep 2003 09:10:09 +0000 (09:10 +0000)]
- Applied some bug fixing patches by Dave Cramer <dave@fastcrypt.com>.
- Added protecting defines to include files.

21 years agopg_dump missed comments attached to primary key or unique constraints
Tom Lane [Fri, 19 Sep 2003 23:15:18 +0000 (23:15 +0000)]
pg_dump missed comments attached to primary key or unique constraints
(as distinct from their underlying indexes).  Per bug report from
Hiroshi Saito.

21 years agoDocument that TRUNCATE ignores user-defined ON DELETE triggers.
Tom Lane [Fri, 19 Sep 2003 21:06:39 +0000 (21:06 +0000)]
Document that TRUNCATE ignores user-defined ON DELETE triggers.

21 years agoDisallow foreign-key references from temp tables to permanent tables.
Tom Lane [Fri, 19 Sep 2003 21:04:20 +0000 (21:04 +0000)]
Disallow foreign-key references from temp tables to permanent tables.
Per recent discussion, this does not work because other backends can't
reliably see tuples in a temp table and so cannot run the RI checks
correctly.  Seems better to disallow this case than go back to accessing
temp tables through shared buffers.  Also, disallow FK references to
ON COMMIT DELETE ROWS tables.  We already caught this problem for normal
TRUNCATE, but the path used by ON COMMIT didn't check.

21 years agoLatest version of gcc from Apple does not work well with -traditional-cpp
Tom Lane [Fri, 19 Sep 2003 20:47:59 +0000 (20:47 +0000)]
Latest version of gcc from Apple does not work well with -traditional-cpp
(it rejects some system header files...).  Use -no-cpp-precomp instead.
I think it is okay to change this unconditionally, but if we hear
complaints from people still using very old compilers on Darwin,
we could put in a test to see which switch the compiler likes.

21 years agoSeems like a bad idea that REINDEX TABLE supports (or thinks it does)
Tom Lane [Fri, 19 Sep 2003 19:57:42 +0000 (19:57 +0000)]
Seems like a bad idea that REINDEX TABLE supports (or thinks it does)
reindexing system tables without ignoring system indexes, when the
other two varieties of REINDEX disallow it.  Make all three act the same,
and simplify downstream code accordingly.

21 years agoOne small typo in preprocessor.
Michael Meskes [Fri, 19 Sep 2003 14:13:16 +0000 (14:13 +0000)]
One small typo in preprocessor.

21 years agoRemoved superfluous return statement in get_data.
Michael Meskes [Fri, 19 Sep 2003 14:06:21 +0000 (14:06 +0000)]
Removed superfluous return statement in get_data.

21 years agoPut a tad more detail in the discussion of postmaster and postgres
Tom Lane [Thu, 18 Sep 2003 20:30:15 +0000 (20:30 +0000)]
Put a tad more detail in the discussion of postmaster and postgres
signal handling.

21 years ago- Accept output variables for FETCH in DECLARE statement.
Michael Meskes [Thu, 18 Sep 2003 13:12:23 +0000 (13:12 +0000)]
- Accept output variables for FETCH in DECLARE statement.
- Synced parser.
- Allowed C variables to carry the name of prepared statements.
- Added Informix handling of datatype converion errors.

21 years agoApplied patch from Oliver Jowett to clean up some instances where the wrong
Barry Lind [Thu, 18 Sep 2003 04:14:27 +0000 (04:14 +0000)]
Applied patch from Oliver Jowett to clean up some instances where the wrong
type was being reported for PREPAREs.

 Modified Files:
  jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
  jdbc/org/postgresql/test/jdbc2/ServerPreparedStmtTest.java

21 years agoSmall jdbc patch from Kim Ho at RedHat to fix some boolean problems
Barry Lind [Thu, 18 Sep 2003 04:09:02 +0000 (04:09 +0000)]
Small jdbc patch from Kim Ho at RedHat to fix some boolean problems

 Modified Files:
  jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java

21 years agoA minor fix to jdbc regression tests
Barry Lind [Thu, 18 Sep 2003 03:58:16 +0000 (03:58 +0000)]
A minor fix to jdbc regression tests

 Modified Files:
  jdbc/org/postgresql/test/jdbc2/DatabaseMetaDataPropertiesTest.java

21 years agoDisallow converting a table to a view if it has triggers, indexes, or
Tom Lane [Wed, 17 Sep 2003 17:19:17 +0000 (17:19 +0000)]
Disallow converting a table to a view if it has triggers, indexes, or
child tables --- all cases that will trip various sanity checks elsewhere
in the system, as well as cases that should not occur in the only intended
use of this feature, namely coping with ancient pg_dump representation
of views.  Per bug report from Chris Pizzi.

21 years agoApplied patch to jdbc from Kim Ho at RedHat, fixing improper handling of empty querie...
Barry Lind [Wed, 17 Sep 2003 08:21:36 +0000 (08:21 +0000)]
Applied patch to jdbc from Kim Ho at RedHat, fixing improper handling of empty queries under the V3 protocol

 Modified Files:
  jdbc/org/postgresql/core/QueryExecutor.java

21 years agoApplied patch for jdbc from Kim Ho at RedHat to more correctly deal with boolean...
Barry Lind [Wed, 17 Sep 2003 07:00:24 +0000 (07:00 +0000)]
Applied patch for jdbc from Kim Ho at RedHat to more correctly deal with boolean values

 Modified Files:
  jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java

21 years agoFixed jdbc to correctly report that constraints are supported
Barry Lind [Wed, 17 Sep 2003 06:42:47 +0000 (06:42 +0000)]
Fixed jdbc to correctly report that constraints are supported

 Modified Files:
  jdbc/org/postgresql/jdbc1/AbstractJdbc1DatabaseMetaData.java

21 years agoApplied patch from Fernando Nasser of RedHat to fix some error messages
Barry Lind [Wed, 17 Sep 2003 05:14:52 +0000 (05:14 +0000)]
Applied patch from Fernando Nasser of RedHat to fix some error messages
that would not get correctly looked up in the translation files for jdbc

 Modified Files:
  jdbc/org/postgresql/errors.properties
  jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSet.java

21 years agoApplied patch from Kim Ho at redhat to improve boolean and bit handling
Barry Lind [Wed, 17 Sep 2003 05:07:38 +0000 (05:07 +0000)]
Applied patch from Kim Ho at redhat to improve boolean and bit handling
in the jdbc driver

 Modified Files:
  jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
  jdbc/org/postgresql/jdbc3/AbstractJdbc3Statement.java

21 years agoFix typo in comment
Tatsuo Ishii [Wed, 17 Sep 2003 04:25:29 +0000 (04:25 +0000)]
Fix typo in comment

21 years agoMake psql correctly track the effects of SET CLIENT_ENCODING commands.
Tom Lane [Tue, 16 Sep 2003 17:59:02 +0000 (17:59 +0000)]
Make psql correctly track the effects of SET CLIENT_ENCODING commands.
I thought I'd fixed this earlier, but I didn't get it right ...

21 years agofix typo in a comment
Tatsuo Ishii [Tue, 16 Sep 2003 07:47:06 +0000 (07:47 +0000)]
fix typo in a comment

21 years agoI don't care whether it's informix-compatible or not: #defining a word
Tom Lane [Tue, 16 Sep 2003 04:32:28 +0000 (04:32 +0000)]
I don't care whether it's informix-compatible or not: #defining a word
like 'date' in a public header file is a damn fool idea.

21 years agoFix some problems with dropped columns in plpython trigger functions.
Tom Lane [Tue, 16 Sep 2003 01:07:51 +0000 (01:07 +0000)]
Fix some problems with dropped columns in plpython trigger functions.

21 years agoSince SPI_modifytuple's natts argument is the number of attributes to be
Tom Lane [Tue, 16 Sep 2003 00:50:09 +0000 (00:50 +0000)]
Since SPI_modifytuple's natts argument is the number of attributes to be
changed, it should allow a zero value (implying no changes to make).

21 years agoFix LISTEN/NOTIFY race condition reported by Gavin Sherry. While a
Tom Lane [Mon, 15 Sep 2003 23:33:43 +0000 (23:33 +0000)]
Fix LISTEN/NOTIFY race condition reported by Gavin Sherry.  While a
really general fix might be difficult, I believe the only case where
AtCommit_Notify could see an uncommitted tuple is where the other guy
has just unlistened and not yet committed.  The best solution seems to
be to just skip updating that tuple, on the assumption that the other
guy does not want to hear about the notification anyway.  This is not
perfect --- if the other guy rolls back his unlisten instead of committing,
then he really should have gotten this notify.  But to do that, we'd have
to wait to see if he commits or not, or make UNLISTEN hold exclusive lock
on pg_listener until commit.  Either of these answers is deadlock-prone,
not to mention horrible for interactive performance.  Do it this way
for now.  (What happened to that project to do LISTEN/NOTIFY in memory
with no table, anyway?)

21 years agoUpdate regression test for message change.
Tom Lane [Mon, 15 Sep 2003 23:25:31 +0000 (23:25 +0000)]
Update regression test for message change.

21 years agoImprove a couple of error messages per suggestions from Alvaro Herrera.
Tom Lane [Mon, 15 Sep 2003 22:28:58 +0000 (22:28 +0000)]
Improve a couple of error messages per suggestions from Alvaro Herrera.

21 years agoTranslation updates
Peter Eisentraut [Mon, 15 Sep 2003 20:42:40 +0000 (20:42 +0000)]
Translation updates

21 years agoOK, some of these syntax errors should be given other codes.
Peter Eisentraut [Mon, 15 Sep 2003 20:03:37 +0000 (20:03 +0000)]
OK, some of these syntax errors should be given other codes.

21 years agotag her for beta3, as announced on Friday ... REL7_4_BETA3
PostgreSQL Daemon [Mon, 15 Sep 2003 14:32:35 +0000 (14:32 +0000)]
tag her for beta3, as announced on Friday  ...

21 years agoOkay, who left off the id= here?
Tom Lane [Mon, 15 Sep 2003 03:32:24 +0000 (03:32 +0000)]
Okay, who left off the id= here?

21 years agoLISTEN doesn't issue a warning for redundant listens anymore. Also,
Tom Lane [Mon, 15 Sep 2003 03:21:51 +0000 (03:21 +0000)]
LISTEN doesn't issue a warning for redundant listens anymore.  Also,
add some 'See Also' links.

21 years agoAdd errno value for thread *_r function call buffer too small. Improve
Bruce Momjian [Mon, 15 Sep 2003 02:30:29 +0000 (02:30 +0000)]
Add errno value for thread *_r function call buffer too small.  Improve
thread comments.

21 years agoNetBSD needs reentrant funcs.
Bruce Momjian [Mon, 15 Sep 2003 02:17:49 +0000 (02:17 +0000)]
NetBSD needs reentrant funcs.

21 years agoRemove warnings for operations that have no effect when executed repeatedly.
Peter Eisentraut [Mon, 15 Sep 2003 00:26:31 +0000 (00:26 +0000)]
Remove warnings for operations that have no effect when executed repeatedly.

21 years agoRun distprep target before creating list of files that contain translatable
Peter Eisentraut [Sun, 14 Sep 2003 22:40:38 +0000 (22:40 +0000)]
Run distprep target before creating list of files that contain translatable
strings in the backend, so that .l and .y files are included.  To that end,
don't make the .pot file a prerequisite on distprep.

21 years agoAllow translation of SQL help in psql.
Peter Eisentraut [Sun, 14 Sep 2003 22:37:13 +0000 (22:37 +0000)]
Allow translation of SQL help in psql.

21 years agoAdd missing support for Opteron (__x86_64__).
Tom Lane [Sun, 14 Sep 2003 20:21:18 +0000 (20:21 +0000)]
Add missing support for Opteron (__x86_64__).

21 years agoPersuade tsearch/tsearch2 to work (or at least pass their regression
Tom Lane [Sun, 14 Sep 2003 18:44:23 +0000 (18:44 +0000)]
Persuade tsearch/tsearch2 to work (or at least pass their regression
tests) when using flex 2.5.31.  The fix is to *not* try to use palloc
and pfree for allocations within the lexer; when you do that, the
yy_buffer_stack gets freed at inopportune times.  The code is already
set up to do manual deallocation, so I see no particular advantage to
using palloc anyway.

21 years agoMake pltcl create separate function objects when the same function is
Tom Lane [Sun, 14 Sep 2003 17:25:54 +0000 (17:25 +0000)]
Make pltcl create separate function objects when the same function is
used as trigger on different relations.  I am not convinced that Tcl
actually has to have this, but it seems a good idea to make it be
parallel to the other PLs that definitely do need it.

21 years agoFix plpython to generate separate cached procedure data for each
Tom Lane [Sun, 14 Sep 2003 17:13:06 +0000 (17:13 +0000)]
Fix plpython to generate separate cached procedure data for each
relation, when the same function is used as a trigger on more than
one relation.  This avoids crashes due to differing rowtypes for
different relations.  Per bug report from Lance Thomas, 7-Feb-03.

21 years agoSince I haven't gotten a reply, can someone REVERT the lines in
Bruce Momjian [Sun, 14 Sep 2003 13:33:08 +0000 (13:33 +0000)]
Since I haven't gotten a reply, can someone REVERT the lines in
src/Makefile.shlib that adds $(libdir)/$(soname) for
port,eq,unixware to $(soname)?

Larry Rosenman

21 years agoexpected results for dblink test seem to be out of date ...
Tom Lane [Sun, 14 Sep 2003 02:30:07 +0000 (02:30 +0000)]
expected results for dblink test seem to be out of date ...

21 years agoMake contrib/seg work with flex 2.5.31. Fix it up to have a real
Tom Lane [Sun, 14 Sep 2003 02:18:49 +0000 (02:18 +0000)]
Make contrib/seg work with flex 2.5.31.  Fix it up to have a real
btree operator class, too, since in PG 7.4 you can't GROUP without one.

21 years agoMake contrib/cube work with flex 2.5.31. Fix it up to have a real
Tom Lane [Sun, 14 Sep 2003 01:52:25 +0000 (01:52 +0000)]
Make contrib/cube work with flex 2.5.31.  Fix it up to have a real
btree operator class, too, since in PG 7.4 you can't GROUP without one.

21 years agoReconsider placement of MemoryContextCheck() call --- do after commit,
Tom Lane [Sun, 14 Sep 2003 00:03:32 +0000 (00:03 +0000)]
Reconsider placement of MemoryContextCheck() call --- do after commit,
not before, to avoid duplication of effort.

21 years agoAvoid corner cases where aset.c would unnecessarily make malloc()
Tom Lane [Sat, 13 Sep 2003 22:25:38 +0000 (22:25 +0000)]
Avoid corner cases where aset.c would unnecessarily make malloc()
requests of sizes that aren't powers of 2.  Per observation from
David Schultz, 28-Aug.

21 years agoWith Joe Conway's concurrence, remove srandom() call from normal_rand().
Tom Lane [Sat, 13 Sep 2003 21:44:50 +0000 (21:44 +0000)]
With Joe Conway's concurrence, remove srandom() call from normal_rand().
This was the last piece of code that took it upon itself to reset the
random number sequence --- now we only have srandom() in postmaster start,
backend start, and explicit setseed() operations.

21 years agoOkay, I've had it with mktime() bugs. While chasing Torello Querci's
Tom Lane [Sat, 13 Sep 2003 21:12:38 +0000 (21:12 +0000)]
Okay, I've had it with mktime() bugs.  While chasing Torello Querci's
recent gripe, I discovered not one but two undocumented, undesirable
behaviors of glibc's mktime.  So, stop using it entirely, and always
rely on inversion of localtime() to determine the local time zone.
It's not even very much slower, as it turns out that mktime (at least
in the glibc implementation) also does repeated reverse-conversions.

21 years agoMinor wording improvements.
Tom Lane [Sat, 13 Sep 2003 17:33:46 +0000 (17:33 +0000)]
Minor wording improvements.

21 years agoRename --without-spinlocks to --disable-spinlocks, per Peter.
Bruce Momjian [Sat, 13 Sep 2003 17:01:09 +0000 (17:01 +0000)]
Rename --without-spinlocks to --disable-spinlocks, per Peter.

21 years agoWith pg_autovacuum becoming increasingly popular it's important to
Bruce Momjian [Sat, 13 Sep 2003 16:44:49 +0000 (16:44 +0000)]
With pg_autovacuum becoming increasingly popular it's important to
have a working stats collector.  This test is able to discover the
problem that was present in 7.4 Beta 2.

Manfred Koizar

21 years agoWhen I sent in the sslmode patch I forgot to update the
Bruce Momjian [Sat, 13 Sep 2003 16:43:38 +0000 (16:43 +0000)]
When I sent in the sslmode patch I forgot to update the
comments/examples in pg_hba.conf. This patch remedies that, adds a brief
explanation of the connection types, and adds a missing period in the
docs.

Jon Jensen

21 years agoautoconf/autoheader run.
Bruce Momjian [Sat, 13 Sep 2003 16:39:51 +0000 (16:39 +0000)]
autoconf/autoheader run.

21 years agopgindent C file, per patch request.
Bruce Momjian [Sat, 13 Sep 2003 16:27:38 +0000 (16:27 +0000)]
pgindent C file, per patch request.

21 years ago> OK, well as we wait on the fix for the stats system, let me submit my
Bruce Momjian [Sat, 13 Sep 2003 16:26:18 +0000 (16:26 +0000)]
> OK, well as we wait on the fix for the stats system, let me submit my
> patch for pg_autovacuum.  This patch assumes that the stats system will
> be fixed so that all inserts, updates and deletes performed on shared
> tables reguardless of what database those commands were executed from,
> will show up in the stats shown in each database.

I had to make a further change to this to take quotes off the 'last
ANALYZE' in order for it to not overquote the relation name, so
there's a _little_ work left to get it to play well.

I have deployed it onto several boxes that should be doing some
vacuuming over the weekend, and it is now certainly hitting pg_
tables.

I would like to present a CVS-oriented patch; unfortunately, I had to
change the indentation patterns when editing some of it :-(.  The
following _may_ be good; not sure...

Matthew T. O'Connor
Christopher Browne

21 years agoAttempt threading in this order:
Bruce Momjian [Sat, 13 Sep 2003 14:49:51 +0000 (14:49 +0000)]
Attempt threading in this order:

 *      use non-*_r function names if they are all thread-safe
 *          (NEED_REENTRANT_FUNCS=no)
 *      use *_r functions if they exist (configure test)
 *      do our own locking and copying of non-threadsafe functions

New to this patch is the last option.

21 years agoMore SQLState updates from Kim Ho at Redhat.
Barry Lind [Sat, 13 Sep 2003 04:02:16 +0000 (04:02 +0000)]
More SQLState updates from Kim Ho at Redhat.
Also a patch from Kris Jurka to correctly report SQLState support.

 Modified Files:
  jdbc/org/postgresql/Driver.java.in
  jdbc/org/postgresql/core/QueryExecutor.java
  jdbc/org/postgresql/fastpath/Fastpath.java
  jdbc/org/postgresql/geometric/PGbox.java
  jdbc/org/postgresql/geometric/PGcircle.java
  jdbc/org/postgresql/geometric/PGline.java
  jdbc/org/postgresql/geometric/PGlseg.java
  jdbc/org/postgresql/geometric/PGpath.java
  jdbc/org/postgresql/geometric/PGpoint.java
  jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
  jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
  jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSetMetaData.java
  jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
  jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSet.java
  jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSetMetaData.java
  jdbc/org/postgresql/jdbc2/Array.java
  jdbc/org/postgresql/jdbc3/AbstractJdbc3DatabaseMetaData.java
  jdbc/org/postgresql/util/PGmoney.java
  jdbc/org/postgresql/util/PSQLState.java

21 years agoMarginal hacks to make tables format more nicely.
Tom Lane [Sat, 13 Sep 2003 00:19:43 +0000 (00:19 +0000)]
Marginal hacks to make tables format more nicely.

21 years agoMop-up for error-message updates in documentation.
Tom Lane [Fri, 12 Sep 2003 23:04:46 +0000 (23:04 +0000)]
Mop-up for error-message updates in documentation.

21 years agoUpdate obsolete examples of error messages; various other minor editing.
Tom Lane [Fri, 12 Sep 2003 22:17:24 +0000 (22:17 +0000)]
Update obsolete examples of error messages; various other minor editing.

21 years agoRevert to our pre-7.4 behavior of identifying Unix-socket connections in
Tom Lane [Fri, 12 Sep 2003 20:18:51 +0000 (20:18 +0000)]
Revert to our pre-7.4 behavior of identifying Unix-socket connections in
ps status as '[local]', not as 'localhost' as the code has been doing
recently.  That's too easily confused with TCP loopback connections,
and there is no good reason to change the behavior anyway.

21 years agoSomeone (possibly me) foolishly reduced the response for failing
Tom Lane [Fri, 12 Sep 2003 19:33:59 +0000 (19:33 +0000)]
Someone (possibly me) foolishly reduced the response for failing
to create a TCP/IP socket from FATAL to LOG.  This was unwise;
historically we have expected socket conflicts to abort postmaster
startup.  Conflicts on port numbers with another postmaster can only
be detected reliably at the TCP socket level.

21 years agoMark FreeBSD as non-thread-safe.
Bruce Momjian [Fri, 12 Sep 2003 16:49:34 +0000 (16:49 +0000)]
Mark FreeBSD as non-thread-safe.

21 years agoFix incorrect pfree in to_tsquery_name(), per Nigel Andrews.
Tom Lane [Fri, 12 Sep 2003 16:34:28 +0000 (16:34 +0000)]
Fix incorrect pfree in to_tsquery_name(), per Nigel Andrews.

21 years agoImplement compiler #error if spinlock code not found, add configure flag
Bruce Momjian [Fri, 12 Sep 2003 16:10:27 +0000 (16:10 +0000)]
Implement compiler #error if spinlock code not found, add configure flag
to bypass the error, --without-spinlocks.

21 years agoEnable Opteron/Itanium spinlocks.
Bruce Momjian [Fri, 12 Sep 2003 15:49:34 +0000 (15:49 +0000)]
Enable Opteron/Itanium spinlocks.

21 years agoRemove WIN32_CONSOLE support, at the request of the author.
Bruce Momjian [Fri, 12 Sep 2003 02:40:10 +0000 (02:40 +0000)]
Remove WIN32_CONSOLE support, at the request of the author.

21 years agoFix old mention of exec() in AttachSharedMemoryAndSemaphores comment.
Bruce Momjian [Fri, 12 Sep 2003 02:13:23 +0000 (02:13 +0000)]
Fix old mention of exec() in AttachSharedMemoryAndSemaphores comment.

21 years agoMore cleanup of Diagnostics sections.
Tom Lane [Fri, 12 Sep 2003 00:12:47 +0000 (00:12 +0000)]
More cleanup of Diagnostics sections.

21 years agoSmall typo.
Tom Lane [Thu, 11 Sep 2003 23:15:51 +0000 (23:15 +0000)]
Small typo.

21 years agoMessage in the other exit from acquire_sample_rows(), as per update
Tom Lane [Thu, 11 Sep 2003 23:12:31 +0000 (23:12 +0000)]
Message in the other exit from acquire_sample_rows(), as per update
from Mark Kirkwood.  Also show the sample size.

21 years agoTry to make recently-added analyze log message look something like
Tom Lane [Thu, 11 Sep 2003 22:59:28 +0000 (22:59 +0000)]
Try to make recently-added analyze log message look something like
the others in style.