Craig Small [Mon, 11 Jun 2012 01:36:55 +0000 (11:36 +1000)]
sed uses proper BRE
Apparently even though [0-9]+ works most of the time, its not proper BRE
and doesn't work ALL of the time. Replacing this with [0-9][0-9]* makes
everyone happy.
Noticed by Rich from the busybox project and reported by John Spencer
of the same project.
Corinna Vinschen [Sat, 19 May 2012 08:54:35 +0000 (18:54 +1000)]
3 fixes for Cygwin
The attached patch fixes three issues of fuser on Cygwin.:
- Cygwin does not support /proc/net/unix. The call to fill_unix_cache
always generates an error message that /proc/net/unix couldn't be
found, so the patch disables the call for Cygwin. An alternative
fix would be to avoid the error message entirely.
- `ls /dev' on Cygwin only lists manually added entries to /dev, not the
default files suported by Cygwin internally. Also,
/proc/$PID/mountinfo doesn't exist up to Cygwin 1.7.11. This
breaks fuser when using the _LISTS_H option.
- If you don't include lists.h, the code in check_dir doesn't work well.
st.st_ino is never set to 0, so the timeout(stat, ...) is never
called. Also, thedev never gets a valid value in this case, but it's
used subsequently for comparisons.
Samuel Thibault [Sat, 19 May 2012 08:09:41 +0000 (18:09 +1000)]
Remove fuser out of target for hurd-i386
hurd-i386 does not have PATH_MAX which means fuser won't compile.
However the archtecture cannot use fuser anyway so we now don't
even try to compile it for hurd-i386
Bug-Debian: http://bugs.debian.org/673485 Signed-off-by: Craig Small <csmall@enc.com.au>
Craig Small [Fri, 27 Jan 2012 02:11:25 +0000 (13:11 +1100)]
Added hardened CFLAGS
Debian and Ubuntu (at the least) have some CFLAGS that harden the binary
for some typical attacks. psmisc now will have these flags on by default
but checks the compilier supports them.
Sami Kerola [Wed, 4 Jan 2012 13:49:08 +0000 (14:49 +0100)]
build-sys: fix AC_TRY_LINK warnings
configure.ac:71: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:71: You should run autoupdate.
../../lib/autoconf/general.m4:2688: AC_TRY_LINK is expanded from...
../../lib/m4sugar/m4sh.m4:606: AS_IF is expanded from...
../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from...
../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from...
m4/gettext.m4:367: gt_INTL_MACOSX is expanded from...
m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from...
configure.ac:71: the top level
configure.ac:71: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:71: You should run autoupdate.
../../lib/autoconf/general.m4:2688: AC_TRY_LINK is expanded from...
../../lib/m4sugar/m4sh.m4:606: AS_IF is expanded from...
../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from...
../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from...
m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from...
configure.ac:71: the top level
configure.ac:71: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:71: You should run autoupdate.
../../lib/autoconf/general.m4:2688: AC_TRY_LINK is expanded from...
../../lib/m4sugar/m4sh.m4:606: AS_IF is expanded from...
../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from...
../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from...
Signed-off-by: Sami Kerola <sami.kerola@tomtom.com>
Craig Small [Sun, 19 Jun 2011 01:16:43 +0000 (11:16 +1000)]
2 Fixes for Debian Bug#623425
Both patches are by Jonathan Nieder <jrnieder@gmail.com>
Ever since psmisc 22.4 (2007-04-08), "killall <path>" compares
the target of the /proc/<pid>/exe link to <path> when comparison
of inode numbers fails. But the code to do this has two problems:
- readlink does not NUL-terminate, but we use strcmp to
compare strings. Probably this hasn't been a problem so far
because (1) the on-stack buffer happened to have zeroes in the
right places or (2) some implementations of readlink might
happen to NUL-terminate their result when convenient anyway.
- it relies on PATH_MAX to determine the size of the buffer,
so the code fails to build from source on platforms (like the
Hurd) that have no global PATH_MAX.
Fix both by using a buffer of size strlen("<path>") + 1 and comparing
the link target to <path> with memcmp after checking that it fit in
the buffer.
For consistency with the surrounding code, the pid is considered not
to match if malloc or readlink fails.
---------------
The Hurd has most of the expected /proc/<pid> hierarchy but no
/proc/self. Without this change, running "sleep 10 & killall sleep"
on that platform produces the confusing message:
/proc is empty (not mounted ?)
Craig Small [Tue, 22 Feb 2011 09:35:14 +0000 (20:35 +1100)]
Added SF patches and bug reports
* Applied patch from Werner Fink to avoid stat(2) on NFS mounts
* Zeros process group memory - Patch by jgorig SF#3152925 RH#666213
* fuser -m -s flags work - Patch by jgorig SF#31110178 RH#651794
* fuser silent if /proc/swaps not available SF#3072134
* ppc 64 support for peekfd by jgorig SF#3166444
* jiffies now ULL in killall SF#3138538
* pstree can show parents of a process. Patch supplied by Curtis Hawthorne SF#3135157
Werner Fink [Tue, 21 Sep 2010 07:04:16 +0000 (09:04 +0200)]
Add an option -w to fuser to be able to send signals
to processes which have write access to an open file
or directory. This option is silently ignored if -k is
not present too.
Werner Fink [Fri, 10 Sep 2010 09:18:53 +0000 (11:18 +0200)]
Fix file descriptor as well as memory leaks in fuser.
Strip @ symbol from file names read from /proc/net/unix.
This close the openSuSE bugs #536209, #529520, and #417841.
Craig Small [Fri, 10 Jul 2009 06:45:14 +0000 (06:45 +0000)]
* Applied patch from Kari Hautio for lazy umount'ed filesystems SF#25456
32
* Applied patch from Anonymous SF submitter to fix killall -l
Fixes SF#2002570
* fuser will print mounts,nfs exports and swaps with -v Debian #356655
* pstree and fuser have long options Debian #517412