]> granicus.if.org Git - postgresql/log
postgresql
14 years agoSecond try: walreceiver should not be built with -DBUILDING_DLL
Tom Lane [Fri, 15 Jan 2010 21:43:21 +0000 (21:43 +0000)]
Second try: walreceiver should not be built with -DBUILDING_DLL

14 years agoNo, scratch that, it was getting added twice.
Tom Lane [Fri, 15 Jan 2010 21:06:26 +0000 (21:06 +0000)]
No, scratch that, it was getting added twice.

14 years agoActually, I'll bet the mingw problem is lack of $(BE_DLLLIBS) ...
Tom Lane [Fri, 15 Jan 2010 20:45:42 +0000 (20:45 +0000)]
Actually, I'll bet the mingw problem is lack of $(BE_DLLLIBS) ...

14 years agoFix bogus subdir setting ... wonder just what that affects ...
Tom Lane [Fri, 15 Jan 2010 20:34:11 +0000 (20:34 +0000)]
Fix bogus subdir setting ... wonder just what that affects ...

14 years agoMove build of src/backend/replication/walreceiver/ later in the build
Heikki Linnakangas [Fri, 15 Jan 2010 17:01:06 +0000 (17:01 +0000)]
Move build of src/backend/replication/walreceiver/ later in the build
process, after src/interfaces, because it depends on libpq. Also add
missing lines for clean etc. targets

Report from Boszormenyi Zoltan.

14 years agoAdded correct error handling in DESCRIBE statement processing by Boszormenyi Zoltan...
Michael Meskes [Fri, 15 Jan 2010 13:19:12 +0000 (13:19 +0000)]
Added correct error handling in DESCRIBE statement processing by Boszormenyi Zoltan <zb@cybertec.at>.

14 years agoRemove unused (in non-assertion-enabled build) variable.
Heikki Linnakangas [Fri, 15 Jan 2010 11:47:15 +0000 (11:47 +0000)]
Remove unused (in non-assertion-enabled build) variable.

14 years agoApplied patch by Boszormenyi Zoltan <zb@cybertec.at> to add DESCRIBE [OUTPUT] stateme...
Michael Meskes [Fri, 15 Jan 2010 10:44:39 +0000 (10:44 +0000)]
Applied patch by Boszormenyi Zoltan <zb@cybertec.at> to add DESCRIBE [OUTPUT] statement to ecpg.

14 years agoIntroduce Streaming Replication.
Heikki Linnakangas [Fri, 15 Jan 2010 09:19:10 +0000 (09:19 +0000)]
Introduce Streaming Replication.

This includes two new kinds of postmaster processes, walsenders and
walreceiver. Walreceiver is responsible for connecting to the primary server
and streaming WAL to disk, while walsender runs in the primary server and
streams WAL from disk to the client.

Documentation still needs work, but the basics are there. We will probably
pull the replication section to a new chapter later on, as well as the
sections describing file-based replication. But let's do that as a separate
patch, so that it's easier to see what has been added/changed. This patch
also adds a new section to the chapter about FE/BE protocol, documenting the
protocol used by walsender/walreceivxer.

Bump catalog version because of two new functions,
pg_last_xlog_receive_location() and pg_last_xlog_replay_location(), for
monitoring the progress of replication.

Fujii Masao, with additional hacking by me

14 years agoAdd point_ops opclass for GiST.
Teodor Sigaev [Thu, 14 Jan 2010 16:31:09 +0000 (16:31 +0000)]
Add point_ops opclass for GiST.

14 years agoFirst part of refactoring of code for ResolveRecoveryConflict. Purposes
Simon Riggs [Thu, 14 Jan 2010 11:08:02 +0000 (11:08 +0000)]
First part of refactoring of code for ResolveRecoveryConflict. Purposes
of this are to centralise the conflict code to allow further change,
as well as to allow passing through the full reason for the conflict
through to the conflicting backends. Backend state alters how we
can handle different types of conflict so this is now required.
As originally suggested by Heikki, no longer optional.

14 years agoSimplify validate_exec() by using access(2) to check file permissions,
Tom Lane [Thu, 14 Jan 2010 00:14:06 +0000 (00:14 +0000)]
Simplify validate_exec() by using access(2) to check file permissions,
rather than trying to implement the equivalent logic by hand.  The motivation
for the original coding appears to have been to check with the effective uid's
permissions not the real uid's; but there is no longer any difference, because
we don't run the postmaster setuid (indeed, main.c enforces that they're the
same).  Using access() means we will get it right in situations the original
coding failed to handle, such as ACL-based permissions.  Besides it's a lot
shorter, cleaner, and more thread-safe.  Per bug #5275 from James Bellinger.

14 years agoWhen loading critical system indexes into the relcache, ensure we lock the
Tom Lane [Wed, 13 Jan 2010 23:07:08 +0000 (23:07 +0000)]
When loading critical system indexes into the relcache, ensure we lock the
underlying catalog not only the index itself.  Otherwise, if the cache
load process touches the catalog (which will happen for many though not
all of these indexes), we are locking index before parent table, which can
result in a deadlock against processes that are trying to lock them in the
normal order.  Per today's failure on buildfarm member gothic_moth; it's
surprising the problem hadn't been identified before.

Back-patch to 8.2.  Earlier releases didn't have the issue because they
didn't try to lock these indexes during load (instead assuming that they
couldn't change schema at all during multiuser operation).

14 years agoFix bug #5269: ResetPlanCache mustn't invalidate cached utility statements,
Tom Lane [Wed, 13 Jan 2010 16:56:56 +0000 (16:56 +0000)]
Fix bug #5269: ResetPlanCache mustn't invalidate cached utility statements,
especially not ROLLBACK.  ROLLBACK might need to be executed in an already
aborted transaction, when there is no safe way to revalidate the plan.  But
in general there's no point in marking utility statements invalid, since
they have no plans in the normal sense of the word; so we might as well
work a bit harder here to avoid future revalidation cycles.

Back-patch to 8.4, where the bug was introduced.

14 years agoApplied Zoltan's patch to make char the default sqlda type.
Michael Meskes [Wed, 13 Jan 2010 09:06:51 +0000 (09:06 +0000)]
Applied Zoltan's patch to make char the default sqlda type.

Given that undefined types are handled as character strings anyway the type
translation function can simply return the correcponding ECPGt_char type.

14 years agoFix SQL3 type return value.
Michael Meskes [Wed, 13 Jan 2010 08:41:50 +0000 (08:41 +0000)]
Fix SQL3 type return value.

For non-SQL3 types ecpg used to return -Oid. This will break if there are
enough Oids to fill the namespace. Therefore we play it safe and return 0 if
there is no Oid->SQL3 tyoe mapping available.

14 years agoMake fixed_paramref_hook behave properly when there are 'unused' slots
Tom Lane [Wed, 13 Jan 2010 01:17:07 +0000 (01:17 +0000)]
Make fixed_paramref_hook behave properly when there are 'unused' slots
in the parameter array.  Noted while experimenting with an example
from Pavel.  This wouldn't come up in normal use, but it ought to honor
the specification that a parameter array can have unused slots.

14 years agoUpdate MSVC build instructions.
Magnus Hagander [Tue, 12 Jan 2010 20:13:32 +0000 (20:13 +0000)]
Update MSVC build instructions.

Updated to reflect building with Visual Studio 2008, with just the
Platform SDK, and for 64-bit Windows.

14 years agoFix relcache reload mechanism to be more robust in the face of errors
Tom Lane [Tue, 12 Jan 2010 18:12:18 +0000 (18:12 +0000)]
Fix relcache reload mechanism to be more robust in the face of errors
occurring during a reload, such as query-cancel.  Instead of zeroing out
an existing relcache entry and rebuilding it in place, build a new relcache
entry, then swap its contents with the old one, then free the new entry.
This avoids problems with code believing that a previously obtained pointer
to a cache entry must still reference a valid entry, as seen in recent
failures on buildfarm member jaguar.  (jaguar is using CLOBBER_CACHE_ALWAYS
which raises the probability of failure substantially, but the problem
could occur in the field without that.)  The previous design was okay
when it was made, but subtransactions and the ResourceOwner mechanism
make it unsafe now.

Also, make more use of the already existing rd_isvalid flag, so that we
remember that the entry requires rebuilding even if the first attempt fails.

Back-patch as far as 8.2.  Prior versions have enough issues around relcache
reload anyway (due to inadequate locking) that fixing this one doesn't seem
worthwhile.

14 years agoRemoved ecpg Changelog file that was only there for historical reasons and isn't...
Michael Meskes [Tue, 12 Jan 2010 12:41:46 +0000 (12:41 +0000)]
Removed ecpg Changelog file that was only there for historical reasons and isn't actively used anymore.

14 years agoPlease tablespace directories in their own subdirectory so pg_migrator
Bruce Momjian [Tue, 12 Jan 2010 02:42:52 +0000 (02:42 +0000)]
Please tablespace directories in their own subdirectory so pg_migrator
can upgrade clusters without renaming the tablespace directories.  New
directory structure format is, e.g.:

$PGDATA/pg_tblspc/20981/PG_8.5_201001061/719849/83292814

14 years agoFix aclexplode to not explode on a zero-entry ACL array.
Tom Lane [Tue, 12 Jan 2010 02:39:22 +0000 (02:39 +0000)]
Fix aclexplode to not explode on a zero-entry ACL array.
(An Assert is no substitute for thinking clearly :-()

Minor style kibitzing too.

Per report from Robert Treat.

14 years agoRemove tabs in SGML file.
Bruce Momjian [Tue, 12 Jan 2010 02:33:45 +0000 (02:33 +0000)]
Remove tabs in SGML file.

14 years agoAdd some simple support and documentation for using process-specific oom_adj
Tom Lane [Mon, 11 Jan 2010 18:39:32 +0000 (18:39 +0000)]
Add some simple support and documentation for using process-specific oom_adj
settings to prevent the postmaster from being OOM-killed on Linux systems.

Alex Hunsaker and Tom Lane

14 years agoImprove ExecEvalVar's handling of whole-row variables in cases where the
Tom Lane [Mon, 11 Jan 2010 15:31:04 +0000 (15:31 +0000)]
Improve ExecEvalVar's handling of whole-row variables in cases where the
rowtype contains dropped columns.  Sometimes the input tuple will be formed
from a select targetlist in which dropped columns are filled with a NULL
of an arbitrary type (the planner typically uses INT4, since it can't tell
what type the dropped column really was).  So we need to relax the rowtype
compatibility check to not insist on physical compatibility if the actual
column value is NULL.

In principle we might need to do this for functions returning composite
types, too (see tupledesc_match()).  In practice there doesn't seem to be
a bug there, probably because the function will be using the same cached
rowtype descriptor as the caller.  Fixing that code path would require
significant rearrangement, so I left it alone for now.

Per complaint from Filip Rembialkowski.

14 years agoremove use of temp file for perlchunks.h, as in recent change to plperl GNUmakefile
Andrew Dunstan [Mon, 11 Jan 2010 14:16:18 +0000 (14:16 +0000)]
remove use of temp file for perlchunks.h, as in recent change to plperl GNUmakefile

14 years agoSome trivial adjustments in comments for struct RelationData.
Tom Lane [Sun, 10 Jan 2010 22:19:17 +0000 (22:19 +0000)]
Some trivial adjustments in comments for struct RelationData.

14 years agoRemove unnecessary use of temp file. Tim Bunce
Tom Lane [Sun, 10 Jan 2010 18:10:03 +0000 (18:10 +0000)]
Remove unnecessary use of temp file.  Tim Bunce

14 years agoImprove plpgsql parsing to report "foo is not a known variable", rather than a
Tom Lane [Sun, 10 Jan 2010 17:56:50 +0000 (17:56 +0000)]
Improve plpgsql parsing to report "foo is not a known variable", rather than a
generic syntax error, when seeing "foo := something" and foo isn't recognized.
This buys back most of the helpfulness discarded in my previous patch by not
throwing errors when a qualified name appears to match a row variable but the
last component doesn't match any field of the row.  It covers other cases
where our error messages left something to be desired, too.

14 years agoImprove plpgsql's handling of record field references by forcing all potential
Tom Lane [Sun, 10 Jan 2010 17:15:18 +0000 (17:15 +0000)]
Improve plpgsql's handling of record field references by forcing all potential
field references in SQL expressions to have RECFIELD datum-array entries at
parse time.  If it turns out that the reference is actually to a SQL column,
the RECFIELD entry is useless, but it costs little.  This allows us to get rid
of the previous use of FieldSelect applied to a whole-row Param for the record
variable; which was not only slower than a direct RECFIELD reference, but
failed for references to system columns of a trigger's NEW or OLD record.
Per report and fix suggestion from Dean Rasheed.

14 years agoDocs for behaviour change of drop database during Hot Standby
Simon Riggs [Sun, 10 Jan 2010 16:27:27 +0000 (16:27 +0000)]
Docs for behaviour change of drop database during Hot Standby

Adding missing docs for previous Hot Standby patch.

14 years agoUpdate Windows installation notes.
Magnus Hagander [Sun, 10 Jan 2010 15:54:11 +0000 (15:54 +0000)]
Update Windows installation notes.

pginstaller isn't used anymore, in favor of the one-click installers.
Make it clear that we support Windows 2000 and newer with the native
port, instead of first saying we support NT4 and then saying we don't.

14 years agoDuring Hot Standby, fix drop database when sessions idle.
Simon Riggs [Sun, 10 Jan 2010 15:44:28 +0000 (15:44 +0000)]
During Hot Standby, fix drop database when sessions idle.
Previously we only cancelled sessions that were in-transaction.

Simple fix is to just cancel all sessions without waiting. Doing
it this way avoids complicating common code paths, which would
not be worth the trouble to cover this rare case.

Problem report and fix by Andres Freund, edited somewhat by me

14 years agoCreate typedef pgsocket for storing socket descriptors.
Magnus Hagander [Sun, 10 Jan 2010 14:16:08 +0000 (14:16 +0000)]
Create typedef pgsocket for storing socket descriptors.

This silences some warnings on Win64. Not using the proper SOCKET datatype
was actually wrong on Win32 as well, but didn't cause any warnings there.

Also create define PGINVALID_SOCKET to indicate an invalid/non-existing
socket, instead of using a hardcoded -1 value.

14 years agoRemove partial, broken support for NULL pointers when fetching attributes.
Robert Haas [Sun, 10 Jan 2010 04:26:36 +0000 (04:26 +0000)]
Remove partial, broken support for NULL pointers when fetching attributes.

Previously, fastgetattr() and heap_getattr() tested their fourth argument
against a null pointer, but any attempt to use them with a literal-NULL
fourth argument evaluated to *(void *)0, resulting in a compiler error.
Remove these NULL tests to avoid leading future readers of this code to
believe that this has a chance of working.  Also clean up related legacy
code in nocachegetattr(), heap_getsysattr(), and nocache_index_getattr().

The new coding standard is that any code which calls a getattr-type
function or macro which takes an isnull argument MUST pass a valid
boolean pointer.  Per discussion with Bruce Momjian, Tom Lane, Alvaro
Herrera.

14 years agoDocument pg_tablespace.spcoptions.
Robert Haas [Sun, 10 Jan 2010 01:23:08 +0000 (01:23 +0000)]
Document pg_tablespace.spcoptions.

This should have been part of the original tablespace-options patch, but I
overlooked the need to update this portion of the documentation.

14 years agoMake ExecEvalFieldSelect throw a more intelligible error if it's asked to
Tom Lane [Sat, 9 Jan 2010 20:46:19 +0000 (20:46 +0000)]
Make ExecEvalFieldSelect throw a more intelligible error if it's asked to
extract a system column, and remove a couple of lines that are useless
in light of the fact that we aren't ever going to support this case.  There
isn't much point in trying to make this work because a tuple Datum does
not carry many of the system columns.  Per experimentation with a case
reported by Dean Rasheed; we'll have to fix his problem somewhere else.

14 years agoDuring Hot Standby, set DatabasePath correctly during relcache init file
Simon Riggs [Sat, 9 Jan 2010 16:49:27 +0000 (16:49 +0000)]
During Hot Standby, set DatabasePath correctly during relcache init file
deletion, so that we attempt to unlink the correct filepath. unlink()
errors are ignorable there, so lack of a DatabasePath initialization step
did not cause visible problems until a related bug showed up on Solaris.

Code refactored from xact_redo_commit() to
ProcessCommittedInvalidationMessages() in inval.c. Recovery may replay
shared invalidation messages for many databases, so we cannot
SetDatabasePath() once as we do in normal backends. Read the databaseid
from the shared invalidation messages, then set DatabasePath
temporarily before calling RelationCacheInitFileInvalidate().

Problem report by Robert Treat, analysis and fix by me.

14 years agoProvide regression testing for plperlu, and for plperl+plperlu interaction.
Andrew Dunstan [Sat, 9 Jan 2010 15:25:41 +0000 (15:25 +0000)]
Provide regression testing for plperlu, and for plperl+plperlu interaction.
The latter are only run if the platform can run both interpreters in the
same backend.

14 years agoBuild perlchunks.h for plperl on MSVC
Andrew Dunstan [Sat, 9 Jan 2010 14:45:47 +0000 (14:45 +0000)]
Build perlchunks.h for plperl on MSVC

14 years agoFix makefile so it works for VPATH case.
Tom Lane [Sat, 9 Jan 2010 03:53:40 +0000 (03:53 +0000)]
Fix makefile so it works for VPATH case.

14 years agoTidy up and refactor plperl.c.
Andrew Dunstan [Sat, 9 Jan 2010 02:40:50 +0000 (02:40 +0000)]
Tidy up and refactor plperl.c.

- Changed MULTIPLICITY check from runtime to compiletime.
    No loads the large Config module.
- Changed plperl_init_interp() to return new interp
    and not alter the global interp_state
- Moved plperl_safe_init() call into check_interp().
- Removed plperl_safe_init_done state variable
    as interp_state now covers that role.
- Changed plperl_create_sub() to take a plperl_proc_desc argument.
- Simplified return value handling in plperl_create_sub.
- Changed perl.com link in the docs to perl.org and tweaked
    wording to clarify that require, not use, is what's blocked.
- Moved perl code in large multi-line C string literal macros
    out to plc_*.pl files.
- Added a test2macro.pl utility to convert the plc_*.pl files to
    macros in a perlchunks.h file which is #included
- Simplifed plperl_safe_init() slightly
- Optimized pg_verifymbstr calls to avoid unneeded strlen()s.

Patch from Tim Bunce, with minor editing from me.

14 years agoAlso update ChangerLog file.
Michael Meskes [Fri, 8 Jan 2010 09:06:05 +0000 (09:06 +0000)]
Also update ChangerLog file.

14 years agoFix oversight in EvalPlanQualFetch: after failing to lock a tuple because
Tom Lane [Fri, 8 Jan 2010 02:44:00 +0000 (02:44 +0000)]
Fix oversight in EvalPlanQualFetch: after failing to lock a tuple because
someone else has just updated it, we have to set priorXmax to that tuple's
xmax (ie, the XID of the other xact that updated it) before looping back to
examine the next tuple.  Obviously, the next tuple in the update chain should
have that XID as its xmin, not the same xmin as the preceding tuple that we
had been trying to lock.  The mismatch would cause the EvalPlanQual logic to
decide that the tuple chain ended in a deletion, when actually there was a
live tuple that should have been found.

I inserted this error when recently adding logic to EvalPlanQual to make it
lock tuples before returning them (as opposed to the old method in which the
lock would occur much later, causing a great deal of work to be wasted if we
only then discover someone else updated it).  Sigh.  Per today's report from
Takahiro Itagaki of inconsistent results during pgbench runs.

14 years agopgBufferUsage needs PGDLLIMPORT for pg_stat_statements on Windows.
Itagaki Takahiro [Fri, 8 Jan 2010 00:48:56 +0000 (00:48 +0000)]
pgBufferUsage needs PGDLLIMPORT for pg_stat_statements on Windows.

14 years agoAdd buffer access counters to pg_stat_statements.
Itagaki Takahiro [Fri, 8 Jan 2010 00:38:20 +0000 (00:38 +0000)]
Add buffer access counters to pg_stat_statements.

This uses the same infrastructure with EXPLAIN BUFFERS to support
{shared|local}_blks_{hit|read|written} andtemp_blks_{read|written}
columns in the pg_stat_statements view. The dumped file format
also updated.

Thanks to Robert Haas for the review.

14 years agoDocument why we copy reloptions into CacheMemoryContext after-the-fact.
Robert Haas [Thu, 7 Jan 2010 20:39:45 +0000 (20:39 +0000)]
Document why we copy reloptions into CacheMemoryContext after-the-fact.

14 years agoFix 3-parameter form of bit substring() to throw error for negative length,
Tom Lane [Thu, 7 Jan 2010 20:17:44 +0000 (20:17 +0000)]
Fix 3-parameter form of bit substring() to throw error for negative length,
as required by SQL standard.

14 years agoMake bit/varbit substring() treat any negative length as meaning "all the rest
Tom Lane [Thu, 7 Jan 2010 19:53:11 +0000 (19:53 +0000)]
Make bit/varbit substring() treat any negative length as meaning "all the rest
of the string".  The previous coding treated only -1 that way, and would
produce an invalid result value for other negative values.

We ought to fix it so that 2-parameter bit substring() is a different C
function and the 3-parameter form throws error for negative length, but
that takes a pg_proc change which is impractical in the back branches;
and in any case somebody might be relying on -1 working this way.
So just do this as a back-patchable fix.

14 years agoFix (some of the) breakage introduced into query-cancel processing by HS.
Tom Lane [Thu, 7 Jan 2010 16:29:58 +0000 (16:29 +0000)]
Fix (some of the) breakage introduced into query-cancel processing by HS.

It is absolutely not okay to throw an ereport(ERROR) in any random place in
the code just because DoingCommandRead is set; interrupting, say, OpenSSL
in the midst of its activities is guaranteed to result in heartache.

Instead of that, undo the original optimizations that threw away
QueryCancelPending anytime we were starting or finishing a command read, and
instead discard the cancel request within ProcessInterrupts if we find that
there is no HS reason for forcing a cancel and we are DoingCommandRead.

In passing, may I once again condemn the practice of changing the code
and not fixing the adjacent comment that you just turned into a lie?

14 years agoUse -Z for vacuumdb --analyze-only, rather than -o.
Bruce Momjian [Thu, 7 Jan 2010 14:35:44 +0000 (14:35 +0000)]
Use -Z for vacuumdb --analyze-only, rather than -o.

14 years agoRename new vacuumdb option to --analyze-only from --only-analyze.
Bruce Momjian [Thu, 7 Jan 2010 12:38:55 +0000 (12:38 +0000)]
Rename new vacuumdb option to --analyze-only from --only-analyze.

14 years agoRemove all the special-case code for INT64_IS_BUSTED, per decision that
Tom Lane [Thu, 7 Jan 2010 04:53:35 +0000 (04:53 +0000)]
Remove all the special-case code for INT64_IS_BUSTED, per decision that
we're not going to support that anymore.

I did keep the 64-bit-CRC-with-32-bit-arithmetic code, since it has a
performance excuse to live.  It's a bit moot since that's all ifdef'd
out, of course.

14 years agoMore tablespace.c comment improvements.
Bruce Momjian [Thu, 7 Jan 2010 04:10:39 +0000 (04:10 +0000)]
More tablespace.c comment improvements.

14 years agoClarify tablespace.c::TablespaceCreateDbspace() comments.
Bruce Momjian [Thu, 7 Jan 2010 04:05:39 +0000 (04:05 +0000)]
Clarify tablespace.c::TablespaceCreateDbspace() comments.

14 years agoFurther fixes for per-tablespace options patch.
Robert Haas [Thu, 7 Jan 2010 03:53:08 +0000 (03:53 +0000)]
Further fixes for per-tablespace options patch.

Add missing varlena header to TableSpaceOpts structure.  And, per
Tom Lane, instead of calling tablespace_reloptions in CacheMemoryContext,
call it in the caller's memory context and copy the value over
afterwards, to reduce the chances of a session-lifetime memory leak.

14 years agoFail in a nicer way if we have --with-perl and no Perl.
Tom Lane [Thu, 7 Jan 2010 03:24:57 +0000 (03:24 +0000)]
Fail in a nicer way if we have --with-perl and no Perl.

14 years agoImprove a couple of comments relating to large object snapshot management.
Robert Haas [Thu, 7 Jan 2010 02:41:16 +0000 (02:41 +0000)]
Improve a couple of comments relating to large object snapshot management.

14 years agoMake configure check the version of Perl we're building with, and reject
Tom Lane [Thu, 7 Jan 2010 01:41:11 +0000 (01:41 +0000)]
Make configure check the version of Perl we're building with, and reject
versions < 5.8.  Also, if there's no Perl, emit a warning informing the
user that he won't be able to build from a CVS pull.  This is exactly the
same treatment we give Bison and Perl, and for the same reasons.

14 years agoAlter the configure script to fail immediately if the C compiler does not
Tom Lane [Thu, 7 Jan 2010 00:25:05 +0000 (00:25 +0000)]
Alter the configure script to fail immediately if the C compiler does not
provide a working 64-bit integer datatype.  As recently noted, we've been
broken on such platforms since early in the 8.4 development cycle.  Since
it took nearly two years for anyone to even notice, it seems that the
rationale for continuing to support such platforms has reached the point
of non-existence.  Rather than thrashing around to try to make it work
again, we'll just admit up front that this no longer works.

Back-patch to 8.4 since that branch is also broken.

We should go around to remove INT64_IS_BUSTED support, but just in HEAD,
so that seems like material for a separate commit.

14 years agoPG_MAJORVERSION:
Bruce Momjian [Wed, 6 Jan 2010 23:23:51 +0000 (23:23 +0000)]
PG_MAJORVERSION:

For simplicity, use PG_MAJORVERSION rather than PG_VERSION for creation
of the PG_VERSION file.

14 years agoFix spccache.c to not suppose that a cache entry will live across database
Tom Lane [Wed, 6 Jan 2010 23:00:02 +0000 (23:00 +0000)]
Fix spccache.c to not suppose that a cache entry will live across database
access, per testing with CLOBBER_CACHE_ALWAYS.  Minor other editorialization.

14 years agoAccess hash entry before freeing it, not after.
Tom Lane [Wed, 6 Jan 2010 22:27:09 +0000 (22:27 +0000)]
Access hash entry before freeing it, not after.

14 years agoMake error messages for bad --set-version argument more useful.
Tom Lane [Wed, 6 Jan 2010 22:02:45 +0000 (22:02 +0000)]
Make error messages for bad --set-version argument more useful.
Per Stefan.

14 years agoMake the makefile pass $MAJORVERSION to genbki.pl, not $VERSION which is
Tom Lane [Wed, 6 Jan 2010 19:56:29 +0000 (19:56 +0000)]
Make the makefile pass $MAJORVERSION to genbki.pl, not $VERSION which is
overridden in the snapshot build script.  $MAJORVERSION is what it really
wanted anyway, so we can tighten up the parsing of --set-version's argument.

14 years agoFix missing <manvolnum> markers in dblink reference entries.
Tom Lane [Wed, 6 Jan 2010 19:07:05 +0000 (19:07 +0000)]
Fix missing <manvolnum> markers in dblink reference entries.
Silences complaints from "make man", and allows these man pages
to be included in man3/.

14 years agoAdd missing 'static' keywords.
Tom Lane [Wed, 6 Jan 2010 18:07:19 +0000 (18:07 +0000)]
Add missing 'static' keywords.

14 years agoCorrected CVS entry:
Bruce Momjian [Wed, 6 Jan 2010 16:04:05 +0000 (16:04 +0000)]
Corrected CVS entry:

--only-analyze mode is for _vacuumdb_, not pg_dump.

14 years agoReplaced int64_t with int64 as Andrew suggested.
Michael Meskes [Wed, 6 Jan 2010 15:15:55 +0000 (15:15 +0000)]
Replaced int64_t with int64 as Andrew suggested.

14 years agoRemove __FUNCTION__ keyword that is not recognized by som compilers.
Michael Meskes [Wed, 6 Jan 2010 15:10:21 +0000 (15:10 +0000)]
Remove __FUNCTION__ keyword that is not recognized by som compilers.

14 years agoRemoved test case using nan as float value because printf's output for nan is
Michael Meskes [Wed, 6 Jan 2010 11:59:52 +0000 (11:59 +0000)]
Removed test case using nan as float value because printf's output for nan is
OS specific with some distinguishing between signaling and quiet nans. It's not
really importnat for us here anyway.

14 years agoRemoved more inttypes.h stuff.
Michael Meskes [Wed, 6 Jan 2010 11:49:43 +0000 (11:49 +0000)]
Removed more inttypes.h stuff.

14 years agoSilence compiler warning about uninitialized variables. This initialization
Itagaki Takahiro [Wed, 6 Jan 2010 11:25:39 +0000 (11:25 +0000)]
Silence compiler warning about uninitialized variables. This initialization
is not necessary needed, but some compilers complain about it.

14 years agoApplied Zoltan's patch to remove hardware dependant offset logging and
Michael Meskes [Wed, 6 Jan 2010 09:44:05 +0000 (09:44 +0000)]
Applied Zoltan's patch to remove hardware dependant offset logging and
superfluous include files.

14 years agoSupport rewritten-based full vacuum as VACUUM FULL. Traditional
Itagaki Takahiro [Wed, 6 Jan 2010 05:31:14 +0000 (05:31 +0000)]
Support rewritten-based full vacuum as VACUUM FULL. Traditional
VACUUM FULL was renamed to VACUUM FULL INPLACE. Also added a new
option -i, --inplace for vacuumdb to perform FULL INPLACE vacuuming.

Since the new VACUUM FULL uses CLUSTER infrastructure, we cannot
use it for system tables. VACUUM FULL for system tables always
fall back into VACUUM FULL INPLACE silently.

Itagaki Takahiro, reviewed by Jeff Davis and Simon Riggs.

14 years agobinary upgrade:
Bruce Momjian [Wed, 6 Jan 2010 05:18:18 +0000 (05:18 +0000)]
binary upgrade:

Preserve relfilenodes for views and composite types --- even though we
don't store data in, them, they do consume relfilenodes.

Bump catalog version.

14 years agoRemove erroneous comma added to pg_dumpall tablespace query when running
Bruce Momjian [Wed, 6 Jan 2010 03:34:41 +0000 (03:34 +0000)]
Remove erroneous comma added to pg_dumpall tablespace query when running
with PG version 8.2-8.4.

14 years agoUpdate catalog version for recent relfilenode patch, so pg_migrator can
Bruce Momjian [Wed, 6 Jan 2010 03:07:24 +0000 (03:07 +0000)]
Update catalog version for recent relfilenode patch, so pg_migrator can
identify the new API.

14 years agoPreserve relfilenodes:
Bruce Momjian [Wed, 6 Jan 2010 03:04:03 +0000 (03:04 +0000)]
Preserve relfilenodes:

Add support to pg_dump --binary-upgrade to preserve all relfilenodes,
for use by pg_migrator.

14 years agopg_dump --only-analyze
Bruce Momjian [Wed, 6 Jan 2010 02:59:46 +0000 (02:59 +0000)]
pg_dump --only-analyze

Implement pg_dump --only-analyze for use by pg_migrator to only analyze
all databases.

14 years agoRemove tabs in SGML.
Bruce Momjian [Wed, 6 Jan 2010 02:41:37 +0000 (02:41 +0000)]
Remove tabs in SGML.
Move OIDCHARS to proper include file.

14 years agoUse OIDCHARS:
Bruce Momjian [Wed, 6 Jan 2010 01:48:09 +0000 (01:48 +0000)]
Use OIDCHARS:

Use OIDCHARS for oid character length, rather than '10', in tablespace
code.

14 years agoAdjust headers to allow pgbench to be built with PGXS.
Itagaki Takahiro [Wed, 6 Jan 2010 01:30:03 +0000 (01:30 +0000)]
Adjust headers to allow pgbench to be built with PGXS.

14 years agoAdd verification of variable names in pgbench.
Itagaki Takahiro [Wed, 6 Jan 2010 01:12:14 +0000 (01:12 +0000)]
Add verification of variable names in pgbench.

Variables must consist of only alphabets, numerals and underscores.
We had allowed to set variables with invalid names, but could not
refer them in queries.

Thanks to Robert Haas for the review.

14 years agoAdd support for doing FULL JOIN ON FALSE. While this is really a rather
Tom Lane [Tue, 5 Jan 2010 23:25:36 +0000 (23:25 +0000)]
Add support for doing FULL JOIN ON FALSE.  While this is really a rather
peculiar variant of UNION ALL, and so wouldn't likely get written directly
as-is, it's possible for it to arise as a result of simplification of
less-obviously-silly queries.  In particular, now that we can do flattening
of subqueries that have constant outputs and are underneath an outer join,
it's possible for the case to result from simplification of queries of the
type exhibited in bug #5263.  Back-patch to 8.4 to avoid a functionality
regression for this type of query.

14 years agoSupport ALTER TABLESPACE name SET/RESET ( tablespace_options ).
Robert Haas [Tue, 5 Jan 2010 21:54:00 +0000 (21:54 +0000)]
Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).

This patch only supports seq_page_cost and random_page_cost as parameters,
but it provides the infrastructure to scalably support many more.
In particular, we may want to add support for effective_io_concurrency,
but I'm leaving that as future work for now.

Thanks to Tom Lane for design help and Alvaro Herrera for the review.

14 years agoFix genbki.pl and Gen_fmgrtab.pl to use PID-specific temp file names,
Tom Lane [Tue, 5 Jan 2010 20:23:32 +0000 (20:23 +0000)]
Fix genbki.pl and Gen_fmgrtab.pl to use PID-specific temp file names,
so that it's safe if a parallel make chooses to run two concurrent copies.
Also, work around a memory leak in some versions of Perl.

14 years agoAnd another one
Michael Meskes [Tue, 5 Jan 2010 17:10:23 +0000 (17:10 +0000)]
And another one

14 years agoAnd another one of the same problem.
Michael Meskes [Tue, 5 Jan 2010 17:07:51 +0000 (17:07 +0000)]
And another one of the same problem.

14 years agoAnd then forgot to commit the fixed files. ARGH!
Michael Meskes [Tue, 5 Jan 2010 17:05:49 +0000 (17:05 +0000)]
And then forgot to commit the fixed files. ARGH!

14 years agoAh, should read the file completely. I got so used to git that I almost forgot about...
Michael Meskes [Tue, 5 Jan 2010 17:04:18 +0000 (17:04 +0000)]
Ah, should read the file completely. I got so used to git that I almost forgot about the cvs stuff.

14 years agoThrid try. It seems my two checkouts need some cleaning up.
Michael Meskes [Tue, 5 Jan 2010 16:58:37 +0000 (16:58 +0000)]
Thrid try. It seems my two checkouts need some cleaning up.

14 years agoStill not correct.
Michael Meskes [Tue, 5 Jan 2010 16:52:15 +0000 (16:52 +0000)]
Still not correct.

14 years agoAdjusted CVS headers.
Michael Meskes [Tue, 5 Jan 2010 16:49:46 +0000 (16:49 +0000)]
Adjusted CVS headers.

14 years agoApplied patch by Boszormenyi Zoltan <zb@cybertec.at> to add sqlda support to
Michael Meskes [Tue, 5 Jan 2010 16:38:23 +0000 (16:38 +0000)]
Applied patch by Boszormenyi Zoltan <zb@cybertec.at> to add sqlda support to
ecpg in both native and compatiblity mode.

14 years agoMove the default configuration for the MSVC build system to config_default.pl,
Magnus Hagander [Tue, 5 Jan 2010 13:31:58 +0000 (13:31 +0000)]
Move the default configuration for the MSVC build system to config_default.pl,
and allow using config.pl to override the defaults. config.pl is removed from
the repository, so changes there will no longer show up when doing diff, and
will not prevent switching branches and such things.

config.pl would normally be used to override single values, but if an
old-style config.pl is read, it will override the entire default configuration,
making it backwards compatible.

14 years agoDisable linker warning 4197 on Win64, that is caused by the fact that we export
Magnus Hagander [Tue, 5 Jan 2010 11:12:50 +0000 (11:12 +0000)]
Disable linker warning 4197 on Win64, that is caused by the fact that we export
symbols both using __declspec(dllexport) (via the PGDLLIMPORT macro) and using
full-dll-export. This works without warning on Win32, but not on Win64.

In passing, fix the fact that the framework could never deal with more than
one disbled linker warning - because MSVC wants commas between linker warnings,
and semicolons between compiler warnings...

14 years agoUse _mm_pause() for win64 spin_delay(), per note from Tsutomu Yamada.
Magnus Hagander [Tue, 5 Jan 2010 11:06:28 +0000 (11:06 +0000)]
Use _mm_pause() for win64 spin_delay(), per note from Tsutomu Yamada.

14 years agoFurther code review for genbki.pl. Improve comments, fix some
Tom Lane [Tue, 5 Jan 2010 06:41:44 +0000 (06:41 +0000)]
Further code review for genbki.pl.  Improve comments, fix some
rather random code choices, don't slavishly duplicate the original
pg_attribute.h's failure to put an OID into Schema_pg_index entries.

14 years agoFix a few places where we needed -I. in CPPFLAGS to work properly in
Tom Lane [Tue, 5 Jan 2010 03:56:52 +0000 (03:56 +0000)]
Fix a few places where we needed -I. in CPPFLAGS to work properly in
VPATH builds.  We had this already in several places, but not all.