From: Michael Friedrich <michael.friedrich@icinga.com>
Date: Wed, 10 Oct 2018 09:43:11 +0000 (+0200)
Subject: Increase dependency recursion limit to 256
X-Git-Tag: v2.11.0-rc1~318^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=refs%2Fpull%2F6667%2Fhead;p=icinga2

Increase dependency recursion limit to 256

fixes #5762
---

diff --git a/lib/icinga/checkable-dependency.cpp b/lib/icinga/checkable-dependency.cpp
index 65cf386a9..8c0d6e02e 100644
--- a/lib/icinga/checkable-dependency.cpp
+++ b/lib/icinga/checkable-dependency.cpp
@@ -61,9 +61,12 @@ std::vector<Dependency::Ptr> Checkable::GetReverseDependencies() const
 
 bool Checkable::IsReachable(DependencyType dt, Dependency::Ptr *failedDependency, int rstack) const
 {
-	if (rstack > 20) {
+	/* Anything greater than 256 causes recursion bus errors. */
+	int limit = 256;
+
+	if (rstack > limit) {
 		Log(LogWarning, "Checkable")
-			<< "Too many nested dependencies for service '" << GetName() << "': Dependency failed.";
+			<< "Too many nested dependencies (>" << limit << ") for checkable '" << GetName() << "': Dependency failed.";
 
 		return false;
 	}