From: greg <gregory.shklover@gmail.com>
Date: Fri, 7 Oct 2022 00:34:47 +0000 (-0700)
Subject: Increase stack size for dot MSBUILD project file (avoid crash on larger graphs)
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=refs%2Fheads%2Fsmattr%2F7fb8dc28-80f2-4874-bed4-f670f9c83c1b;p=graphviz

Increase stack size for dot MSBUILD project file (avoid crash on larger graphs)

Comment from Matthew Fernandez: It is believed this resolves some instances of
stack overflow in `dfs_enter_outedge` experienced with larger graphs on Windows.

Co-authored-by: Matthew Fernandez <matthew.fernandez@gmail.com>
---

diff --git a/CHANGELOG.md b/CHANGELOG.md
index bc9c1223e..83a962b56 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased (6.0.2)]
 
+### Changed
+
+- Reserved stack size on Windows for the `dot.exe` binary has been increased
+  from the default 1MB to ~3.8MB.
+
 ### Fixed
 
 - Using `aspect` with a custom value in the `packmode` attribute is no longer
diff --git a/cmd/dot/dot.vcxproj b/cmd/dot/dot.vcxproj
index a2b0ca57c..bbfbe4d2e 100644
--- a/cmd/dot/dot.vcxproj
+++ b/cmd/dot/dot.vcxproj
@@ -68,6 +68,7 @@
       <DataExecutionPrevention />
       <TargetMachine>MachineX86</TargetMachine>
       <AdditionalDependencies>cgraph.lib;gvc.lib;%(AdditionalDependencies)</AdditionalDependencies>
+      <StackReserveSize>4000000</StackReserveSize>
     </Link>
     <PostBuildEvent>
       <Command>$(OutDir)dot -c
@@ -98,6 +99,7 @@ copy /B /Y $(OutDir)dot.exe $(OutDir)twopi.exe</Command>
       <DataExecutionPrevention />
       <TargetMachine>MachineX86</TargetMachine>
       <AdditionalDependencies>cgraph.lib;gvc.lib;%(AdditionalDependencies)</AdditionalDependencies>
+      <StackReserveSize>4000000</StackReserveSize>
     </Link>
     <PostBuildEvent>
       <Command>$(OutDir)dot -c