From: Daniel Stenberg <daniel@haxx.se>
Date: Thu, 6 Sep 2018 20:53:42 +0000 (+0200)
Subject: schannel: avoid switch-cases that go to default anyway
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=refs%2Fheads%2Fbagder%2Fschannel-APPLICATION_PROTOCOL_MISMATCH;p=curl

schannel: avoid switch-cases that go to default anyway

SEC_E_APPLICATION_PROTOCOL_MISMATCH isn't defined in some versions of
mingw and would require an ifdef otherwise.

Reported-by: Thomas Glanzmann
Bug: https://curl.haxx.se/mail/lib-2018-09/0020.html
---

diff --git a/lib/vtls/schannel.c b/lib/vtls/schannel.c
index e7d1e3dde..f3ed98d59 100644
--- a/lib/vtls/schannel.c
+++ b/lib/vtls/schannel.c
@@ -802,6 +802,7 @@ schannel_connect_step1(struct connectdata *conn, int sockindex)
         failf(data, "schannel: SNI or certificate check failed: %s",
               Curl_sspi_strerror(conn, sspi_status));
         return CURLE_PEER_FAILED_VERIFICATION;
+        /*
       case SEC_E_INVALID_HANDLE:
       case SEC_E_INVALID_TOKEN:
       case SEC_E_LOGON_DENIED:
@@ -811,6 +812,7 @@ schannel_connect_step1(struct connectdata *conn, int sockindex)
       case SEC_E_NO_CREDENTIALS:
       case SEC_E_UNSUPPORTED_FUNCTION:
       case SEC_E_APPLICATION_PROTOCOL_MISMATCH:
+        */
       default:
         failf(data, "schannel: initial InitializeSecurityContext failed: %s",
               Curl_sspi_strerror(conn, sspi_status));
@@ -1039,6 +1041,7 @@ schannel_connect_step2(struct connectdata *conn, int sockindex)
           failf(data, "schannel: SNI or certificate check failed: %s",
                 Curl_sspi_strerror(conn, sspi_status));
           return CURLE_PEER_FAILED_VERIFICATION;
+          /*
         case SEC_E_INVALID_HANDLE:
         case SEC_E_INVALID_TOKEN:
         case SEC_E_LOGON_DENIED:
@@ -1048,6 +1051,7 @@ schannel_connect_step2(struct connectdata *conn, int sockindex)
         case SEC_E_NO_CREDENTIALS:
         case SEC_E_UNSUPPORTED_FUNCTION:
         case SEC_E_APPLICATION_PROTOCOL_MISMATCH:
+          */
         default:
           failf(data, "schannel: next InitializeSecurityContext failed: %s",
                 Curl_sspi_strerror(conn, sspi_status));