From: Antony Dovgal Date: Tue, 29 Aug 2006 12:20:18 +0000 (+0000) Subject: fix win32 build X-Git-Tag: php-5.2.0RC3~41 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ffc3d4a0760be607ac299068d65fec8a889ba5c9;p=php fix win32 build EG(precision) can be changed in runtime, even in php_implode() (hint: __toString()), so please think twice before optimizing --- diff --git a/ext/standard/string.c b/ext/standard/string.c index f5851fa87d..8e5fb6f819 100644 --- a/ext/standard/string.c +++ b/ext/standard/string.c @@ -920,9 +920,11 @@ PHPAPI void php_implode(zval *delim, zval *arr, zval *return_value TSRMLS_DC) break; case IS_DOUBLE: { - char stmp[MAX_LENGTH_OF_DOUBLE + EG(precision) + 1]; + char *stmp; + stmp = emalloc(MAX_LENGTH_OF_DOUBLE + EG(precision) + 1); str_len = sprintf(stmp, "%.*G", (int) EG(precision), Z_DVAL_PP(tmp)); smart_str_appendl(&implstr, stmp, str_len); + efree(stmp); } break;