From: Thies C. Arntzen <thies@php.net>
Date: Thu, 25 May 2000 07:44:45 +0000 (+0000)
Subject: @- Uncommitted outstanding OCI8 transactions are now rolled back
X-Git-Tag: PRE_EIGHT_BYTE_ALLOC_PATCH~257
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ff53dde157e8a7810e1fab2257ce8b1c2edf74e5;p=php

@- Uncommitted outstanding OCI8 transactions are now rolled back
@  before the connection is closed. (Thies)
---

diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
index c7a078c31a..92d0c57516 100644
--- a/ext/oci8/oci8.c
+++ b/ext/oci8/oci8.c
@@ -654,12 +654,14 @@ _oci_conn_list_dtor(oci_connection *connection)
 	}
 
 	if (connection->pServiceContext) {
-		/*
-		connection->error = 
-			OCITransCommit(connection->pServiceContext,
-						   connection->pError, 
-						   (ub4)0);
-		*/
+		connection->error =
+			OCITransRollback(connection->pServiceContext,
+							 connection->pError,
+							 (ub4)0);
+ 
+		if (connection->error) {
+			oci_error(connection->pError, "failed to rollback outstanding transactions!", connection->error);
+		}
 
 		OCIHandleFree((dvoid *) connection->pServiceContext, (ub4) OCI_HTYPE_SVCCTX);
 	}