From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Sun, 22 Sep 2019 03:26:37 +0000 (-0700)
Subject: Updated incorrect level-setting code to use setLevel(). (GH-16325) (GH-16327)
X-Git-Tag: v3.8.0rc1~53
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fe9089a08b6dd6dd1ba8b238afc2fc4dfaac689e;p=python

Updated incorrect level-setting code to use setLevel(). (GH-16325) (GH-16327)

(cherry picked from commit 1d094af716e8ce5e5710e1dfbce7832ba333be55)
---

diff --git a/Lib/logging/config.py b/Lib/logging/config.py
index cfd93116ee..9dd35e11aa 100644
--- a/Lib/logging/config.py
+++ b/Lib/logging/config.py
@@ -1,4 +1,4 @@
-# Copyright 2001-2016 by Vinay Sajip. All Rights Reserved.
+# Copyright 2001-2019 by Vinay Sajip. All Rights Reserved.
 #
 # Permission to use, copy, modify, and distribute this software and its
 # documentation for any purpose and without fee is hereby granted,
@@ -19,7 +19,7 @@ Configuration functions for the logging package for Python. The core package
 is based on PEP 282 and comments thereto in comp.lang.python, and influenced
 by Apache's log4j system.
 
-Copyright (C) 2001-2016 Vinay Sajip. All Rights Reserved.
+Copyright (C) 2001-2019 Vinay Sajip. All Rights Reserved.
 
 To use, simply 'import logging' and log away!
 """
@@ -173,9 +173,10 @@ def _handle_existing_loggers(existing, child_loggers, disable_existing):
     for log in existing:
         logger = root.manager.loggerDict[log]
         if log in child_loggers:
-            logger.level = logging.NOTSET
-            logger.handlers = []
-            logger.propagate = True
+            if not isinstance(logger, logging.PlaceHolder):
+                logger.setLevel(logging.NOTSET)
+                logger.handlers = []
+                logger.propagate = True
         else:
             logger.disabled = disable_existing
 
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 7399bb362f..37655a5ccc 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -4315,7 +4315,7 @@ class BasicConfigTest(unittest.TestCase):
         logging._handlers.clear()
         logging._handlers.update(self.saved_handlers)
         logging._handlerList[:] = self.saved_handler_list
-        logging.root.level = self.original_logging_level
+        logging.root.setLevel(self.original_logging_level)
 
     def test_no_kwargs(self):
         logging.basicConfig()