From: Bart House <bart@barthouse.com>
Date: Sat, 12 Dec 2020 02:45:44 +0000 (-0800)
Subject: Fix Windows build break caused by bump to lua 5.4.2.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fe874db0b3ee850510c0946f0c1b3c7c3ec842ef;p=nethack

Fix Windows build break caused by bump to lua 5.4.2.

Modified Windows build to use submodules/lua for lua source.
---

diff --git a/.gitmodules b/.gitmodules
new file mode 100644
index 000000000..c08764d7e
--- /dev/null
+++ b/.gitmodules
@@ -0,0 +1,3 @@
+[submodule "submodules/lua"]
+	path = submodules/lua
+	url = https://github.com/lua/lua.git
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index 30324cf9b..2c6eda1c5 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -20,7 +20,7 @@ resources:
 
 steps:
 - checkout: git://NetHack/NetHack@NetHack-3.7  # $(Agent.BuildDirectory)\s\NetHack
-- checkout: luarepo  # $(Agent.BuildDirectory)\s\lua
+  submodules: true
 
 - task: DownloadSecureFile@1
   name: storeKey
diff --git a/submodules/lua b/submodules/lua
new file mode 160000
index 000000000..e2ea3b31c
--- /dev/null
+++ b/submodules/lua
@@ -0,0 +1 @@
+Subproject commit e2ea3b31c94bb3e1da27c233661cb2a16699c685
diff --git a/win/win32/vs/NetHackW.vcxproj b/win/win32/vs/NetHackW.vcxproj
index 61026d3a0..e9b5d7dd5 100644
--- a/win/win32/vs/NetHackW.vcxproj
+++ b/win/win32/vs/NetHackW.vcxproj
@@ -53,6 +53,7 @@
     <ClCompile Include="$(LuaDir)lbitlib.c">
       <ExcludedFromBuild Condition="'$(LUA_VERSION)'=='5.4.0'">true</ExcludedFromBuild>
       <ExcludedFromBuild Condition="'$(LUA_VERSION)'=='5.4.1'">true</ExcludedFromBuild>
+      <ExcludedFromBuild Condition="'$(LUA_VERSION)'=='5.4.2'">true</ExcludedFromBuild>
       <ExcludedFromBuild Condition="'$(LUA_VERSION)'=='5.3.5'">false</ExcludedFromBuild>
     </ClCompile>
     <ClCompile Include="$(LuaDir)lcode.c" />
diff --git a/win/win32/vs/dirs.props b/win/win32/vs/dirs.props
index 05b6543ac..ed8a7554f 100644
--- a/win/win32/vs/dirs.props
+++ b/win/win32/vs/dirs.props
@@ -10,7 +10,7 @@
     <DatDir>$(RootDir)dat\</DatDir>
     <DocDir>$(RootDir)doc\</DocDir>
     <IncDir>$(RootDir)include\</IncDir>
-    <LuaDir>$(RootDir)lib\lua-$(LUA_VERSION)\src\</LuaDir>
+    <LuaDir>$(RootDir)submodules\lua\</LuaDir>
     <SrcDir>$(RootDir)src\</SrcDir>
 	<SysDir>$(RootDir)sys\</SysDir>
     <UtilDir>$(RootDir)util\</UtilDir>
diff --git a/win/win32/vs/makedefs.vcxproj b/win/win32/vs/makedefs.vcxproj
index 190952a6a..f82bb2c9a 100644
--- a/win/win32/vs/makedefs.vcxproj
+++ b/win/win32/vs/makedefs.vcxproj
@@ -55,10 +55,10 @@
       Outputs="$(IncDir)\nhlua.h">
       <Message Text="Generating $(IncDir)nhlua.h" />
 	<Exec Command="echo /* nhlua.h - generated by makdefs.vcxproj ClCompile */ &gt; nhlua.h" WorkingDirectory="$(IncDir)"/>
-	<Exec Command="echo #include %22../lib/lua-$(LUA_VERSION)/src/lua.h%22 &gt;&gt; nhlua.h" WorkingDirectory="$(IncDir)"/>
+	<Exec Command="echo #include %22../submodules/lua/lua.h%22 &gt;&gt; nhlua.h" WorkingDirectory="$(IncDir)"/>
 	<Exec Command="echo LUA_API int (lua_error) (lua_State *L) NORETURN; &gt;&gt; nhlua.h" WorkingDirectory="$(IncDir)"/>
-	<Exec Command="echo #include %22../lib/lua-$(LUA_VERSION)/src/lualib.h%22 &gt;&gt; nhlua.h" WorkingDirectory="$(IncDir)"/>
-	<Exec Command="echo #include %22../lib/lua-$(LUA_VERSION)/src/lauxlib.h%22 &gt;&gt; nhlua.h" WorkingDirectory="$(IncDir)"/>
+	<Exec Command="echo #include %22../submodules/lua/lualib.h%22 &gt;&gt; nhlua.h" WorkingDirectory="$(IncDir)"/>
+	<Exec Command="echo #include %22../submodules/lua/lauxlib.h%22 &gt;&gt; nhlua.h" WorkingDirectory="$(IncDir)"/>
 	<Exec Command="echo /*nhlua.h*/ &gt;&gt; nhlua.h" WorkingDirectory="$(IncDir)"/>
  </Target>
   <Target Name="AfterBuild">