From: Marko Kreen <markokr@gmail.com>
Date: Fri, 26 Oct 2007 15:14:11 +0000 (+0000)
Subject: simpler warning args
X-Git-Tag: pgbouncer_1_2_rc2~138
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fda799ce9acf4dc83b85ae0eaa2a6d10daf6c03d;p=pgbouncer

simpler warning args
---

diff --git a/configure.ac b/configure.ac
index 46acaab..85b7c44 100644
--- a/configure.ac
+++ b/configure.ac
@@ -34,23 +34,16 @@ fi
 
 dnl Additional gcc tuning
 if test x"$GCC" = xyes; then
-  AC_MSG_CHECKING([for working warning swithces])
+  AC_MSG_CHECKING([for working warning switches])
   good_CFLAGS="$CFLAGS"
-  good="-Wall"
-  flags="-Wextra"
-  # turn off noise from Wextra
-  flags="$flags -Wno-unused-parameter -Wno-sign-compare"
-  flags="$flags -Wno-missing-field-initializers"
-  # Wextra does not turn those on?
-  flags="$flags -Wmissing-prototypes -Wpointer-arith -Wendif-labels"
-  flags="$flags -Wdeclaration-after-statement -Wold-style-definition"
-  flags="$flags -Wstrict-prototypes"
-  for f in $flags; do
-    CFLAGS="$good_CFLAGS $good $f"
-    AC_COMPILE_IFELSE([void foo(void){}], [good="$good $f"])
+  warnings=""
+  for f in -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers
+  do
+    CFLAGS="$good_CFLAGS $warnings $f"
+    AC_COMPILE_IFELSE([void foo(void){}], [warnings="$warnings $f"])
   done
-  CFLAGS="$good_CFLAGS $good"
-  AC_MSG_RESULT([$good])
+  CFLAGS="$good_CFLAGS $warnings"
+  AC_MSG_RESULT([$warnings])
 fi
 
 dnl Checks for header files.