From: Alvaro Herrera Date: Mon, 8 Oct 2018 13:37:21 +0000 (-0300) Subject: Silence compiler warning in Assert() X-Git-Tag: REL9_5_15~35 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fd66ca083d460c2f759f99fb77b1fca7e1f3d682;p=postgresql Silence compiler warning in Assert() gcc 6.3 does not whine about this mistake I made in 39808e8868c8 but evidently lots of other compilers do, according to Michael Paquier, Peter Eisentraut, Arthur Zakirov, Tomas Vondra. Discussion: too many to list --- diff --git a/src/backend/commands/event_trigger.c b/src/backend/commands/event_trigger.c index 4a61044858..813d3d86a7 100644 --- a/src/backend/commands/event_trigger.c +++ b/src/backend/commands/event_trigger.c @@ -1765,7 +1765,7 @@ EventTriggerCollectAlterTableSubcmd(Node *subcmd, ObjectAddress address) return; Assert(IsA(subcmd, AlterTableCmd)); - Assert(OidIsValid(currentEventTriggerState->currentCommand)); + Assert(currentEventTriggerState->currentCommand != NULL); Assert(OidIsValid(currentEventTriggerState->currentCommand->d.alterTable.objectId)); oldcxt = MemoryContextSwitchTo(currentEventTriggerState->cxt);