From: Magnus Jacobsson Date: Sun, 2 Jan 2022 13:08:50 +0000 (+0100) Subject: patchwork: MSBuild: define GVDLL to ensure correct storage-class attributes X-Git-Tag: 3.0.0~84^2~15 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fd5c4d60f2acdb4e9713423c7722f24fe35c7f9a;p=graphviz patchwork: MSBuild: define GVDLL to ensure correct storage-class attributes An upcoming commit will change the storage-class attributes in globals.h to be controlled only by the GVDLL symbol, not also by the WIN32_DLL symbol. Without this change, errors like this would occur: patchwork.lib(patchworkinit.obj) : error LNK2001: unresolved external symbol _Ndim Towards https://gitlab.com/graphviz/graphviz/-/issues/2173. --- diff --git a/lib/patchwork/gvpatchwork.vcxproj b/lib/patchwork/gvpatchwork.vcxproj index 5004cfa8a..5b947b177 100644 --- a/lib/patchwork/gvpatchwork.vcxproj +++ b/lib/patchwork/gvpatchwork.vcxproj @@ -53,7 +53,7 @@ Disabled $(ProjectDir);$(SolutionDir)windows\include;$(SolutionDir)lib;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;$(SolutionDir)lib\gvc;$(SolutionDir)lib\pack;$(SolutionDir)lib\pathplan;%(AdditionalIncludeDirectories) - _DEBUG;_LIB;WIN32_DLL;%(PreprocessorDefinitions) + _DEBUG;_LIB;GVDLL;WIN32_DLL;%(PreprocessorDefinitions) EnableFastChecks MultiThreadedDebugDLL @@ -67,7 +67,7 @@ $(ProjectDir);$(SolutionDir)windows\include;$(SolutionDir)lib;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;$(SolutionDir)lib\gvc;$(SolutionDir)lib\pack;$(SolutionDir)lib\pathplan;%(AdditionalIncludeDirectories) - NDEBUG;_LIB;WIN32_DLL;%(PreprocessorDefinitions) + NDEBUG;_LIB;GVDLL;WIN32_DLL;%(PreprocessorDefinitions) Level4 true