From: Walter Dörwald <walter@livinglogic.de>
Date: Mon, 2 Sep 2002 16:10:06 +0000 (+0000)
Subject: Limit the length of attribute names in exception messages
X-Git-Tag: v2.3c1~4237
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fd08e4c9edf63590c23ffb6f68c43d5015078c0b;p=python

Limit the length of attribute names in exception messages
to prevent buffer overflows (spotted by Neal Norwitz).
---

diff --git a/Python/exceptions.c b/Python/exceptions.c
index 1667cd9b66..47a4e4d09c 100644
--- a/Python/exceptions.c
+++ b/Python/exceptions.c
@@ -852,7 +852,7 @@ int get_int(PyObject *exc, const char *name, int *value)
     if (!attr)
 	return -1;
     if (!PyInt_Check(attr)) {
-	PyErr_Format(PyExc_TypeError, "%s attribute must be int", name);
+	PyErr_Format(PyExc_TypeError, "%.200s attribute must be int", name);
 	Py_DECREF(attr);
 	return -1;
     }
@@ -884,7 +884,7 @@ PyObject *get_string(PyObject *exc, const char *name)
     if (!attr)
 	return NULL;
     if (!PyString_Check(attr)) {
-	PyErr_Format(PyExc_TypeError, "%s attribute must be str", name);
+	PyErr_Format(PyExc_TypeError, "%.200s attribute must be str", name);
 	Py_DECREF(attr);
 	return NULL;
     }
@@ -914,7 +914,7 @@ PyObject *get_unicode(PyObject *exc, const char *name)
     if (!attr)
 	return NULL;
     if (!PyUnicode_Check(attr)) {
-	PyErr_Format(PyExc_TypeError, "%s attribute must be unicode", name);
+	PyErr_Format(PyExc_TypeError, "%.200s attribute must be unicode", name);
 	Py_DECREF(attr);
 	return NULL;
     }