From: Stefan Krah <skrah@bytereef.org>
Date: Mon, 5 Mar 2012 09:45:31 +0000 (+0100)
Subject: Issue #10181: The decision was to raise a buffer error in memory_exit()
X-Git-Tag: v3.3.0a2~276^2~24
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fcbb4169b982ce06c5701ad18898084dfa569598;p=python

Issue #10181: The decision was to raise a buffer error in memory_exit()
if the view has exported buffers. Make this official by uncommenting
a test case.
---

diff --git a/Lib/test/test_buffer.py b/Lib/test/test_buffer.py
index e53246064e..8a8d55db5b 100644
--- a/Lib/test/test_buffer.py
+++ b/Lib/test/test_buffer.py
@@ -3484,11 +3484,12 @@ class TestBufferProtocol(unittest.TestCase):
                         self.assertEqual(m3[2], ord(b'3'))
                         del m1, m2, m3
 
-        # XXX If m1 has exports, raise BufferError.
-        # x = bytearray(b'123')
-        # with memoryview(x) as m1:
-        #     ex = ndarray(m1)
-        #     m1[0] == ord(b'1')
+        # memoryview.release() fails if the view has exported buffers.
+        x = bytearray(b'123')
+        with self.assertRaises(BufferError):
+            with memoryview(x) as m:
+                ex = ndarray(m)
+                m[0] == ord(b'1')
 
     def test_memoryview_redirect(self):