From: Ilia Alshanetsky <iliaa@php.net>
Date: Tue, 21 Feb 2006 15:32:34 +0000 (+0000)
Subject: MFB51: Fixed bug #36458 (sleep() accepts negative values).
X-Git-Tag: RELEASE_1_2~135
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fca6eecbe944effb6374e63271a008947b266e64;p=php

MFB51: Fixed bug #36458 (sleep() accepts negative values).
---

diff --git a/ext/standard/basic_functions.c b/ext/standard/basic_functions.c
index ea54c27967..1738fb9a74 100644
--- a/ext/standard/basic_functions.c
+++ b/ext/standard/basic_functions.c
@@ -1677,17 +1677,19 @@ PHP_FUNCTION(flush)
    Delay for a given number of seconds */
 PHP_FUNCTION(sleep)
 {
-	zval **num;
+	long num;
 
-	if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &num) == FAILURE) {
-		WRONG_PARAM_COUNT;
+	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &num) == FAILURE) {
+		RETURN_FALSE;
+	}
+	if (num < 0) {
+		php_error_docref(NULL TSRMLS_CC, E_WARNING, "Number of seconds must be greater than or equal to 0");
+		RETURN_FALSE;
 	}
-
-	convert_to_long_ex(num);
 #ifdef PHP_SLEEP_NON_VOID
-	RETURN_LONG(php_sleep(Z_LVAL_PP(num)));
+	RETURN_LONG(php_sleep(num));
 #else
-	php_sleep(Z_LVAL_PP(num));
+	php_sleep(num);
 #endif
 
 }