From: Ted Kremenek <kremenek@apple.com>
Date: Thu, 11 Jun 2009 18:10:48 +0000 (+0000)
Subject: Refactor some function name -> summary lookup using a switch statement.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fc63aa3fc9980ccf41b9d1b05cea041b5cf07b9e;p=clang

Refactor some function name -> summary lookup using a switch statement.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@73197 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/CFRefCount.cpp b/lib/Analysis/CFRefCount.cpp
index 532d16da0f..2053d2c86c 100644
--- a/lib/Analysis/CFRefCount.cpp
+++ b/lib/Analysis/CFRefCount.cpp
@@ -971,15 +971,31 @@ RetainSummary* RetainSummaryManager::getSummary(FunctionDecl* FD) {
     
     // FIXME: This should all be refactored into a chain of "summary lookup"
     //  filters.
-    if (strcmp(FName, "IOServiceGetMatchingServices") == 0) {
-      // FIXES: <rdar://problem/6326900>
-      // This should be addressed using a API table.  This strcmp is also
-      // a little gross, but there is no need to super optimize here.
-      assert (ScratchArgs.isEmpty());
-      ScratchArgs = AF.Add(ScratchArgs, 1, DecRef);
-      S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
-      break;
-    }
+		switch (strlen(FName)) {
+			default: break;
+			case 17:
+				// Handle: id NSMakeCollectable(CFTypeRef)
+				if (!memcmp(FName, "NSMakeCollectable", 17)) {
+					S = (RetTy == Ctx.getObjCIdType())
+							? getUnarySummary(FT, cfmakecollectable)
+							: getPersistentStopSummary();
+				}
+				break;
+			case 28:
+				if (!memcmp(FName, "IOServiceGetMatchingServices", 28)) {
+					// FIXES: <rdar://problem/6326900>
+					// This should be addressed using a API table.  This strcmp is also
+					// a little gross, but there is no need to super optimize here.
+					assert (ScratchArgs.isEmpty());
+					ScratchArgs = AF.Add(ScratchArgs, 1, DecRef);
+					S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
+				}
+				break;
+		}
+		
+		// Did we get a summary?
+		if (S)
+			break;
 
     // Enable this code once the semantics of NSDeallocateObject are resolved
     // for GC.  <rdar://problem/6619988>
@@ -992,15 +1008,6 @@ RetainSummary* RetainSummaryManager::getSummary(FunctionDecl* FD) {
         : getPersistentStopSummary();
     }
 #endif
-    
-    // Handle: id NSMakeCollectable(CFTypeRef)
-    if (strcmp(FName, "NSMakeCollectable") == 0) {
-      S = (RetTy == Ctx.getObjCIdType())
-          ? getUnarySummary(FT, cfmakecollectable)
-          : getPersistentStopSummary();
-        
-      break;
-    }
 
     if (RetTy->isPointerType()) {
       // For CoreFoundation ('CF') types.