From: Serhiy Storchaka <storchaka@gmail.com>
Date: Thu, 5 Jul 2018 08:17:20 +0000 (+0300)
Subject: bpo-33720: Improve tests for the stack overflow in marshal.loads(). (GH-7336)
X-Git-Tag: v3.8.0a1~1440
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fc05e68d8fac70349b7ea17ec14e7e0cfa956121;p=python

bpo-33720: Improve tests for the stack overflow in marshal.loads(). (GH-7336)
---

diff --git a/Lib/test/test_marshal.py b/Lib/test/test_marshal.py
index a8a43d22bc..a20ad677c8 100644
--- a/Lib/test/test_marshal.py
+++ b/Lib/test/test_marshal.py
@@ -210,13 +210,24 @@ class BugsTestCase(unittest.TestCase):
             except Exception:
                 pass
 
-    def test_loads_2x_code(self):
-        s = b'c' + (b'X' * 4*4) + b'{' * 2**20
-        self.assertRaises(ValueError, marshal.loads, s)
-
     def test_loads_recursion(self):
-        s = b'c' + (b'X' * 4*5) + b'{' * 2**20
-        self.assertRaises(ValueError, marshal.loads, s)
+        def run_tests(N, check):
+            # (((...None...),),)
+            check(b')\x01' * N + b'N')
+            check(b'(\x01\x00\x00\x00' * N + b'N')
+            # [[[...None...]]]
+            check(b'[\x01\x00\x00\x00' * N + b'N')
+            # {None: {None: {None: ...None...}}}
+            check(b'{N' * N + b'N' + b'0' * N)
+            # frozenset([frozenset([frozenset([...None...])])])
+            check(b'>\x01\x00\x00\x00' * N + b'N')
+        # Check that the generated marshal data is valid and marshal.loads()
+        # works for moderately deep nesting
+        run_tests(100, marshal.loads)
+        # Very deeply nested structure shouldn't blow the stack
+        def check(s):
+            self.assertRaises(ValueError, marshal.loads, s)
+        run_tests(2**20, check)
 
     def test_recursion_limit(self):
         # Create a deeply nested structure.