From: Devin Coughlin Date: Wed, 2 Mar 2016 21:22:48 +0000 (+0000) Subject: [analyzer] Fix capitalization in ObjCSuperDeallocChecker diagnostic. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fbec52f0715d6f4459aef26f17e5311fb8f903f1;p=clang [analyzer] Fix capitalization in ObjCSuperDeallocChecker diagnostic. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@262520 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp b/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp index 8618eeb0df..eb31321895 100644 --- a/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp +++ b/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp @@ -165,7 +165,7 @@ void ObjCSuperDeallocChecker::checkLocation(SVal L, bool IsLoad, const Stmt *S, std::string Buf; llvm::raw_string_ostream OS(Buf); if (IvarRegion) { - OS << "use of instance variable '" << *IvarRegion->getDecl() << + OS << "Use of instance variable '" << *IvarRegion->getDecl() << "' after 'self' has been deallocated"; Desc = OS.str(); } diff --git a/test/Analysis/DeallocUseAfterFreeErrors.m b/test/Analysis/DeallocUseAfterFreeErrors.m index cfb202b650..2902be694b 100644 --- a/test/Analysis/DeallocUseAfterFreeErrors.m +++ b/test/Analysis/DeallocUseAfterFreeErrors.m @@ -36,8 +36,8 @@ typedef struct objc_selector *SEL; } - (void)dealloc { [super dealloc]; // expected-note {{[super dealloc] called here}} - [_ivar release]; // expected-warning {{use of instance variable '_ivar' after 'self' has been deallocated}} - // expected-note@-1 {{use of instance variable '_ivar' after 'self' has been deallocated}} + [_ivar release]; // expected-warning {{Use of instance variable '_ivar' after 'self' has been deallocated}} + // expected-note@-1 {{Use of instance variable '_ivar' after 'self' has been deallocated}} } @end @@ -56,8 +56,8 @@ typedef struct objc_selector *SEL; } - (void)dealloc { [super dealloc]; // expected-note {{[super dealloc] called here}} - _delegate = nil; // expected-warning {{use of instance variable '_delegate' after 'self' has been deallocated}} - // expected-note@-1 {{use of instance variable '_delegate' after 'self' has been deallocated}} + _delegate = nil; // expected-warning {{Use of instance variable '_delegate' after 'self' has been deallocated}} + // expected-note@-1 {{Use of instance variable '_delegate' after 'self' has been deallocated}} } @end @@ -74,8 +74,8 @@ struct SomeStruct { @implementation SuperDeallocThenAssignIvarField - (void)dealloc { [super dealloc]; // expected-note {{[super dealloc] called here}} - _s.f = 7; // expected-warning {{use of instance variable '_s' after 'self' has been deallocated}} - // expected-note@-1 {{use of instance variable '_s' after 'self' has been deallocated}} + _s.f = 7; // expected-warning {{Use of instance variable '_s' after 'self' has been deallocated}} + // expected-note@-1 {{Use of instance variable '_s' after 'self' has been deallocated}} } @end @@ -93,8 +93,8 @@ struct SomeStruct { @implementation SuperDeallocThenAssignIvarIvar - (void)dealloc { [super dealloc]; // expected-note {{[super dealloc] called here}} - _ivar->_otherIvar = 7; // expected-warning {{use of instance variable '_ivar' after 'self' has been deallocated}} - // expected-note@-1 {{use of instance variable '_ivar' after 'self' has been deallocated}} + _ivar->_otherIvar = 7; // expected-warning {{Use of instance variable '_ivar' after 'self' has been deallocated}} + // expected-note@-1 {{Use of instance variable '_ivar' after 'self' has been deallocated}} } @end @@ -106,8 +106,8 @@ struct SomeStruct { @implementation SuperDeallocThenAssignSelfIvar - (void)dealloc { [super dealloc]; // expected-note {{[super dealloc] called here}} - self->_ivar = nil; // expected-warning {{use of instance variable '_ivar' after 'self' has been deallocated}} - // expected-note@-1 {{use of instance variable '_ivar' after 'self' has been deallocated}} + self->_ivar = nil; // expected-warning {{Use of instance variable '_ivar' after 'self' has been deallocated}} + // expected-note@-1 {{Use of instance variable '_ivar' after 'self' has been deallocated}} } @end