From: Antony Dovgal <tony2001@php.net>
Date: Fri, 21 Sep 2007 14:05:01 +0000 (+0000)
Subject: check the return value of getgroups() for -1 (coverity issue #390)
X-Git-Tag: RELEASE_2_0_0a1~1770
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fba42a8530ff596ef156a9ee5fe795f2d91b0dfe;p=php

check the return value of getgroups() for -1 (coverity issue #390)
---

diff --git a/ext/standard/filestat.c b/ext/standard/filestat.c
index 3ace3c7551..60a3a53ccb 100644
--- a/ext/standard/filestat.c
+++ b/ext/standard/filestat.c
@@ -877,7 +877,7 @@ PHPAPI void php_stat(const char *filename, php_stat_len filename_length, int typ
 			gid_t *gids;
 
 			groups = getgroups(0, NULL);
-			if(groups) {
+			if(groups > 0) {
 				gids=(gid_t *)safe_emalloc(groups, sizeof(gid_t), 0);
 				n=getgroups(groups, gids);
 				for(i=0;i<n;i++){