From: William A. Rowe Jr Date: Mon, 26 Aug 2002 20:16:33 +0000 (+0000) Subject: The documentation says: ISAPIReadAheadBuffer defaults to 49152 bytes, X-Git-Tag: AGB_BEFORE_AAA_CHANGES~155 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fb63c7872f6d3ab55dd6470872ece87696e38d20;p=apache The documentation says: ISAPIReadAheadBuffer defaults to 49152 bytes, which is exactly 48 kb. But the module actually uses a default of 48192 bytes. This seems to be a typo. Instead of changing the documentation I attached a patch for mod_isapi.c to set the default value of ISAPIReadAheadBuffer to 49152. Submitted by: Astrid Ke�ler git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@96534 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/CHANGES b/CHANGES index 3d411b6e20..bb9264098b 100644 --- a/CHANGES +++ b/CHANGES @@ -1,5 +1,8 @@ Changes with Apache 2.0.41 + *) Correct ISAPIReadAheadBuffer to default to 49152, per mod_isapi docs. + [André Malo, Astrid Keßler ] + *) Fix Segfault in mod_cache. [Kris Verbeeck ] *) Fix a null pointer dereference in the merge_env_dir_configs diff --git a/modules/arch/win32/mod_isapi.c b/modules/arch/win32/mod_isapi.c index 21cf62ca23..040c4f81f5 100644 --- a/modules/arch/win32/mod_isapi.c +++ b/modules/arch/win32/mod_isapi.c @@ -209,7 +209,7 @@ static const command_rec isapi_cmds[] = { AP_INIT_TAKE1("ISAPIReadAheadBuffer", ap_set_int_slot, (void *)APR_OFFSETOF(isapi_dir_conf, read_ahead_buflen), OR_FILEINFO, "Maximum client request body to initially pass to the" - " ISAPI handler (default: 48192)"), + " ISAPI handler (default: 49152)"), AP_INIT_FLAG("ISAPILogNotSupported", ap_set_flag_slot, (void *)APR_OFFSETOF(isapi_dir_conf, log_unsupported), OR_FILEINFO, "Log requests not supported by the ISAPI server" @@ -1362,7 +1362,7 @@ apr_status_t isapi_handler (request_rec *r) /* Fixup defaults for dconf */ cid->dconf.read_ahead_buflen = (dconf->read_ahead_buflen == ISAPI_UNDEF) - ? 48192 : dconf->read_ahead_buflen; + ? 49152 : dconf->read_ahead_buflen; cid->dconf.log_unsupported = (dconf->log_unsupported == ISAPI_UNDEF) ? 0 : dconf->log_unsupported; cid->dconf.log_to_errlog = (dconf->log_to_errlog == ISAPI_UNDEF)