From: Shoaib Meenai <smeenai@fb.com>
Date: Thu, 31 Jan 2019 20:32:45 +0000 (+0000)
Subject: [cmake] Note future cleanup in comment. NFC
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fafbf5786f0d991172ddbff01f7d95f50fbcb5db;p=llvm

[cmake] Note future cleanup in comment. NFC

CMake 3.6 introduced CMAKE_TRY_COMPILE_PLATFORM_VARIABLES, which solves
precisely the problem that necessitated init_user_prop, so we can switch
over whenever we bump our minimum CMake requirement.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@352790 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/cmake/platforms/WinMsvc.cmake b/cmake/platforms/WinMsvc.cmake
index f625d0e3c05..d038df97951 100644
--- a/cmake/platforms/WinMsvc.cmake
+++ b/cmake/platforms/WinMsvc.cmake
@@ -92,7 +92,9 @@
 # won't see the value of any arguments the user passed via -D.  Since these are
 # necessary to properly configure MSVC in both the top-level configuration as well as
 # all feature-test invocations, we set environment variables with the values so that
-# these environments get inherited by child invocations.
+# these environments get inherited by child invocations. We can switch to
+# CMAKE_TRY_COMPILE_PLATFORM_VARIABLES once our minimum supported CMake version
+# is 3.6 or greater.
 function(init_user_prop prop)
   if(${prop})
     set(ENV{_${prop}} "${${prop}}")