From: Florent Xicluna <florent.xicluna@gmail.com>
Date: Mon, 8 Mar 2010 10:59:33 +0000 (+0000)
Subject: Replace the stderr logging with assertNotEqual(returncode, 0).
X-Git-Tag: v2.7b1~415
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=faf175385de454a99edef26986637fc80c8aaba7;p=python

Replace the stderr logging with assertNotEqual(returncode, 0).
---

diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 027546b047..dc57c46b45 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -770,7 +770,7 @@ class Win32ProcessTestCase(unittest.TestCase):
         p = subprocess.Popen([sys.executable, "-c", "input()"],
                              stdin=subprocess.PIPE)
 
-        # Let the process initialize
+        # Let the process initialize (Issue #3137)
         time.sleep(0.1)
         # The process should not terminate prematurely
         self.assertIsNone(p.poll())
@@ -786,10 +786,8 @@ class Win32ProcessTestCase(unittest.TestCase):
         if count > 1:
             print >>sys.stderr, ("p.{}{} succeeded after "
                                  "{} attempts".format(method, args, count))
-        if returncode == 0:
-            # On some win32 platforms, it returns 0. See #2777.
-            print >>sys.stderr, "p.{}{} returned 0".format(method, args)
         self.assertEqual(p.wait(), returncode)
+        self.assertNotEqual(returncode, 0)
 
     def test_send_signal(self):
         self._kill_process('send_signal', signal.SIGTERM)