From: Chris Lattner Date: Fri, 3 Sep 2010 04:34:38 +0000 (+0000) Subject: "I see dead code". IdempotentOperationChecker::isTruncationExtensionAssignment X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fae962200efef618d1c24c14b9c3fed25876f059;p=clang "I see dead code". IdempotentOperationChecker::isTruncationExtensionAssignment should probably be removed if it has no purpose, but I just #if'd it out in case it's usefulIdempotentOperationChecker::isTruncationExtensionAssignment should probably be removed if it has no purpose, but I just #if'd it out in case it's useful git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@112949 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Checker/IdempotentOperationChecker.cpp b/lib/Checker/IdempotentOperationChecker.cpp index f6970de783..6411c790ef 100644 --- a/lib/Checker/IdempotentOperationChecker.cpp +++ b/lib/Checker/IdempotentOperationChecker.cpp @@ -78,8 +78,8 @@ class IdempotentOperationChecker // False positive reduction methods static bool isSelfAssign(const Expr *LHS, const Expr *RHS); static bool isUnused(const Expr *E, AnalysisContext *AC); - static bool isTruncationExtensionAssignment(const Expr *LHS, - const Expr *RHS); + //static bool isTruncationExtensionAssignment(const Expr *LHS, + // const Expr *RHS); static bool PathWasCompletelyAnalyzed(const CFG *C, const CFGBlock *CB, const GRCoreEngine &CE); @@ -500,6 +500,7 @@ bool IdempotentOperationChecker::isUnused(const Expr *E, return true; } +#if 0 // Check for self casts truncating/extending a variable bool IdempotentOperationChecker::isTruncationExtensionAssignment( const Expr *LHS, @@ -522,6 +523,7 @@ bool IdempotentOperationChecker::isTruncationExtensionAssignment( return dyn_cast(RHS->IgnoreParens()) == NULL; } +#endif // Returns false if a path to this block was not completely analyzed, or true // otherwise. diff --git a/lib/Checker/MallocChecker.cpp b/lib/Checker/MallocChecker.cpp index ac98c89a8d..c9b6d7588b 100644 --- a/lib/Checker/MallocChecker.cpp +++ b/lib/Checker/MallocChecker.cpp @@ -32,10 +32,10 @@ public: RefState(Kind k, const Stmt *s) : K(k), S(s) {} bool isAllocated() const { return K == AllocateUnchecked; } - bool isFailed() const { return K == AllocateFailed; } + //bool isFailed() const { return K == AllocateFailed; } bool isReleased() const { return K == Released; } - bool isEscaped() const { return K == Escaped; } - bool isRelinquished() const { return K == Relinquished; } + //bool isEscaped() const { return K == Escaped; } + //bool isRelinquished() const { return K == Relinquished; } bool operator==(const RefState &X) const { return K == X.K && S == X.S; diff --git a/lib/Checker/SimpleSValuator.cpp b/lib/Checker/SimpleSValuator.cpp index 5b48e7cd03..782cd4f5e6 100644 --- a/lib/Checker/SimpleSValuator.cpp +++ b/lib/Checker/SimpleSValuator.cpp @@ -848,8 +848,6 @@ SVal SimpleSValuator::EvalBinOpLN(const GRState *state, rightI.extOrTrunc(leftI.getBitWidth()); // Offset the increment by the pointer size. - ASTContext &ctx = ValMgr.getContext(); - const PointerType *PT = resultTy->getAs(); llvm::APSInt Multiplicand(rightI.getBitWidth(), /* isUnsigned */ true); rightI *= Multiplicand; diff --git a/lib/Checker/StreamChecker.cpp b/lib/Checker/StreamChecker.cpp index 5bc075f6bf..8553875a24 100644 --- a/lib/Checker/StreamChecker.cpp +++ b/lib/Checker/StreamChecker.cpp @@ -31,8 +31,8 @@ struct StreamState { bool isOpened() const { return K == Opened; } bool isClosed() const { return K == Closed; } - bool isOpenFailed() const { return K == OpenFailed; } - bool isEscaped() const { return K == Escaped; } + //bool isOpenFailed() const { return K == OpenFailed; } + //bool isEscaped() const { return K == Escaped; } bool operator==(const StreamState &X) const { return K == X.K && S == X.S; diff --git a/lib/Rewrite/DeltaTree.cpp b/lib/Rewrite/DeltaTree.cpp index 35e888bcf5..085dfd89ef 100644 --- a/lib/Rewrite/DeltaTree.cpp +++ b/lib/Rewrite/DeltaTree.cpp @@ -116,7 +116,7 @@ namespace { void Destroy(); - static inline bool classof(const DeltaTreeNode *) { return true; } + //static inline bool classof(const DeltaTreeNode *) { return true; } }; } // end anonymous namespace @@ -133,12 +133,6 @@ namespace { public: DeltaTreeInteriorNode() : DeltaTreeNode(false /*nonleaf*/) {} - DeltaTreeInteriorNode(DeltaTreeNode *FirstChild) - : DeltaTreeNode(false /*nonleaf*/) { - FullDelta = FirstChild->FullDelta; - Children[0] = FirstChild; - } - DeltaTreeInteriorNode(const InsertResult &IR) : DeltaTreeNode(false /*nonleaf*/) { Children[0] = IR.LHS; @@ -157,7 +151,7 @@ namespace { return Children[i]; } - static inline bool classof(const DeltaTreeInteriorNode *) { return true; } + //static inline bool classof(const DeltaTreeInteriorNode *) { return true; } static inline bool classof(const DeltaTreeNode *N) { return !N->isLeaf(); } }; } diff --git a/lib/Sema/SemaStmt.cpp b/lib/Sema/SemaStmt.cpp index b7d38e44ae..083e4dba85 100644 --- a/lib/Sema/SemaStmt.cpp +++ b/lib/Sema/SemaStmt.cpp @@ -1576,7 +1576,6 @@ public: return t == other.t; } - QualType getQualType() const { return t; } CXXCatchStmt *getCatchStmt() const { return stmt; } SourceLocation getTypeSpecStartLoc() const { return stmt->getExceptionDecl()->getTypeSpecStartLoc();