From: Pierrick Charron Date: Wed, 26 Dec 2012 01:45:24 +0000 (-0500) Subject: Remove a useless memory write in zend_llist_del_element X-Git-Tag: php-5.3.21RC1~4 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fad960a4045da86cdbd8308a165ffc47892f05b9;p=php Remove a useless memory write in zend_llist_del_element The zend_llist_element *next pointer is not necessary and removing it will also remove a write on memory --- diff --git a/Zend/zend_llist.c b/Zend/zend_llist.c index 4656420781..26baf4d958 100644 --- a/Zend/zend_llist.c +++ b/Zend/zend_llist.c @@ -91,15 +91,13 @@ ZEND_API void zend_llist_prepend_element(zend_llist *l, void *element) ZEND_API void zend_llist_del_element(zend_llist *l, void *element, int (*compare)(void *element1, void *element2)) { zend_llist_element *current=l->head; - zend_llist_element *next; while (current) { - next = current->next; if (compare(current->data, element)) { DEL_LLIST_ELEMENT(current, l); break; } - current = next; + current = current->next; } }