From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Tue, 1 Feb 2022 10:26:56 +0000 (+1100)
Subject: test 1594: [nfc] tell 'subprocess' to discard stdout
X-Git-Tag: 3.0.0~44^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fa3e039b44b3758ff82dba5afd733af883ca3fc1;p=graphviz

test 1594: [nfc] tell 'subprocess' to discard stdout

This test case was capturing stdout and then discarding it. It is more efficient
to just attach stdout directly to /dev/null.
---

diff --git a/rtest/test_regression.py b/rtest/test_regression.py
index b12a4f785..5fe096c61 100644
--- a/rtest/test_regression.py
+++ b/rtest/test_regression.py
@@ -509,7 +509,7 @@ def test_1594():
 
   # run GVPR with our (malformed) input program
   with subprocess.Popen(["gvpr", "-f", input], stdin=subprocess.PIPE,
-                        stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+                        stdout=subprocess.DEVNULL, stderr=subprocess.PIPE,
                         universal_newlines=True) as p:
     _, stderr = p.communicate()