From: Arne de Laat <arne@delaat.net>
Date: Thu, 23 Feb 2017 16:16:56 +0000 (+0100)
Subject: bpo-28911: Clarify the behaviour of assert_called_once_with. (#254)
X-Git-Tag: v3.5.4rc1~330
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fa30453568ae71861aa1928373bd76da4f3a33f6;p=python

bpo-28911: Clarify the behaviour of assert_called_once_with. (#254)

(cherry picked from commit 9d56b34af2efc4e266bf3ae62da5cd2e422a42be)
---

diff --git a/Doc/library/unittest.mock.rst b/Doc/library/unittest.mock.rst
index 4b9dac402f..1169f0b5d3 100644
--- a/Doc/library/unittest.mock.rst
+++ b/Doc/library/unittest.mock.rst
@@ -275,14 +275,14 @@ the *new_callable* argument to :func:`patch`.
 
     .. method:: assert_called_once_with(*args, **kwargs)
 
-       Assert that the mock was called exactly once and with the specified
-       arguments.
+       Assert that the mock was called exactly once and that that call was
+       with the specified arguments.
 
             >>> mock = Mock(return_value=None)
             >>> mock('foo', bar='baz')
             >>> mock.assert_called_once_with('foo', bar='baz')
-            >>> mock('foo', bar='baz')
-            >>> mock.assert_called_once_with('foo', bar='baz')
+            >>> mock('other', bar='values')
+            >>> mock.assert_called_once_with('other', bar='values')
             Traceback (most recent call last):
               ...
             AssertionError: Expected 'mock' to be called once. Called 2 times.
@@ -294,7 +294,8 @@ the *new_callable* argument to :func:`patch`.
 
         The assert passes if the mock has *ever* been called, unlike
         :meth:`assert_called_with` and :meth:`assert_called_once_with` that
-        only pass if the call is the most recent one.
+        only pass if the call is the most recent one, and in the case of
+        :meth:`assert_called_once_with` it must also be the only call.
 
             >>> mock = Mock(return_value=None)
             >>> mock(1, 2, arg='thing')
diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
index 0512cca4e2..9bc40bc2d1 100644
--- a/Lib/unittest/mock.py
+++ b/Lib/unittest/mock.py
@@ -795,8 +795,8 @@ class NonCallableMock(Base):
 
 
     def assert_called_once_with(_mock_self, *args, **kwargs):
-        """assert that the mock was called exactly once and with the specified
-        arguments."""
+        """assert that the mock was called exactly once and that that call was
+        with the specified arguments."""
         self = _mock_self
         if not self.call_count == 1:
             msg = ("Expected '%s' to be called once. Called %s times." %