From: Duncan P. N. Exon Smith <dexonsmith@apple.com>
Date: Thu, 20 Mar 2014 03:17:15 +0000 (+0000)
Subject: PGO: Separate out common isMachO logic; no functionality change
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fa2fda07c1d03cc695a93faae652c09eb464fc1d;p=clang

PGO: Separate out common isMachO logic; no functionality change

<rdar://problem/15943240>

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@204297 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/CodeGenPGO.cpp b/lib/CodeGen/CodeGenPGO.cpp
index 1f2fe38c40..86df30e547 100644
--- a/lib/CodeGen/CodeGenPGO.cpp
+++ b/lib/CodeGen/CodeGenPGO.cpp
@@ -221,25 +221,20 @@ static llvm::Constant *getOrInsertRuntimeWriteAtExit(CodeGenModule &CGM) {
                                              WriteAtExitTy);
 }
 
+static bool isMachO(const CodeGenModule &CGM) {
+  return CGM.getTarget().getTriple().isOSBinFormatMachO();
+}
+
 static StringRef getCountersSection(const CodeGenModule &CGM) {
-  if (CGM.getTarget().getTriple().isOSBinFormatMachO())
-    return "__DATA,__llvm_pgo_cnts";
-  else
-    return "__llvm_pgo_cnts";
+  return isMachO(CGM) ? "__DATA,__llvm_pgo_cnts" : "__llvm_pgo_cnts";
 }
 
 static StringRef getNameSection(const CodeGenModule &CGM) {
-  if (CGM.getTarget().getTriple().isOSBinFormatMachO())
-    return "__DATA,__llvm_pgo_names";
-  else
-    return "__llvm_pgo_names";
+  return isMachO(CGM) ? "__DATA,__llvm_pgo_names" : "__llvm_pgo_names";
 }
 
 static StringRef getDataSection(const CodeGenModule &CGM) {
-  if (CGM.getTarget().getTriple().isOSBinFormatMachO())
-    return "__DATA,__llvm_pgo_data";
-  else
-    return "__llvm_pgo_data";
+  return isMachO(CGM) ? "__DATA,__llvm_pgo_data" : "__llvm_pgo_data";
 }
 
 llvm::GlobalVariable *CodeGenPGO::buildDataVar() {