From: Antony Dovgal Date: Wed, 20 Dec 2006 19:08:23 +0000 (+0000) Subject: return NULL right away if invalid length was passed X-Git-Tag: RELEASE_1_0_0RC1~614 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=fa2889fbb12b98b93a5f555d78c6f35d24fe9e45;p=php return NULL right away if invalid length was passed --- diff --git a/Zend/zend_operators.h b/Zend/zend_operators.h index a19e8f2892..626dbf010b 100644 --- a/Zend/zend_operators.h +++ b/Zend/zend_operators.h @@ -235,9 +235,13 @@ zend_memnstr(char *haystack, char *needle, int needle_len, char *end) static inline void *zend_memrchr(const void *s, int c, size_t n) { - register unsigned char *e = (unsigned char *)s + n; + register unsigned char *e; - for (e--; e >= (unsigned char *)s; e--) { + if (n <= 0) { + return NULL; + } + + for (e = (unsigned char *)s + n - 1; e >= (unsigned char *)s; e--) { if (*e == (unsigned char)c) { return (void *)e; }