From: David Majnemer <david.majnemer@gmail.com>
Date: Fri, 7 Jun 2013 22:07:20 +0000 (+0000)
Subject: Revert "Properly consider the range of enum for range comparisons in C mode"
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615d;p=clang

Revert "Properly consider the range of enum for range comparisons in C mode"

The approach r183084 took was wrong, back it out.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@183575 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp
index d1ba64e813..da24667804 100644
--- a/lib/Sema/SemaChecking.cpp
+++ b/lib/Sema/SemaChecking.cpp
@@ -4020,23 +4020,20 @@ struct IntRange {
     if (const ComplexType *CT = dyn_cast<ComplexType>(T))
       T = CT->getElementType().getTypePtr();
 
+    // For enum types, use the known bit width of the enumerators.
     if (const EnumType *ET = dyn_cast<EnumType>(T)) {
-      if (C.getLangOpts().CPlusPlus) {
-        // For enum types, use the known bit width of the enumerators.
-        EnumDecl *Enum = ET->getDecl();
-        if (!Enum->isCompleteDefinition())
-          return IntRange(C.getIntWidth(QualType(T, 0)), false);
+      EnumDecl *Enum = ET->getDecl();
+      if (!Enum->isCompleteDefinition())
+        return IntRange(C.getIntWidth(QualType(T, 0)), false);
 
-        unsigned NumPositive = Enum->getNumPositiveBits();
-        unsigned NumNegative = Enum->getNumNegativeBits();
+      unsigned NumPositive = Enum->getNumPositiveBits();
+      unsigned NumNegative = Enum->getNumNegativeBits();
 
-        if (NumNegative == 0)
-          return IntRange(NumPositive, true/*NonNegative*/);
-        else
-          return IntRange(std::max(NumPositive + 1, NumNegative),
-              false/*NonNegative*/);
-      } else
-        T = C.getCanonicalType(ET->getDecl()->getIntegerType().getTypePtr());
+      if (NumNegative == 0)
+        return IntRange(NumPositive, true/*NonNegative*/);
+      else
+        return IntRange(std::max(NumPositive + 1, NumNegative),
+                        false/*NonNegative*/);
     }
 
     const BuiltinType *BT = cast<BuiltinType>(T);
diff --git a/test/Sema/outof-range-constant-compare.c b/test/Sema/outof-range-constant-compare.c
index 5aa7bc8a80..4b1637c46c 100644
--- a/test/Sema/outof-range-constant-compare.c
+++ b/test/Sema/outof-range-constant-compare.c
@@ -147,11 +147,3 @@ int main()
 
     return 1;
 }
-
-typedef enum {
-    alpha=0, bravo, charlie, delta, echo
-} named_t;
-
-static int bar(named_t foo) {
-    return foo > 42;
-}