From: Nuno Lopes <nunoplopes@sapo.pt>
Date: Sun, 14 Dec 2008 21:53:25 +0000 (+0000)
Subject: dont call iterator::end() on every cycle and dont read already-deleted memory
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f9d1e4bc60690386e0b2c658d707b75a77717a9c;p=clang

dont call iterator::end() on every cycle and dont read already-deleted memory

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@61015 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/AST/DeclarationName.cpp b/lib/AST/DeclarationName.cpp
index 9535965ecf..044acd71d4 100644
--- a/lib/AST/DeclarationName.cpp
+++ b/lib/AST/DeclarationName.cpp
@@ -261,10 +261,11 @@ DeclarationNameTable::DeclarationNameTable() {
 DeclarationNameTable::~DeclarationNameTable() {
   llvm::FoldingSet<CXXSpecialName> *set =
     static_cast<llvm::FoldingSet<CXXSpecialName>*>(CXXSpecialNamesImpl);
-  llvm::FoldingSetIterator<CXXSpecialName> it = set->begin();
+  llvm::FoldingSetIterator<CXXSpecialName> I = set->begin(), E = set->end();
 
-  while (it != set->end()) {
-    delete &*it++;
+  while (I != E) {
+    CXXSpecialName *n = &*I++;
+    delete n;
   }
 
   delete set;