From: Daniel Jasper Date: Thu, 7 Nov 2013 19:56:07 +0000 (+0000) Subject: clang-format: Improve binary operator detection in macros. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f9504aa0c3fc7169d137b32d311f6c8102471cb1;p=clang clang-format: Improve binary operator detection in macros. Before: #define M(NAME) assert(!Context.Verifying &&#NAME); After: #define M(NAME) assert(!Context.Verifying && #NAME); This fixes llvm.org/PR16156. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@194216 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Format/TokenAnnotator.cpp b/lib/Format/TokenAnnotator.cpp index 69e558571f..5c70c8f914 100644 --- a/lib/Format/TokenAnnotator.cpp +++ b/lib/Format/TokenAnnotator.cpp @@ -620,7 +620,7 @@ private: Contexts.back().InCtorInitializer = true; } else if (Current.is(tok::kw_new)) { Contexts.back().CanBeExpression = false; - } else if (Current.is(tok::semi)) { + } else if (Current.is(tok::semi) || Current.is(tok::exclaim)) { // This should be the condition or increment in a for-loop. Contexts.back().IsExpression = true; } diff --git a/unittests/Format/FormatTest.cpp b/unittests/Format/FormatTest.cpp index 1822a24597..3684e071fd 100644 --- a/unittests/Format/FormatTest.cpp +++ b/unittests/Format/FormatTest.cpp @@ -4081,6 +4081,7 @@ TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) { verifyFormat("for (int i = 0; i < a * a; ++i) {\n}"); verifyGoogleFormat("for (int i = 0; i * 2 < z; i *= 2) {\n}"); + verifyFormat("#define A (!a * b)"); verifyFormat("#define MACRO \\\n" " int *i = a * b; \\\n" " void f(a *b);",