From: Chandler Carruth <chandlerc@gmail.com>
Date: Fri, 4 Nov 2016 07:16:33 +0000 (+0000)
Subject: Add a missing return to the move assignment operator for
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f85fa806307c367bab99d02e920d9c70d140e9de;p=llvm

Add a missing return to the move assignment operator for
SequenceNumberManager.

Sadly, we don't have any unittests for this class because it is
a private class. Since it seems to have a nice isolated and testable
interface, it'd be great to extract it to a detail namespace and write
unit tests for it as then we could catch issues. I'll probably pester
Lang about that or some alternative refactoring.

This was noticed by PVS-Studio.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@285990 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/llvm/ExecutionEngine/Orc/RPCUtils.h b/include/llvm/ExecutionEngine/Orc/RPCUtils.h
index b6c7b2e7bbc..436c037e920 100644
--- a/include/llvm/ExecutionEngine/Orc/RPCUtils.h
+++ b/include/llvm/ExecutionEngine/Orc/RPCUtils.h
@@ -700,6 +700,7 @@ private:
     SequenceNumberManager &operator=(SequenceNumberManager &&Other) {
       NextSequenceNumber = std::move(Other.NextSequenceNumber);
       FreeSequenceNumbers = std::move(Other.FreeSequenceNumbers);
+      return *this;
     }
 
     void reset() {