From: Serhiy Storchaka <storchaka@gmail.com>
Date: Thu, 25 Feb 2016 10:55:19 +0000 (+0200)
Subject: Issue #25801: Fixed resource warnings in test_zipfile64.
X-Git-Tag: v3.6.0a1~571^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f828218d652fe8120d88cfefa52df5c2039cdf92;p=python

Issue #25801: Fixed resource warnings in test_zipfile64.
Patch by SilentGhost.
---

diff --git a/Lib/test/test_zipfile64.py b/Lib/test/test_zipfile64.py
index b9e8e28667..c29bd8d2ec 100644
--- a/Lib/test/test_zipfile64.py
+++ b/Lib/test/test_zipfile64.py
@@ -72,15 +72,19 @@ class TestsWithSourceFile(unittest.TestCase):
     def testStored(self):
         # Try the temp file first.  If we do TESTFN2 first, then it hogs
         # gigabytes of disk space for the duration of the test.
-        for f in TemporaryFile(), TESTFN2:
+        with TemporaryFile() as f:
             self.zipTest(f, zipfile.ZIP_STORED)
+            self.assertFalse(f.closed)
+        self.zipTest(TESTFN2, zipfile.ZIP_STORED)
 
     @requires_zlib
     def testDeflated(self):
         # Try the temp file first.  If we do TESTFN2 first, then it hogs
         # gigabytes of disk space for the duration of the test.
-        for f in TemporaryFile(), TESTFN2:
+        with TemporaryFile() as f:
             self.zipTest(f, zipfile.ZIP_DEFLATED)
+            self.assertFalse(f.closed)
+        self.zipTest(TESTFN2, zipfile.ZIP_DEFLATED)
 
     def tearDown(self):
         for fname in TESTFN, TESTFN2: