From: Victor Stinner <victor.stinner@gmail.com>
Date: Wed, 14 Jun 2017 22:44:05 +0000 (+0200)
Subject: bpo-30284: Fix regrtest for out of tree build (#1481)
X-Git-Tag: v3.7.0a1~588
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f7e07840d725f2ebb469129cb5e6574ce61725ef;p=python

bpo-30284: Fix regrtest for out of tree build (#1481)

Use a build/ directory in the build directory, not in the source
directory, since the source directory may be read-only and must not
be modified.

Fallback on the source directory if the build directory is not
available (missing "abs_builddir" sysconfig variable).
---

diff --git a/Lib/test/libregrtest/main.py b/Lib/test/libregrtest/main.py
index e068b925d5..7b11fe951b 100644
--- a/Lib/test/libregrtest/main.py
+++ b/Lib/test/libregrtest/main.py
@@ -28,7 +28,13 @@ except ImportError:
 # to keep the test files in a subfolder.  This eases the cleanup of leftover
 # files using the "make distclean" command.
 if sysconfig.is_python_build():
-    TEMPDIR = os.path.join(sysconfig.get_config_var('srcdir'), 'build')
+    TEMPDIR = sysconfig.get_config_var('abs_builddir')
+    if TEMPDIR is None:
+        # bpo-30284: On Windows, only srcdir is available. Using abs_builddir
+        # mostly matters on UNIX when building Python out of the source tree,
+        # especially when the source tree is read only.
+        TEMPDIR = sysconfig.get_config_var('srcdir')
+    TEMPDIR = os.path.join(TEMPDIR, 'build')
 else:
     TEMPDIR = tempfile.gettempdir()
 TEMPDIR = os.path.abspath(TEMPDIR)