From: Moriyoshi Koizumi <moriyoshi@php.net>
Date: Thu, 3 Apr 2003 00:50:17 +0000 (+0000)
Subject: Fixed memleak in output buffering facility
X-Git-Tag: RELEASE_0_5~185
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f7a8499806c4fa7994fdff3655be5018f71f8b99;p=php

Fixed memleak in output buffering facility
---

diff --git a/main/output.c b/main/output.c
index 4109019a55..adfbc11d11 100644
--- a/main/output.c
+++ b/main/output.c
@@ -483,10 +483,10 @@ static int php_ob_init(uint initial_size, uint block_size, zval *output_handler,
 		/* do we have array(object,method) */
 		if (zend_is_callable(output_handler, 1, &handler_name)) {
 			SEPARATE_ZVAL(&output_handler);
-			output_handler->refcount++;
 			result = php_ob_init_named(initial_size, block_size, handler_name, output_handler, chunk_size, erase TSRMLS_CC);
 			efree(handler_name);
 		} else {
+			efree(handler_name);
 			/* init all array elements recursively */
 			zend_hash_internal_pointer_reset_ex(Z_ARRVAL_P(output_handler), &pos);
 			while (zend_hash_get_current_data_ex(Z_ARRVAL_P(output_handler), (void **)&tmp, &pos) == SUCCESS) {
@@ -500,7 +500,6 @@ static int php_ob_init(uint initial_size, uint block_size, zval *output_handler,
 	} else {
 		if (output_handler) {
 			SEPARATE_ZVAL(&output_handler);
-			output_handler->refcount++;
 		}
 		result = php_ob_init_named(initial_size, block_size, OB_DEFAULT_HANDLER_NAME, output_handler, chunk_size, erase TSRMLS_CC);
 	}