From: Nikita Popov <nikita.ppv@gmail.com>
Date: Tue, 23 Jun 2020 10:35:51 +0000 (+0200)
Subject: Avoid convert_to_long_ex usage in readline
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f7a3cb4c39a795e47cc3cbf024f4235331736317;p=php

Avoid convert_to_long_ex usage in readline
---

diff --git a/ext/readline/readline.c b/ext/readline/readline.c
index 327c55f281..deb55c834e 100644
--- a/ext/readline/readline.c
+++ b/ext/readline/readline.c
@@ -201,8 +201,7 @@ PHP_FUNCTION(readline_info)
 		} else if (!strcasecmp(what, "done")) {
 			oldval = rl_done;
 			if (value) {
-				convert_to_long_ex(value);
-				rl_done = Z_LVAL_P(value);
+				rl_done = zval_get_long(value);
 			}
 			RETVAL_LONG(oldval);
 		} else if (!strcasecmp(what, "pending_input")) {
@@ -239,8 +238,7 @@ PHP_FUNCTION(readline_info)
 		} else if (!strcasecmp(what, "erase_empty_line")) {
 			oldval = rl_erase_empty_line;
 			if (value) {
-				convert_to_long_ex(value);
-				rl_erase_empty_line = Z_LVAL_P(value);
+				rl_erase_empty_line = zval_get_long(value);
 			}
 			RETVAL_LONG(oldval);
 #endif
@@ -261,8 +259,7 @@ PHP_FUNCTION(readline_info)
 		} else if (!strcasecmp(what, "attempted_completion_over")) {
 			oldval = rl_attempted_completion_over;
 			if (value) {
-				convert_to_long_ex(value);
-				rl_attempted_completion_over = Z_LVAL_P(value);
+				rl_attempted_completion_over = zval_get_long(value);
 			}
 			RETVAL_LONG(oldval);
 		}