From: Tim Peters <tim.peters@gmail.com>
Date: Mon, 31 Jul 2006 02:53:03 +0000 (+0000)
Subject: ZipFile.close():  Kill the other struct.pack deprecation
X-Git-Tag: v2.5b3~35
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f79c32dbfb063703a0474b13dd87bbaa4587d5e6;p=python

ZipFile.close():  Kill the other struct.pack deprecation
warning on Windows.

Afraid I can't detect a pattern to when the pack formats decide
to use a signed or unsigned format code -- appears nearly
arbitrary to my eyes.  So I left all the pack formats alone and
changed the special-case data values instead.
---

diff --git a/Lib/zipfile.py b/Lib/zipfile.py
index 2819f1bd14..5c3fff3e74 100644
--- a/Lib/zipfile.py
+++ b/Lib/zipfile.py
@@ -664,7 +664,7 @@ class ZipFile:
 
                 if zinfo.header_offset > ZIP64_LIMIT:
                     extra.append(zinfo.header_offset)
-                    header_offset = 0xffffffff #-1
+                    header_offset = -1  # struct "l" format:  32 one bits
                 else:
                     header_offset = zinfo.header_offset