From: Mat M <mathew1800@gmail.com>
Date: Mon, 13 Nov 2017 07:50:16 +0000 (-0500)
Subject: bpo-32013: _pickle: Add missing Py_DECREF in error case in fast_save_enter() (#4384)
X-Git-Tag: v3.7.0a3~177
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f76231f89a7231fd486b37f728fbb4aab389e4d7;p=python

bpo-32013: _pickle: Add missing Py_DECREF in error case in fast_save_enter() (#4384)
---

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index b71fb9350e..4b7f1ed66b 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -1777,8 +1777,10 @@ fast_save_enter(PicklerObject *self, PyObject *obj)
             }
         }
         key = PyLong_FromVoidPtr(obj);
-        if (key == NULL)
+        if (key == NULL) {
+            self->fast_nesting = -1;
             return 0;
+        }
         if (PyDict_GetItemWithError(self->fast_memo, key)) {
             Py_DECREF(key);
             PyErr_Format(PyExc_ValueError,
@@ -1789,6 +1791,8 @@ fast_save_enter(PicklerObject *self, PyObject *obj)
             return 0;
         }
         if (PyErr_Occurred()) {
+            Py_DECREF(key);
+            self->fast_nesting = -1;
             return 0;
         }
         if (PyDict_SetItem(self->fast_memo, key, Py_None) < 0) {