From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sat, 19 Feb 2022 06:48:51 +0000 (-0800)
Subject: CI: remove the use of '$OS_ID' during testing
X-Git-Tag: 3.0.0~21^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f7463851a0526846a1cb17921842ce67b81a8b98;p=graphviz

CI: remove the use of '$OS_ID' during testing

This commit alters the CI tests to now pull OS information from /etc/os-release
instead of from an ad hoc environment variable. This makes test case execution
independent from which/whether environment variables have been exported. The
intent with this is to reduce the likelihood of an issue like that fixed in
50db0c5e8da293d816d8b5c4620f2fa2d311d37a being reintroduced.
---

diff --git a/ci/tests.py b/ci/tests.py
index 5a2327a86..221b30067 100644
--- a/ci/tests.py
+++ b/ci/tests.py
@@ -128,7 +128,7 @@ def test_existence(binary: str):
     "smyrna",
   ]
 
-  os_id = os.getenv("OS_ID")
+  os_id = _freedesktop_os_release().get("ID")
 
   # FIXME: Remove skip when
   # https://gitlab.com/graphviz/graphviz/-/issues/1835 is fixed