From: René Scharfe <l.s.r@web.de>
Date: Sat, 15 Jul 2017 18:33:54 +0000 (+0200)
Subject: receive-pack: don't access hash of NULL object_id pointer
X-Git-Tag: v2.15.0-rc0~212^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f730944a49b2a210bb10520700c0a3f6c49bc020;p=git

receive-pack: don't access hash of NULL object_id pointer

We set old_oid to NULL if we found out that it's a corrupt reference.
In that case don't try to access the hash member and pass NULL to
ref_transaction_delete() instead.

Found with Clang's UBSan.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index b1706a5731..f589e8aebf 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -1137,7 +1137,7 @@ static const char *update(struct command *cmd, struct shallow_info *si)
 		}
 		if (ref_transaction_delete(transaction,
 					   namespaced_name,
-					   old_oid->hash,
+					   old_oid ? old_oid->hash : NULL,
 					   0, "push", &err)) {
 			rp_error("%s", err.buf);
 			strbuf_release(&err);